From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id CCFF47803CE for ; Mon, 5 Aug 2024 03:47:06 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=yQZa0yGLuqBzkYOTbZdETJUfkwGUJYyfLssB86uSAd0=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:User-Agent:Subject:To:Cc:References:From:In-Reply-To:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20240206; t=1722829626; v=1; b=RY8pAxLQ/Cyl36W5HHDdjZ+drTnzAnUhjEG8MTuQKEvb0ZctNoUynGWnXVF2y5Aa5+NNR2+0 ieFHB6GTxFv72SRcRIRDsb7UKs2QcX7QQ0xny0uxMtvYdM+68+v2kJgVWvOq3gk7nZfeWntNMhE k6MPBDpN+U11PoRTlfo7doFk8weDbj/XaBZEW3GkVnMu9Mcsvr5w4OzlU+CzZmwAE25TWnRXmPW mYKiM56H7OVvuVOIow9nKdPAE1bp3a77kuyNWJyNNJWP2neitQBVmuSFUKdBVE3EKdHkaG9G286 tWu6UGSt7tts/4SWbdr9Hml3mIHLkPNcsnF9IWnRWmB0Q== X-Received: by 127.0.0.2 with SMTP id 3hqUYY7687511xqyfjEYQakF; Sun, 04 Aug 2024 20:47:04 -0700 X-Received: from CY4PR05CU001.outbound.protection.outlook.com (CY4PR05CU001.outbound.protection.outlook.com [40.93.198.123]) by mx.groups.io with SMTP id smtpd.web11.503.1722829624106959399 for ; Sun, 04 Aug 2024 20:47:04 -0700 X-Received: from PH0PR01MB7287.prod.exchangelabs.com (2603:10b6:510:10a::21) by LV8PR01MB8477.prod.exchangelabs.com (2603:10b6:408:188::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7828.26; Mon, 5 Aug 2024 03:47:00 +0000 X-Received: from PH0PR01MB7287.prod.exchangelabs.com ([fe80::fc79:e629:93aa:8b8f]) by PH0PR01MB7287.prod.exchangelabs.com ([fe80::fc79:e629:93aa:8b8f%3]) with mapi id 15.20.7807.026; Mon, 5 Aug 2024 03:47:00 +0000 Message-ID: Date: Mon, 5 Aug 2024 10:46:54 +0700 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] [edk2-platforms][PATCH 1/5] AmpereAltraPkg/DwI2cLib: Add SmbusRead() function To: devel@edk2.groups.io, quic_llindhol@quicinc.com Cc: chuong@os.amperecomputing.com, rebecca@os.amperecomputing.com References: <20240801093618.191274-1-nhi@os.amperecomputing.com> <20240801093618.191274-2-nhi@os.amperecomputing.com> From: "Nhi Pham via groups.io" In-Reply-To: X-ClientProxiedBy: SI2PR02CA0016.apcprd02.prod.outlook.com (2603:1096:4:194::9) To PH0PR01MB7287.prod.exchangelabs.com (2603:10b6:510:10a::21) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH0PR01MB7287:EE_|LV8PR01MB8477:EE_ X-MS-Office365-Filtering-Correlation-Id: 880807e1-cfda-42ba-ab67-08dcb50142ca X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Message-Info: =?utf-8?B?SmdobFlwUzBTTE5za2dsQkFLV1p2UGgveEZNd2YvUzl0OVptNjczbzVVMDVw?= =?utf-8?B?cGJ0SFhuc0FOSjAwKzdqdTYrUTRrdS8yZmMwaDhRTlJCeTAxU0hlcHZsdjlD?= =?utf-8?B?bWFZSXNpWmdhVGtWVE16aW9SNzl1b0w3YTZSaTVvWlJrYkl0dFlyZlBJZS9I?= =?utf-8?B?N09ZVUt6Y3JlTEtlV0dBbGRxRFBUdGVrSU80VjgzQ3RKVkhwTHJiRyt5UEw0?= =?utf-8?B?SGhuMDZoeWU2YnErbTk3UTlGbUlMUHhycFZUQ1EvT0hxYzVsdTZTTXpNcXc4?= =?utf-8?B?NkovL1AzQytmVHJWU3NiV0lBVlJRaC9FUGNYVkZrWHl3TkFqV1NaM1lXUTZs?= =?utf-8?B?T1dXWnFSMFB2enRzSFY1ZUJGdU94eU5Ma041NUVxMzBHVlJMY3BQQ0VZaTVS?= =?utf-8?B?OVA2NFNmT3F2aU1HRHAxZk9iM2JQamsvR1NwZjFJUG5JM3J2MU52dVRlbEI1?= =?utf-8?B?eGo1YnVuY1FSMlJGWjNPNmJFeVJwZ3dUT0prSm1OenQ5SUczditkUHFHaHZI?= =?utf-8?B?UkpkYnBXS0hadUd0SlhpMW5rcWYyN0h0QlIvUDg4a0hONGNXaUJHNHIwMXZQ?= =?utf-8?B?L1lPN2V2RWp0QXROSVpiUFBBdVczZkdhTmFUUDdRM2NjTlVqaVR2ekM1aXJQ?= =?utf-8?B?N0hjNklVNlB5RkZzbk9JM2JaMHh4QW16bysrdng5OUpOcXNBbXoxVTVCQmlN?= =?utf-8?B?ZmVTM3JKUFkvc2dhTU9mOTh4VGtpM1kyb3lJbUJDeUp0aGxFWXZmcjlpUW9u?= =?utf-8?B?d2lacXRzdW5UdGtkSVpUdS9jcldYdC9GMVMvRkRkcXg5MkdzYWwrNTJ5bUFJ?= =?utf-8?B?a3k2bUlZdk54REd1ZVVNbjRSUnIreElNUVpjVlllUkdkSVZ2a1M4WTBWNWdE?= =?utf-8?B?VlVMMUhrcjhiZ1RWdW9LVjdvTk55VTNUZ3pqVms0QS9PWFJXeXdISnFOWCtv?= =?utf-8?B?YmZ3N3o2WGZQbVpkZjQrTGYwMWcrUnRZcWVINjFlWHBNbFpGOTFCTSs1QUQ4?= =?utf-8?B?V0ZQbElUNk4vaWJGNFVvQ3JwengxeVFNM1FSWlNoa2JkTlY2a0NCTUdYaGZi?= =?utf-8?B?cGdQTy9PazFwSGFpYTRrZzBrZHZCclRYRlpuYzk4WmhZaU5Fa25uMFlmOHNp?= =?utf-8?B?TlE2eUNxQ21Yc3JFRlV4cVZuOUZ1cS9lVk9PRWtsSWZDN2grRnZINkdBbkhN?= =?utf-8?B?QVlvQW5OK3dERDZ4QTVMOUNpeitjNVBnRU5kUkFxZjZBT01nSnVGZFNmQndC?= =?utf-8?B?dDV6dklqeldNa2JibFFQT202cXhvKzJFKzB4R2sxTFpMdGpYc1lNUVZXeGFy?= =?utf-8?B?QTVBdFhLSjJxSzEvNnBNYmQrL0xodVNuSmc5WnZ5RDVWbzhoNW9DbDlWc2wz?= =?utf-8?B?ckxnMGRJSnNZTjZwU0g2V1J5VGpCTXUrd3QwWWpIc1p6MzFjalR3cUF1MTZQ?= =?utf-8?B?SWVVSForZ2wzYmkrNXBuWm5Danh4d3JmOEhLMi9kREhEKzR1ZHFuUnlyMzhj?= =?utf-8?B?eVJ2a2JDeGdSSkk3WXNvVFROSkRBRTlLL0NYWjZyVVkzZkYyU3NTZkRmR2hy?= =?utf-8?B?N2N3US9Wc1dtZC9WZ1AwU0xTazEvOW9PN3hYUU1rOEhkWjIySEVrVVBLWW5k?= =?utf-8?B?RzdlRGlaRkpGMjFGUVpjamZyWXpWc2E0NU9IUy85OCt3MXBDRnF4WlRVTmJ6?= =?utf-8?B?VWpaRVg1bXlLa2hJTVp4YnZjSzdyMWNSYUtaRDhlQzI2NnAyTXNvczloTkd6?= =?utf-8?B?VmNLRUtHMjluSGplc012RHN4ckFWK1lQK2NZR3pwVXFvZU9kYlVCUVQ0bDNG?= =?utf-8?B?d2ZIZUQvZThiMFlhZmZDZz09?= X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ckVxeXRjMkYzYzlhblJKbVNyUEZNMXpkRVE3bUlYQm5nY3VoWjVjY1JERFBm?= =?utf-8?B?SExOb1Q3YXpQMmI0QWptT1QzS3FnR25PV2ZTM0JYcWt1bmlGVmo0bGVFOEpr?= =?utf-8?B?b3c3T04wYWl3QjVvUWRkcENjTDJtZmlocXdscU00QVYvSVgvbE1TVktKRVBQ?= =?utf-8?B?ZklBN0NxWGZKTm5FVE5UU2RDZUp1VW1jYnAwYXNKWm93RlVBaXlIcGVvTW0r?= =?utf-8?B?d0txa292enlIQVZGek9GYkZlN0JWRHEvV0QwV25lZ0tvbTJoRmRhTkYxbjF3?= =?utf-8?B?R1FsS3VnRUNYSEk0WnUyWUszcHVjWHc4MXB1cDBJU2lkZE1SSnNrcnp4Yy9v?= =?utf-8?B?bHRnRkhsS2pwRHJBWC82L0hQdEZCZUJHMkMraU9LaG91Q1gxUXRML04wK1Jj?= =?utf-8?B?cExTUG82TURVazhnT2V3cGYzMlhGTHU0YTl6K3hLZ0N1ZEo2ZStZdnEzbHl5?= =?utf-8?B?OW14THVRZzN4dGZRSGxmaTFuM0QvaGNRY01LNjcvNDRNVFNJUWZpK0VnUmpX?= =?utf-8?B?Qlo4Z3NjazVjZ0dsN2J1ZWZmeWdGaGJoc05hM1pxMm83eEVjL3RnRkJUS0tl?= =?utf-8?B?TEtTRFdjclh3NmlPK2JlcytvUXRSd0kvYVQvYzhyTGUwbWZvZlFOVWk5U2ly?= =?utf-8?B?ODZMN3ZHcjcrTGpsTjlPYStFWEo0bmlZSDI1dS9WdDVGWnhXNGkvc1BUSWlq?= =?utf-8?B?ZU9FcXdldVFaeUVZd2tQSHRCTjBQekp2cnRRQkxwcW1qaVkzRDZOc2VGWWtr?= =?utf-8?B?MDZCYlFEU1lNWlloelUrS29sRldJTCtXT281dUNacmVsZEVPak9kMGxiVUdG?= =?utf-8?B?VGJNbjc2b3UrOFVrZ01CWTk3SUF2RjYwQmh5T0k1VVY5aTdiZmh1U2luVnY0?= =?utf-8?B?YU56ZndiNE10L0c1NlFGV0V3THIwQ3lNSk1Vek4yeDhpb29NOVFIRUxPUmIx?= =?utf-8?B?TndUSDRQWTBRQXZCUVhvWm50ZVpsWFFmSlQxZHl6RFc4UlhjamhxQW0zdVNq?= =?utf-8?B?dlQ3MVdoOWo1QUVDR0t2OUIrTVcvUWRlbTF4UVhLUGN1Q1hoUndtc2grc0VY?= =?utf-8?B?WDg5S0RERlpINmxmSFVRd1hRQUFPbkQ0WWFjTTVMU1diMTR1b3QrUTZNZE5P?= =?utf-8?B?cCt3WDNTMVpaMG1WOU5kRE5BNW5KQm5iQ2xrUC9FQWpTSEprWFJSOExtb2xQ?= =?utf-8?B?RklLWEFrMnpzR3laYUdNdWNFY1gxYXFHOTRqVkxuZ1l6VlpnN2lQR1diLzNO?= =?utf-8?B?RzcwTzZBaTJrUmpWclR1YjYxUmwxd2NSYktxd0hLRDBMc25kK3dJaG5JSjAy?= =?utf-8?B?T1BSaWVaYUpiWXNPUW9XRFFpeWgwVkxxTVA0Y0tST01mYmw2WCthOWxVTE9r?= =?utf-8?B?aTh3T2xuR05xS2E4YnRvb3RXSmNqbjFiV2ViaDZ6RkpLNWRZaEdHU1JGbS9p?= =?utf-8?B?L0IvS3lRM1lUa3RjYVRyNEZiWkhmYVpkamZaVDVJUjJ0NU92SG1MQTBheEpR?= =?utf-8?B?SGl3OHJKQnpZQmNUdW5vTjQxbVBTeU1kSEhXNU1aSnFYWjJ0K24zRFQvQlVE?= =?utf-8?B?NXV6dTdyYjEwdWNnRlZwTTFreDJwNk1PV2pVMERISCtsRHZZWDFmWnJHWStO?= =?utf-8?B?YnV0K3gyLzJpcDJIaW4veFBtNHJYZlhsZDJKb1o1djI1ODcrU1E5UDE5S0k0?= =?utf-8?B?bWpZNHlkZ2NLUFgwemtxYjE3QVN4RGFJY1NJSnlsSU56b0s0RS9oVW5TSi9u?= =?utf-8?B?anlSZ0d1anRVWlV0am4wa3Jsa1hjM0R6aEJSUjI0cTcwUHgxQitXTG5xbHFO?= =?utf-8?B?U0RPV292NUVPaENVTHIxdXE5YS9xWWkvL015RGNEN0xwTW5pRFNZK0ttSVA3?= =?utf-8?B?RDRDMGttaStrR1N0YjdCby9uTTZ2REZkbFhrRGRlQW5sVlN0SzlIaW50UkdD?= =?utf-8?B?NGpja1VoUi80UHNkVHY2dENBdmdHa2hPUkp6aENncDNwQWJhSEt5NkJBY0RQ?= =?utf-8?B?bys5UVZIVzJZOUlpUmhGWW04RXVBSlIvSDJXTmFvRU1TTDE5ZlloRkpoSFZz?= =?utf-8?B?WEw3bHcyd2F0SEsxNHBsRFdKQURnWGdxTzVBeHZwUndxYTZ0OThxWXM0VGtY?= =?utf-8?B?Y2N0OTZNbEtrMGVrc0lnME5hVlRBTjFBSVprRzBRMmdBSEhRVXhVdFNLalYv?= =?utf-8?B?bWc9PQ==?= X-OriginatorOrg: os.amperecomputing.com X-MS-Exchange-CrossTenant-Network-Message-Id: 880807e1-cfda-42ba-ab67-08dcb50142ca X-MS-Exchange-CrossTenant-AuthSource: PH0PR01MB7287.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Aug 2024 03:47:00.0561 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: yLK1kscm8PY1DS5MQOzJagqpmanYDRpJKXfnL2StNBtWJ4MXz1dKQQZ0QmXpZi/aNHopqivkphCk/WIThQRhhUEA/Ghz9N/9nh0x9mZ2zr8= X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV8PR01MB8477 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Sun, 04 Aug 2024 20:47:04 -0700 Resent-From: nhi@os.amperecomputing.com Reply-To: devel@edk2.groups.io,nhi@os.amperecomputing.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: NAhTOAxHPXZLgyQF5HfEjsEex7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=RY8pAxLQ; dmarc=pass (policy=none) header.from=groups.io; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io On 8/1/2024 10:18 PM, Leif Lindholm via groups.io wrote: > On Thu, Aug 01, 2024 at 16:36:14 +0700, Nhi Pham via groups.io wrote: >> This adds the SmbusRead() function designed for SMBUS transaction to >> support the extraction of the data lenth byte from the initial byte of >> the SMBUS Block Read, allowing the I2C master to accurately read the >> SMBUS response with the exact data length. This addresses the issue >> where the SmbusLib:SmBusReadBlock() function consistently reads a >> 32-byte block of data. >=20 > This change also changes the API to pass the PecCheck parameter, > without actuaklly using it for anyone. Regardless of my previous > comment, I don't think that's very useful. > So if you can't move it to the struct, can you move it to the later > patch instead? >=20 > / > Leif >=20 I will try to split them out. Regards, Nhi -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#120221): https://edk2.groups.io/g/devel/message/120221 Mute This Topic: https://groups.io/mt/107662232/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-