From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=209.85.221.47; helo=mail-wr1-f47.google.com; envelope-from=philmd@redhat.com; receiver=edk2-devel@lists.01.org Received: from mail-wr1-f47.google.com (mail-wr1-f47.google.com [209.85.221.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id ECFD0211C2804 for ; Thu, 7 Feb 2019 09:48:30 -0800 (PST) Received: by mail-wr1-f47.google.com with SMTP id z3so812475wrv.3 for ; Thu, 07 Feb 2019 09:48:30 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:openpgp:cc:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=EU3NjBkl5yoU/Ne4iaXnjF06kzoTYfiLL2jbRDhR7DE=; b=AgN/b4vaXMdIjjFRs5l0O0MiqK++9SBj26ZcTRX+dxU6m0RKipQsEUtoXg6JiZNS5k YKGLvMS7ZK4zKAXotoSzEZVuE8CG2z3mvs1f2dtZVfiKcZ2m8/ZVte6h+Vrtnjq7BF+s uzgmDUJxB9C0Fq9U5KQp88TK3B14OP4U8oEgte7fU+ZpWkDUTcAwnvF+aO9dHA1bUfHE Wogm6E9WJq1UrIWxYPsoTEAuxT+6oFN0uWXTaCYg5MHIxR06/BSlZ/9VHiJhJrpCmFrq foYxt93ub4X+2ZaCHNNX/rh6eu4kpuzrM/XMgZyq4zZS14J6rvjkeIpP807Iyi79w+0A eXRg== X-Gm-Message-State: AHQUAubrVDXJsn18bzlFBErSrXcII+00rGJfmXMr0FonSIn1OEJNdEZq RpHeZpPOMklSqwTOahRAZKavrw== X-Google-Smtp-Source: AHgI3IZSSt0OqsPXcrBJJiX5LyaRZntSME3TdL3ylHdZj8Hzq6vJEICrdQQmnTyAscRp4ZCV6xdwsQ== X-Received: by 2002:adf:b783:: with SMTP id s3mr13938247wre.274.1549561708863; Thu, 07 Feb 2019 09:48:28 -0800 (PST) Received: from [192.168.1.103] (10.red-83-35-153.dynamicip.rima-tde.net. [83.35.153.10]) by smtp.gmail.com with ESMTPSA id b129sm18891499wmd.24.2019.02.07.09.48.27 (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128); Thu, 07 Feb 2019 09:48:27 -0800 (PST) To: Antoine Coeur , edk2-devel@lists.01.org References: <1335c2cc-7697-96cb-9121-e8b88cbf31fe@redhat.com> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Openpgp: id=89C1E78F601EE86C867495CBA2A3FD6EDEADC0DE; url=http://pgp.mit.edu/pks/lookup?op=get&search=0xA2A3FD6EDEADC0DE Cc: Laszlo Ersek Message-ID: Date: Thu, 7 Feb 2019 18:48:26 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: Subject: Re: [PATCH v2] ArmVirtPkg: Fix various typos X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Feb 2019 17:48:31 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Hi Antoine, On 2/7/19 6:13 PM, Antoine Coeur wrote: > Thank you Laszlo. > > Do you have any recommendations regarding the maximum size of a patch for smooth reviewing on this mailing list? > I have about 9000 lines of additional typos corrections in queue at https://github.com/Coeur/edk2/tree/typo, but I'm afraid that big patches will simply be ignored. I tagged your "BaseTools: Fix various typos" patch for review, but it is true than after reading the diff stats "172 files changed, 513 insertions(+), 518 deletions(-)" I procrastinated and skipped to the next patch to review... The rule of thumb I learned is the limit to the magic number 20, probably related to our number of fingers/toes :P For example you could split the previous patch in: BaseTools/Source/C/Common BaseTools/Source/C/VfrCompile BaseTools/Source/C/* (other) BaseTools/Source/Python And it would be more digest. > If I split them in small patches, how many patches can I post every day? Or should I post a hundred patches at the same time and reviewers won't freak out? The list shouldn't have limition in how many patches you can send, the bottleneck here is the human brain and how many patches a reviewer can take. Since your patches are related (all fixes typos), what would help is if you group your patches in series, instead of sending separately. Same here, I recommend the 20 limit. For example you can send various series of up-to 20 patches, like: - Board X + Y - Board Z - Package X - Module Y - Arm - Intel > Or could we exceptionally allow pull requests on GitHub for those typos changes, as it doesn't involve actual code-change? That could be an interesting experiment that would prevent cluttering the mailing-list. There is a study in progress to use another workflow than mailing list, but we are not there yet. Anyway, don't worry about stressing the mailing list ;) Regards, Phil. > > Coeur >   >   > > Gesendet: Donnerstag, 07. Februar 2019 um 21:33 Uhr > Von: "Laszlo Ersek" > An: "Antoine Coeur" , edk2-devel@lists.01.org > Betreff: Re: [edk2] [PATCH v2] ArmVirtPkg: Fix various typos > > Pushed as commit 7a90895306ac. > > Thanks, > Laszlo > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel >