From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mail-ej1-f67.google.com (mail-ej1-f67.google.com [209.85.218.67])
 by mx.groups.io with SMTP id smtpd.web11.6616.1603253245817808333
 for <devel@edk2.groups.io>;
 Tue, 20 Oct 2020 21:07:26 -0700
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@nuviainc-com.20150623.gappssmtp.com header.s=20150623 header.b=rdA/0pGs;
 spf=pass (domain: nuviainc.com, ip: 209.85.218.67, mailfrom: rebecca@nuviainc.com)
Received: by mail-ej1-f67.google.com with SMTP id dt13so908560ejb.12
        for <devel@edk2.groups.io>; Tue, 20 Oct 2020 21:07:25 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=nuviainc-com.20150623.gappssmtp.com; s=20150623;
        h=subject:to:cc:references:from:message-id:date:user-agent
         :mime-version:in-reply-to:content-transfer-encoding:content-language;
        bh=VvVLmd+W2xhxKopoxzc8b+QFRjsNlnBP7dnF1hHjC4U=;
        b=rdA/0pGsh5KiTmGYWvgFwEsbg46qWY6RTGKnOOT8GzjwToppmoN1nIhOJcFZqNLq2i
         Js4jaRKssbALx3ZxRzeLbNmcK1vWi68rWYq6thDvKoVqJWtg1FSUY44qcg2nsJjPZ2Yp
         2mmCw7/EkH7PsrVNfA/p3eu9lJb90Hvm0l7qpNBa3rhwiadSHTVDvrY0TUxEGnADwYu8
         STwSzHz28H/hjMFml+BpOMvjndEcdlduv/8MuJfn8hQGNuk5+dtBzJbmOd1Cdar7deVF
         Go3lD4mKmfrUoTL/Lm+x1YRxN2cCKKShjR25A8NHM98NQiznjqFTopv0yI6dFzAvW1KF
         saxA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:subject:to:cc:references:from:message-id:date
         :user-agent:mime-version:in-reply-to:content-transfer-encoding
         :content-language;
        bh=VvVLmd+W2xhxKopoxzc8b+QFRjsNlnBP7dnF1hHjC4U=;
        b=aaH9s07fP9XFM79wv/cHONu2t1fAujF11oPe6EKz1RTk+ZdUJhMyiUh+YlXKDUYXtE
         48ed7VFjd9XRoAoZDH0qn+mKHOM+2a74NlqH2bI43sngJTfEyy7t6hG2Tbz5P4VIZqbz
         oBtG593NAmW0iuLrScZ0Il6pK7G6764wqognxgn3hLyLWw3Re0TZtjWk/LPE0b32xpc2
         iFucxeXHRFfgN7lpIm1oE2m6hXAnc5ISNACsxHm70ahkdARZ+Ofu6lH+THMX+UqVWix6
         Q9hmAfIWc+i7vj2d8I8jxFkkTy0SE6dot2Xw1cJP38pbaDSaJi7+bfTfabEd2ue2p6oQ
         FEHw==
X-Gm-Message-State: AOAM530YQzArAtuYGRm9LBNqUZKR6OTfDej1VuQhEjDOuoIwXkDCi5M0
	6oQ9GqlF58jRq5Zo9Cfkb65QIg==
X-Google-Smtp-Source: ABdhPJxZXWhb0/HzAmTjrkq24xqiC6CzLgFVaVOye4Hu31LBwSfy+3+IFB/3qN33B2xAKaj3DL2tyw==
X-Received: by 2002:a17:906:1446:: with SMTP id q6mr1432556ejc.549.1603253244276;
        Tue, 20 Oct 2020 21:07:24 -0700 (PDT)
Return-Path: <rebecca@nuviainc.com>
Received: from [10.0.10.142] (c-174-52-16-57.hsd1.ut.comcast.net. [174.52.16.57])
        by smtp.gmail.com with ESMTPSA id p9sm1130504ejo.75.2020.10.20.21.07.23
        (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
        Tue, 20 Oct 2020 21:07:23 -0700 (PDT)
Subject: Re: [EXTERNAL] RE: [PATCH 1/1] ShellPkg: Fix a couple of typos in smbiosview
To: "Gao, Zhichao" <zhichao.gao@intel.com>,
 "devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Ni, Ray" <ray.ni@intel.com>
References: <20201020161643.20293-1-rebecca@nuviainc.com>
 <MWHPR11MB164730B655B66785F7C68BE9F61C0@MWHPR11MB1647.namprd11.prod.outlook.com>
From: "Rebecca Cran" <rebecca@nuviainc.com>
Message-ID: <b5aa06f0-a773-2b96-b1f1-8efa8e713ead@nuviainc.com>
Date: Tue, 20 Oct 2020 22:07:21 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.4.0
MIME-Version: 1.0
In-Reply-To: <MWHPR11MB164730B655B66785F7C68BE9F61C0@MWHPR11MB1647.namprd11.prod.outlook.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US

On 10/20/20 7:33 PM, Gao, Zhichao wrote:

> The string ID is also incorrect. See 'FORM'. I think we should change it as well.

I noticed that, but wasn't sure if I should fix it. I think I should fix 
it in a separate patch - do you agree?


-- 

Rebecca Cran