From: Laszlo Ersek <lersek@redhat.com>
To: Shenglei Zhang <shenglei.zhang@intel.com>, edk2-devel@lists.01.org
Cc: Liming Gao <liming.gao@intel.com>
Subject: Re: [PATCH 04/10] BaseTools/tools_def.template: Remove UNIXGCC
Date: Fri, 1 Feb 2019 09:52:36 +0100 [thread overview]
Message-ID: <b5e0071a-65b6-b022-a3e6-2c6fe4a52b38@redhat.com> (raw)
In-Reply-To: <20190201053445.13660-5-shenglei.zhang@intel.com>
On 02/01/19 06:34, Shenglei Zhang wrote:
> UNIXGCC is too old.There is no verification for it.
> https://bugzilla.tianocore.org/show_bug.cgi?id=1377
>
> Cc: Bob Feng <bob.c.feng@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Yonghong Zhu <yonghong.zhu@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
> ---
> BaseTools/Conf/tools_def.template | 96 -------------------------------
> 1 file changed, 96 deletions(-)
>
> diff --git a/BaseTools/Conf/tools_def.template b/BaseTools/Conf/tools_def.template
> index 162227ace1..ab5dc78b19 100755
> --- a/BaseTools/Conf/tools_def.template
> +++ b/BaseTools/Conf/tools_def.template
> @@ -138,29 +138,6 @@ DEFINE EBC_BINx86 = C:\Program Files (x86)\Intel\EBC\Bin
>
> DEFINE ELFGCC_BIN = /usr/bin
>
> -#
> -# Option 1: Hard coded full path to compiler suite
> -DEFINE UNIXGCC_IA32_PETOOLS_PREFIX = /opt/tiano/i386-tiano-pe/i386-tiano-pe/bin/
> -DEFINE UNIXGCC_X64_PETOOLS_PREFIX = /opt/tiano/x86_64-pc-mingw64/x86_64-pc-mingw64/bin/
> -#
> -# Option 2: Use an environment variable
> -#DEFINE UNIXGCC_IA32_PETOOLS_PREFIX = ENV(IA32_PETOOLS_PREFIX)
> -#DEFINE UNIXGCC_X64_PETOOLS_PREFIX = ENV(X64_PETOOLS_PREFIX)
> -#
> -# Option 3: Install the compiler suite into your default paths
> -#DEFINE UNIXGCC_IA32_PETOOLS_PREFIX = i386-pc-mingw32-
> -#DEFINE UNIXGCC_X64_PETOOLS_PREFIX = x86_64-pc-mingw32-
> -#
> -# Option 4: Create links under the BaseTools/Bin/gcc/ARCH directory
> -# Links needed: gcc, ar & ld
> -#DEFINE UNIXGCC_IA32_PETOOLS_PREFIX = ENV(WORKSPACE)/BaseTools/Bin/gcc/Ia32/
> -#DEFINE UNIXGCC_X64_PETOOLS_PREFIX = ENV(WORKSPACE)/BaseTools/Bin/gcc/X64/
> -#
> -# Option 5: Install programs under user's home directory
> -#DEFINE UNIXGCC_IA32_PETOOLS_PREFIX = ENV(HOME)/programs/gcc/ia32/bin/i686-pc-mingw32-
> -#DEFINE UNIXGCC_X64_PETOOLS_PREFIX = ENV(HOME)/programs/gcc/x64/bin/x86_64-pc-mingw32-
> -#
> -
> DEFINE CYGWIN_BIN = c:/cygwin/bin
> DEFINE CYGWIN_BINIA32 = c:/cygwin/opt/tiano/i386-tiano-pe/i386-tiano-pe/bin/
> DEFINE CYGWIN_BINX64 = c:/cygwin/opt/tiano/x86_64-pc-mingw64/x86_64-pc-mingw64/bin/
> @@ -288,13 +265,6 @@ DEFINE DTC_BIN = ENV(DTC_PREFIX)dtc
> # Note:
> # Building of XIP firmware images for ARM/ARM64 is not currently supported (only applications).
> # /FILEALIGN:4096 and other changes are needed for ARM firmware builds.
> -# UNIXGCC -UNIX- Requires:
> -# GCC 4.3.0
> -# binutils 2.20.51.0.5
> -# Optional:
> -# Required to build platforms or ACPI tables:
> -# Intel(r) ACPI Compiler from
> -# https://acpica.org/downloads
> # GCC48 -Linux,Windows- Requires:
> # GCC 4.8 targeting x86_64-linux-gnu, aarch64-linux-gnu, or arm-linux-gnueabi
> # Optional:
> @@ -3159,72 +3129,6 @@ NOOPT_VS2017_AARCH64_DLINK_FLAGS = /NOLOGO /NODEFAULTLIB /IGNORE:4001 /OPT:REF
> *_VS2017_EBC_SLINK_FLAGS = /lib /NOLOGO /MACHINE:EBC
> *_VS2017_EBC_DLINK_FLAGS = "C:\Program Files (x86)\Intel\EBC\Lib\EbcLib.lib" /NOLOGO /NODEFAULTLIB /MACHINE:EBC /OPT:REF /ENTRY:$(IMAGE_ENTRY_POINT) /SUBSYSTEM:EFI_BOOT_SERVICE_DRIVER /MAP /ALIGN:32 /DRIVER
>
> -####################################################################################
> -#
> -# Unix GCC And Intel Linux ACPI Compiler
> -#
> -####################################################################################
> -# UNIXGCC - UNIX GCC
> -# ASL - Intel Linux ACPI Source Language Compiler (iasl)
> -*_UNIXGCC_*_*_FAMILY = GCC
> -*_UNIXGCC_*_*_BUILDRULEFAMILY = GCCLD
> -
> -*_UNIXGCC_*_MAKE_PATH = make
> -*_UNIXGCC_*_ASL_PATH = DEF(UNIX_IASL_BIN)
> -
> -*_UNIXGCC_IA32_DLINK_FLAGS = DEF(GCC_IA32_X64_DLINK_FLAGS) --image-base=0
> -*_UNIXGCC_X64_DLINK_FLAGS = DEF(GCC_IA32_X64_DLINK_FLAGS) --image-base=0
> -*_UNIXGCC_IA32_ASLDLINK_FLAGS = DEF(GCC_IA32_X64_ASLDLINK_FLAGS)
> -*_UNIXGCC_X64_ASLDLINK_FLAGS = DEF(GCC_IA32_X64_ASLDLINK_FLAGS)
> -*_UNIXGCC_*_ASM_FLAGS = DEF(GCC_ASM_FLAGS)
> -*_UNIXGCC_*_PP_FLAGS = DEF(GCC_PP_FLAGS)
> -*_UNIXGCC_*_ASLPP_FLAGS = DEF(GCC_ASLPP_FLAGS)
> -*_UNIXGCC_*_ASLCC_FLAGS = DEF(GCC_ASLCC_FLAGS)
> -*_UNIXGCC_*_VFRPP_FLAGS = DEF(GCC_VFRPP_FLAGS)
> -*_UNIXGCC_*_APP_FLAGS =
> -*_UNIXGCC_*_ASL_FLAGS = DEF(IASL_FLAGS)
> -*_UNIXGCC_*_ASL_OUTFLAGS = DEF(IASL_OUTFLAGS)
> -
> -##################
> -# IA32 definitions
> -##################
> -*_UNIXGCC_IA32_OBJCOPY_PATH = DEF(UNIXGCC_IA32_PETOOLS_PREFIX)objcopy
> -*_UNIXGCC_IA32_PP_PATH = DEF(UNIXGCC_IA32_PETOOLS_PREFIX)gcc
> -*_UNIXGCC_IA32_CC_PATH = DEF(UNIXGCC_IA32_PETOOLS_PREFIX)gcc
> -*_UNIXGCC_IA32_SLINK_PATH = DEF(UNIXGCC_IA32_PETOOLS_PREFIX)ar
> -*_UNIXGCC_IA32_DLINK_PATH = DEF(UNIXGCC_IA32_PETOOLS_PREFIX)ld
> -*_UNIXGCC_IA32_ASLPP_PATH = DEF(UNIXGCC_IA32_PETOOLS_PREFIX)gcc
> -*_UNIXGCC_IA32_ASLCC_PATH = DEF(UNIXGCC_IA32_PETOOLS_PREFIX)gcc
> -*_UNIXGCC_IA32_ASLDLINK_PATH = DEF(UNIXGCC_IA32_PETOOLS_PREFIX)ld
> -*_UNIXGCC_IA32_ASM_PATH = DEF(UNIXGCC_IA32_PETOOLS_PREFIX)gcc
> -*_UNIXGCC_IA32_VFRPP_PATH = DEF(UNIXGCC_IA32_PETOOLS_PREFIX)gcc
> -*_UNIXGCC_IA32_RC_PATH = DEF(UNIXGCC_IA32_PETOOLS_PREFIX)objcopy
> -
> -*_UNIXGCC_IA32_CC_FLAGS = DEF(GCC_IA32_CC_FLAGS)
> -*_UNIXGCC_IA32_RC_FLAGS = DEF(GCC_IA32_RC_FLAGS)
> -*_UNIXGCC_IA32_OBJCOPY_FLAGS =
> -*_UNIXGCC_IA32_NASM_FLAGS = -f win32
> -
> -##################
> -# X64 definitions
> -##################
> -*_UNIXGCC_X64_CC_PATH = DEF(UNIXGCC_X64_PETOOLS_PREFIX)gcc
> -*_UNIXGCC_X64_ASLCC_PATH = DEF(UNIXGCC_X64_PETOOLS_PREFIX)gcc
> -*_UNIXGCC_X64_SLINK_PATH = DEF(UNIXGCC_X64_PETOOLS_PREFIX)ar
> -*_UNIXGCC_X64_DLINK_PATH = DEF(UNIXGCC_X64_PETOOLS_PREFIX)ld
> -*_UNIXGCC_X64_ASLDLINK_PATH = DEF(UNIXGCC_X64_PETOOLS_PREFIX)ld
> -*_UNIXGCC_X64_ASM_PATH = DEF(UNIXGCC_X64_PETOOLS_PREFIX)gcc
> -*_UNIXGCC_X64_PP_PATH = DEF(UNIXGCC_X64_PETOOLS_PREFIX)gcc
> -*_UNIXGCC_X64_ASLPP_PATH = DEF(UNIXGCC_X64_PETOOLS_PREFIX)gcc
> -*_UNIXGCC_X64_VFRPP_PATH = DEF(UNIXGCC_X64_PETOOLS_PREFIX)gcc
> -*_UNIXGCC_X64_RC_PATH = DEF(UNIXGCC_X64_PETOOLS_PREFIX)objcopy
> -*_UNIXGCC_X64_OBJCOPY_PATH = DEF(UNIXGCC_X64_PETOOLS_PREFIX)objcopy
> -
> -*_UNIXGCC_X64_CC_FLAGS = DEF(GCC_X64_CC_FLAGS)
> -*_UNIXGCC_X64_RC_FLAGS = DEF(GCC_X64_RC_FLAGS)
> -*_UNIXGCC_X64_OBJCOPY_FLAGS =
> -*_UNIXGCC_X64_NASM_FLAGS = -f win64
> -
> ####################################################################################
> #
> # GCC 4.8 - This configuration is used to compile under Linux to produce
>
Reviewed-by: Laszlo Ersek <lersek@redhat.com>
next prev parent reply other threads:[~2019-02-01 8:52 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-01 5:34 [PATCH 00/10] Remove unused tool chain configuration Shenglei Zhang
2019-02-01 5:34 ` [PATCH 01/10] BaseTools/tools_def.template: Remove VS2003 and VS2005 Shenglei Zhang
2019-02-01 5:34 ` [PATCH 02/10] OptionRomPkg/ReadMe.txt: Remove VS2005 Shenglei Zhang
2019-02-01 5:34 ` [PATCH 03/10] BaseTools/tools_def.template: Remove DDK3790 Shenglei Zhang
2019-02-01 5:34 ` [PATCH 04/10] BaseTools/tools_def.template: Remove UNIXGCC Shenglei Zhang
2019-02-01 8:52 ` Laszlo Ersek [this message]
2019-02-01 5:34 ` [PATCH 05/10] OvmfPkg: Remove UNIXGCC in DSC files Shenglei Zhang
2019-02-01 8:53 ` Laszlo Ersek
2019-02-01 5:34 ` [PATCH 06/10] OvmfPkg/README: Remove UNIXGCC Shenglei Zhang
2019-02-01 8:55 ` Laszlo Ersek
2019-02-01 9:50 ` Philippe Mathieu-Daudé
2019-02-01 13:47 ` Laszlo Ersek
2019-02-01 5:34 ` [PATCH 07/10] BaseTools: Update MYTOOLS Shenglei Zhang
2019-02-01 5:34 ` [PATCH 08/10] BaseTools/tools_def.template: Remove ELFGCC Shenglei Zhang
2019-02-01 8:56 ` Laszlo Ersek
2019-02-01 5:34 ` [PATCH 09/10] BaseTools/tools_def.template: Remove CYGGCC Shenglei Zhang
2019-02-01 8:58 ` Laszlo Ersek
2019-02-01 5:34 ` [PATCH 10/10] OptionRomPkg/ReadMe.txt: " Shenglei Zhang
2019-02-01 10:25 ` [PATCH 00/10] Remove unused tool chain configuration Ard Biesheuvel
2019-02-01 13:23 ` Gao, Liming
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b5e0071a-65b6-b022-a3e6-2c6fe4a52b38@redhat.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox