Re: [PATCH 00/14] Introduce PlatformInitLib in OvmfPkg

["Boeuf, Sebastien" <sebastien.boeuf@intel.com>]

The series looks good to me, and I've tested your branch by building
CLOUDHV.fd and running it with Cloud Hypervisor, nothing's broken :)

Acked-by: Sebastien Boeuf <sebastien.boeuf@intel.com>

On Tue, 2022-03-08 at 10:36 +0800, Min Xu wrote:
> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3863
> 
> There are 3 variants of PlatformPei in OvmfPkg:
>  - OvmfPkg/PlatformPei
>  - OvmfPkg/Bhyve/PlatformPei
>  - OvmfPkg/XenPlatformPei
> 
> A lot of common code can be shared in above PlatformPeis. Further more,
> with the upstreaming of TDVF (Pei-less boot mode), a library which
> wraps the common functions is needed. PlatformInitLib is designed
> to meet this requirement.
> 
> PlatformInitLib is designed to run in both PEI and SEC. So global
> variables and dynamic PCDs are avoided.
> 
> As the first stage, OvmfPkg/PlatformPei will be refactored with
> PlatformInitLib. In the future we will refactor other PlatformPeis
> with this lib as well.
> 
> Patch 1 - 2: 
> Create initial version of PlatformInitLib and move Cmos / Hob functions
> to the lib.
> 
> Patch 3:
> Move global variables in PlatformPei to PlatformInfoHob. Changes are
> all in OvmfPkg/PlatformPei.
> 
> Patch 4 - 12:
> These patches restruct the functions which set PCDs into two, one for
> PlatformInitLib, one for PlatformPei.
> 
> Patch 13 - 14:
> Pure move from PlatformPei to PlatformInitLib.
> 
> Code at: https://github.com/mxu9/edk2/tree/platform-init-lib-v1
> 
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Brijesh Singh <brijesh.singh@amd.com>
> Cc: Erdem Aktas <erdemaktas@google.com>
> Cc: James Bottomley <jejb@linux.ibm.com>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Tom Lendacky <thomas.lendacky@amd.com>
> Cc: Gerd Hoffmann <kraxel@redhat.com>
> Cc: Sebastien Boeuf <sebastien.boeuf@intel.com>
> Signed-off-by: Min Xu <min.m.xu@intel.com>
> 
> Min Xu (14):
>   OvmfPkg: Create initial version of PlatformInitLib
>   OvmfPkg/PlatformInitLib: Add hob functions
>   OvmfPkg/PlatformPei: Move global variables to PlatformInfoHob
>   OvmfPkg/PlatformPei: Refactor MiscInitialization
>   OvmfPkg/PlatformPei: Refactor MiscInitialization for CloudHV
>   OvmfPkg/PlatformPei: Refactor AddressWidthInitialization
>   OvmfPkg/PlatformPei: Refactor MaxCpuCountInitialization
>   OvmfPkg/PlatformPei: Refactor QemuUc32BaseInitialization
>   OvmfPkg/PlatformPei: Refactor InitializeRamRegions
>   OvmfPkg/PlatformPei: Refactor MemMapInitialization
>   OvmfPkg/PlatformPei: Refactor NoexecDxeInitialization
>   OvmfPkg/PlatformPei: Refactor MiscInitialization
>   OvmfPkg/PlatformInitLib: Create MemDetect.c
>   OvmfPkg/PlatformInitLib: Move functions to Platform.c
> 
>  OvmfPkg/AmdSev/AmdSevX64.dsc                  |   1 +
>  OvmfPkg/CloudHv/CloudHvX64.dsc                |   1 +
>  OvmfPkg/Include/Library/PlatformInitLib.h     | 206 +++++
>  .../PlatformInitLib}/Cmos.c                   |  32 +-
>  OvmfPkg/Library/PlatformInitLib/MemDetect.c   | 842 +++++++++++++++++
>  OvmfPkg/Library/PlatformInitLib/Platform.c    | 571 ++++++++++++
>  .../PlatformInitLib/PlatformInitLib.inf       |  87 ++
>  OvmfPkg/Microvm/MicrovmX64.dsc                |   1 +
>  OvmfPkg/OvmfPkg.dec                           |   4 +
>  OvmfPkg/OvmfPkgIa32.dsc                       |   1 +
>  OvmfPkg/OvmfPkgIa32X64.dsc                    |   1 +
>  OvmfPkg/OvmfPkgX64.dsc                        |   1 +
>  OvmfPkg/PlatformPei/AmdSev.c                  |  10 +-
>  OvmfPkg/PlatformPei/Cmos.h                    |  48 -
>  OvmfPkg/PlatformPei/Fv.c                      |   6 +-
>  OvmfPkg/PlatformPei/MemDetect.c               | 874 ++----------------
>  OvmfPkg/PlatformPei/MemTypeInfo.c             |   4 +-
>  OvmfPkg/PlatformPei/Platform.c                | 616 ++----------
>  OvmfPkg/PlatformPei/Platform.h                |  80 +-
>  OvmfPkg/PlatformPei/PlatformPei.inf           |   3 +-
>  20 files changed, 1912 insertions(+), 1477 deletions(-)
>  create mode 100644 OvmfPkg/Include/Library/PlatformInitLib.h
>  rename OvmfPkg/{PlatformPei => Library/PlatformInitLib}/Cmos.c (61%)
>  create mode 100644 OvmfPkg/Library/PlatformInitLib/MemDetect.c
>  create mode 100644 OvmfPkg/Library/PlatformInitLib/Platform.c
>  create mode 100644 OvmfPkg/Library/PlatformInitLib/PlatformInitLib.inf
>  delete mode 100644 OvmfPkg/PlatformPei/Cmos.h
> 

---------------------------------------------------------------------
Intel Corporation SAS (French simplified joint stock company)
Registered headquarters: "Les Montalets"- 2, rue de Paris, 
92196 Meudon Cedex, France
Registration Number:  302 456 199 R.C.S. NANTERRE
Capital: 4,572,000 Euros

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.