From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id EA01A941A69 for ; Fri, 3 May 2024 16:54:32 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=45soyFI66/IKHfjMCz3tVYu0nVKKhwF8nuEbtSvnlZI=; c=relaxed/simple; d=groups.io; h=DKIM-Filter:Message-ID:Date:MIME-Version:User-Agent:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20240206; t=1714755271; v=1; b=4nJw4ONpxwTGLMrT9tpgCPe7yY6cTAJd8f0F0SUIZWGzC3S9F6iWGJzV1v/HD4xVvzGN1GCX WoAYp5TIYcdfdxXiCff7WudDpWKGARUwgXJEoy/rX5dGEY3d8cifHkMqVV55n9zEJpYSuiBVxtu h7o9JMvn0kR10SqaGr+TI99kKI58WnWVW1CArWHEnTO/lDdCTtKI3XpTH/SFNW33PfY2ZkEX0xB FWIbWN28FVIRfjsfDjIpQazPQFDoVZ3iey90jRFQ8+9/lVBIfrkyp6k/EKo/tfkR3YhDD9I+8Fb P0j6hUYzpmmVQPflK05vCbcLMMpsInTcF4HXzu3o37LLA== X-Received: by 127.0.0.2 with SMTP id pOSyYY7687511xm7Ko8VWqmP; Fri, 03 May 2024 09:54:31 -0700 X-Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mx.groups.io with SMTP id smtpd.web11.18542.1714755265786655392 for ; Fri, 03 May 2024 09:54:25 -0700 X-Received: from [10.6.0.181] (unknown [20.39.63.9]) by linux.microsoft.com (Postfix) with ESMTPSA id E119120B2C82; Fri, 3 May 2024 09:54:24 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com E119120B2C82 Message-ID: Date: Fri, 3 May 2024 09:54:24 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] Proposal to switch TianoCore Code Review from email to GitHub Pull Requests on 5-24-2024 To: devel@edk2.groups.io, quic_llindhol@quicinc.com, michael.d.kinney@intel.com, "rfc@edk2.groups.io" Cc: "Andrew Fish (afish@apple.com)" References: <5116382f-a1cf-46fc-95a2-58c7f810765d@linux.microsoft.com> From: "Michael Kubacki" In-Reply-To: Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Fri, 03 May 2024 09:54:25 -0700 Resent-From: mikuback@linux.microsoft.com Reply-To: devel@edk2.groups.io,mikuback@linux.microsoft.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 1CeyCj8788ghd9M3VB1DGmIRx7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=4nJw4ONp; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=linux.microsoft.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io On 5/2/2024 6:57 AM, Leif Lindholm wrote: > On 2024-05-02 04:08, Michael Kubacki wrote: >> Thank you for this proposal. We've been anticipating this change for=20 >> years and are excited to help support it. >> >> Here's some items we'd like to raise for feedback that we could help=20 >> implement. Many could likely be done in time for the transition. >> >> 1. Automate reviewers - We've discussed CODEOWNERS in the past.=20 >> However, a simpler approach (in maintaining/syncing less files) would=20 >> be to use Maintainers.txt directly with a GitHub workflow since the=20 >> file already contains GitHub IDs. >=20 > That would be ideal. I know Mike worked on autogenerating CODEOWNERS=20 > from Maintainers.txt, but ultimately the latter supports more flexible=20 > use of wildcards (things like */AArch64/ currently requires reconciling= =20 > against the repo contents). >=20 >> 2. Make PR completion contingent on a GitHub review from at least one=20 >> package maintainer/reviewer for each package in the PR. >=20 > Yes. >=20 >> 3. Dependabot is already used today to automatically create PRs when=20 >> dependencies like pip modules have updates. To allow this to more=20 >> effectively keep dependencies up-to-date, allow dependabot PRs to be=20 >> completed (after normal acceptance criteria like CI and review=20 >> requirements) without a separate human creating a duplicate PR. >=20 > I am not sure what this means in practice :) > This doesn't sound like one we need to worry about before switchover=20 > though. It was a minor point to reduce extra work for keeping dependencies=20 up-to-date. It will naturally lead to a PR review in the new process=20 where we can discuss it further in the review. >=20 >> 4. Potentially warn users (with an automated comment on the PR) if=20 >> they add a push label to a PR that is less than 24 hours old. >=20 > That sounds good. > Is there any way to prevent force-pushes within 24h of previous push? > That would make setting up a transitional review-scraper less lossy. We can. There have been cases in the past where we need to critically=20 get a change in to unblock CI for example so I didn't want to complicate=20 that initially. This could serve as a reminder to those with push access=20 in the meantime if we'd like. >=20 >> 5. Leave reminder comments on PRs with absolutely no activity after=20 >> some agreed upon time so reviewers are notified to review the PR=20 >> without the submitter having to watch it and send notifications. >=20 > Yes. But should take priority below 1, 2, and 4. Unless you have a=20 > pre-cooked thing to drop in of course. Your priorities look good. >=20 >> 6. Leave reminder comments on PRs that meet all requirements to be=20 >> completed (all reviews accounted for and status checks pass) but are=20 >> still open so those on the PR are notified to complete it without the=20 >> submitter having to manually watch and send reminders. >=20 > Not a response to this, but triggered by reading this: > Is there any way to approve changes within a PR on a commit by commit=20 > basis? Unfortunately not. We typically resolve all conversations before giving=20 an approval that would apply to all relevant commits for the given reviewer= . >=20 >> 7. We are happy to help with process documentation. >=20 > Always appreciated,thanks. >=20 > Regards, >=20 > Leif >=20 >=20 >=20 >=20 >=20 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#118557): https://edk2.groups.io/g/devel/message/118557 Mute This Topic: https://groups.io/mt/105847510/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-