From: "Sami Mujawar" <sami.mujawar@arm.com>
To: Prabin CA <prabin.ca@arm.com>, devel@edk2.groups.io
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>,
Leif Lindholm <quic_llindhol@quicinc.com>,
Thomas Abraham <thomas.abraham@arm.com>,
"nd@arm.com" <nd@arm.com>
Subject: Re: [edk2-devel] [edk2-platforms][PATCH v5 3/9] Platform/Sgi: Refactor system memory base and size definitions
Date: Sun, 31 Mar 2024 13:01:50 +0100 [thread overview]
Message-ID: <b6392c1c-d49d-425f-9100-09f44342971d@arm.com> (raw)
In-Reply-To: <20240311131416.823580-4-prabin.ca@arm.com>
Hi Prabin,
Thank you for this patch.
These changes look good to me.
Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>
Regards,
Sami Mujawar
On 11/03/2024 01:14 pm, Prabin CA wrote:
> In preparation of adding the next generation of reference design
> platform that have different memory map, refactor the
> PcdSystemMemoryBase and PcdSystemMemorySize PCD definitions from the
> common PCD definitions file into the various platform generation
> specific memory map PCD definitions file.
>
> Signed-off-by: Prabin CA <prabin.ca@arm.com>
> ---
> Platform/ARM/SgiPkg/SgiMemoryMap.dsc.inc | 8 +++++++-
> Platform/ARM/SgiPkg/SgiMemoryMap2.dsc.inc | 8 +++++++-
> Platform/ARM/SgiPkg/SgiPlatform.dsc.inc | 6 +-----
> 3 files changed, 15 insertions(+), 7 deletions(-)
>
> diff --git a/Platform/ARM/SgiPkg/SgiMemoryMap.dsc.inc b/Platform/ARM/SgiPkg/SgiMemoryMap.dsc.inc
> index 0cffff577c42..eab43b23ec6d 100644
> --- a/Platform/ARM/SgiPkg/SgiMemoryMap.dsc.inc
> +++ b/Platform/ARM/SgiPkg/SgiMemoryMap.dsc.inc
> @@ -1,5 +1,5 @@
> #
> -# Copyright (c) 2020 - 2022, Arm Limited. All rights reserved.
> +# Copyright (c) 2020 - 2024, Arm Limited. All rights reserved.
> #
> # SPDX-License-Identifier: BSD-2-Clause-Patent
> #
> @@ -67,3 +67,9 @@ [PcdsFixedAtBuild.common]
> gArmSgiTokenSpaceGuid.PcdGpioController0BaseAddress|0x1C1D0000
> gArmSgiTokenSpaceGuid.PcdGpioController0Size|0x00010000
> gArmSgiTokenSpaceGuid.PcdGpioController0Interrupt|136
> +
> + # System Memory (1GB - 16MB of Trusted DRAM at the top of the
> + # 32bit address space)
> + gArmTokenSpaceGuid.PcdSystemMemoryBase|0x80000000
> + gArmTokenSpaceGuid.PcdSystemMemorySize|0x7F000000
> +
> diff --git a/Platform/ARM/SgiPkg/SgiMemoryMap2.dsc.inc b/Platform/ARM/SgiPkg/SgiMemoryMap2.dsc.inc
> index de1d8ea24b89..35e27d42d5a2 100644
> --- a/Platform/ARM/SgiPkg/SgiMemoryMap2.dsc.inc
> +++ b/Platform/ARM/SgiPkg/SgiMemoryMap2.dsc.inc
> @@ -1,5 +1,5 @@
> #
> -# Copyright (c) 2020 - 2023, Arm Limited. All rights reserved.
> +# Copyright (c) 2020 - 2024, Arm Limited. All rights reserved.
> #
> # SPDX-License-Identifier: BSD-2-Clause-Patent
> #
> @@ -75,3 +75,9 @@ [PcdsFixedAtBuild.common]
>
> # IO virtualization block
> gArmSgiTokenSpaceGuid.PcdIoVirtSocExpBlk0Base|0x1080000000
> +
> + # System Memory (1GB - 16MB of Trusted DRAM at the top of the
> + # 32bit address space)
> + gArmTokenSpaceGuid.PcdSystemMemoryBase|0x80000000
> + gArmTokenSpaceGuid.PcdSystemMemorySize|0x7F000000
> +
> diff --git a/Platform/ARM/SgiPkg/SgiPlatform.dsc.inc b/Platform/ARM/SgiPkg/SgiPlatform.dsc.inc
> index 26ecd9ed59a7..1cfe07c7e4ed 100644
> --- a/Platform/ARM/SgiPkg/SgiPlatform.dsc.inc
> +++ b/Platform/ARM/SgiPkg/SgiPlatform.dsc.inc
> @@ -1,5 +1,5 @@
> #
> -# Copyright (c) 2018 - 2022, ARM Limited. All rights reserved.
> +# Copyright (c) 2018 - 2024, Arm Limited. All rights reserved.
> # (C) Copyright 2021 Hewlett Packard Enterprise Development LP<BR>
> #
> # SPDX-License-Identifier: BSD-2-Clause-Patent
> @@ -131,10 +131,6 @@ [PcdsFixedAtBuild.common]
> gArmPlatformTokenSpaceGuid.PcdCPUCorePrimaryStackSize|0x40000
> gArmPlatformTokenSpaceGuid.PcdCPUCoreSecondaryStackSize|0x0
>
> - # System Memory (1GB - 16MB of Trusted DRAM at the top of the 32bit address space)
> - gArmTokenSpaceGuid.PcdSystemMemoryBase|0x80000000
> - gArmTokenSpaceGuid.PcdSystemMemorySize|0x7F000000
> -
> # ACPI Table Version
> gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiExposedTableVersions|0x20
>
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#117262): https://edk2.groups.io/g/devel/message/117262
Mute This Topic: https://groups.io/mt/104862628/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
next prev parent reply other threads:[~2024-03-31 12:02 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-11 13:14 [edk2-devel] [edk2-platforms][PATCH v5 0/9] Platform/Sgi: Add support for RD-Fremont platform Prabin CA
2024-03-11 13:14 ` [edk2-devel] [edk2-platforms][PATCH v5 1/9] Platform/Sgi: Correct typo in defining CPPC performance limited register Prabin CA
2024-03-11 14:29 ` levi.yun
2024-03-31 11:58 ` Sami Mujawar
2024-03-11 13:14 ` [edk2-devel] [edk2-platforms][PATCH v5 2/9] Platform/Sgi: Update the datatype of PcdSmmuBase from u32 to u64 Prabin CA
2024-03-11 14:29 ` levi.yun
2024-03-31 12:01 ` Sami Mujawar
2024-03-11 13:14 ` [edk2-devel] [edk2-platforms][PATCH v5 3/9] Platform/Sgi: Refactor system memory base and size definitions Prabin CA
2024-03-11 14:29 ` levi.yun
2024-03-31 12:01 ` Sami Mujawar [this message]
2024-03-11 13:14 ` [edk2-devel] [edk2-platforms][PATCH v5 4/9] Platform/Sgi: Introduce a flag to enable PCIe support for RD Platforms Prabin CA
2024-03-11 14:33 ` levi.yun
2024-03-31 10:31 ` Sami Mujawar
2024-03-31 11:57 ` Sami Mujawar
2024-03-11 13:14 ` [edk2-devel] [edk2-platforms][PATCH v5 5/9] Platform/Sgi: Add ACPI tables for RD-Fremont platform Prabin CA
2024-03-11 14:34 ` levi.yun
2024-03-31 12:02 ` Sami Mujawar
2024-03-11 13:14 ` [edk2-devel] [edk2-platforms][PATCH v5 6/9] Platform/Sgi: Add initial support " Prabin CA
2024-03-11 14:34 ` levi.yun
2024-03-31 12:03 ` Sami Mujawar
2024-03-11 13:14 ` [edk2-devel] [edk2-platforms][PATCH v5 7/9] Platform/Sgi: Extend SMBIOS support for RD-Fremont Prabin CA
2024-03-11 14:35 ` levi.yun
2024-03-31 11:55 ` Sami Mujawar
2024-03-11 13:14 ` [edk2-devel] [edk2-platforms][PATCH v5 8/9] Platform/Sgi: Low Power Idle States " Prabin CA
2024-03-11 14:35 ` levi.yun
2024-03-31 12:03 ` Sami Mujawar
2024-03-11 13:14 ` [edk2-devel] [edk2-platforms][PATCH v5 9/9] Platform/Sgi: Add CPPC support for RD-Fremont platform Prabin CA
2024-03-11 14:35 ` levi.yun
2024-03-31 12:03 ` Sami Mujawar
2024-03-31 12:06 ` [edk2-devel] [edk2-platforms][PATCH v5 0/9] Platform/Sgi: Add " Sami Mujawar
2024-04-03 17:40 ` Prabin CA
2024-03-31 12:09 ` Sami Mujawar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b6392c1c-d49d-425f-9100-09f44342971d@arm.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox