Re: [edk2-devel] [edk2-platforms][PATCH v5 3/9] Platform/Sgi: Refactor system memory base and size definitions

["Sami Mujawar" <sami.mujawar@arm.com>]

Hi Prabin,

Thank you for this patch.

These changes look good to me.

Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>

Regards,

Sami Mujawar

On 11/03/2024 01:14 pm, Prabin CA wrote:
> In preparation of adding the next generation of reference design
> platform that have different memory map, refactor the
> PcdSystemMemoryBase and PcdSystemMemorySize PCD definitions from the
> common PCD definitions file into the various platform generation
> specific memory map PCD definitions file.
>
> Signed-off-by: Prabin CA <prabin.ca@arm.com>
> ---
>   Platform/ARM/SgiPkg/SgiMemoryMap.dsc.inc  | 8 +++++++-
>   Platform/ARM/SgiPkg/SgiMemoryMap2.dsc.inc | 8 +++++++-
>   Platform/ARM/SgiPkg/SgiPlatform.dsc.inc   | 6 +-----
>   3 files changed, 15 insertions(+), 7 deletions(-)
>
> diff --git a/Platform/ARM/SgiPkg/SgiMemoryMap.dsc.inc b/Platform/ARM/SgiPkg/SgiMemoryMap.dsc.inc
> index 0cffff577c42..eab43b23ec6d 100644
> --- a/Platform/ARM/SgiPkg/SgiMemoryMap.dsc.inc
> +++ b/Platform/ARM/SgiPkg/SgiMemoryMap.dsc.inc
> @@ -1,5 +1,5 @@
>   #
> -#  Copyright (c) 2020 - 2022, Arm Limited. All rights reserved.
> +#  Copyright (c) 2020 - 2024, Arm Limited. All rights reserved.
>   #
>   #  SPDX-License-Identifier: BSD-2-Clause-Patent
>   #
> @@ -67,3 +67,9 @@ [PcdsFixedAtBuild.common]
>     gArmSgiTokenSpaceGuid.PcdGpioController0BaseAddress|0x1C1D0000
>     gArmSgiTokenSpaceGuid.PcdGpioController0Size|0x00010000
>     gArmSgiTokenSpaceGuid.PcdGpioController0Interrupt|136
> +
> +  # System Memory (1GB - 16MB of Trusted DRAM at the top of the
> +  # 32bit address space)
> +  gArmTokenSpaceGuid.PcdSystemMemoryBase|0x80000000
> +  gArmTokenSpaceGuid.PcdSystemMemorySize|0x7F000000
> +
> diff --git a/Platform/ARM/SgiPkg/SgiMemoryMap2.dsc.inc b/Platform/ARM/SgiPkg/SgiMemoryMap2.dsc.inc
> index de1d8ea24b89..35e27d42d5a2 100644
> --- a/Platform/ARM/SgiPkg/SgiMemoryMap2.dsc.inc
> +++ b/Platform/ARM/SgiPkg/SgiMemoryMap2.dsc.inc
> @@ -1,5 +1,5 @@
>   #
> -#  Copyright (c) 2020 - 2023, Arm Limited. All rights reserved.
> +#  Copyright (c) 2020 - 2024, Arm Limited. All rights reserved.
>   #
>   #  SPDX-License-Identifier: BSD-2-Clause-Patent
>   #
> @@ -75,3 +75,9 @@ [PcdsFixedAtBuild.common]
>   
>     # IO virtualization block
>     gArmSgiTokenSpaceGuid.PcdIoVirtSocExpBlk0Base|0x1080000000
> +
> +  # System Memory (1GB - 16MB of Trusted DRAM at the top of the
> +  # 32bit address space)
> +  gArmTokenSpaceGuid.PcdSystemMemoryBase|0x80000000
> +  gArmTokenSpaceGuid.PcdSystemMemorySize|0x7F000000
> +
> diff --git a/Platform/ARM/SgiPkg/SgiPlatform.dsc.inc b/Platform/ARM/SgiPkg/SgiPlatform.dsc.inc
> index 26ecd9ed59a7..1cfe07c7e4ed 100644
> --- a/Platform/ARM/SgiPkg/SgiPlatform.dsc.inc
> +++ b/Platform/ARM/SgiPkg/SgiPlatform.dsc.inc
> @@ -1,5 +1,5 @@
>   #
> -#  Copyright (c) 2018 - 2022, ARM Limited. All rights reserved.
> +#  Copyright (c) 2018 - 2024, Arm Limited. All rights reserved.
>   #  (C) Copyright 2021 Hewlett Packard Enterprise Development LP<BR>
>   #
>   #  SPDX-License-Identifier: BSD-2-Clause-Patent
> @@ -131,10 +131,6 @@ [PcdsFixedAtBuild.common]
>     gArmPlatformTokenSpaceGuid.PcdCPUCorePrimaryStackSize|0x40000
>     gArmPlatformTokenSpaceGuid.PcdCPUCoreSecondaryStackSize|0x0
>   
> -  # System Memory (1GB - 16MB of Trusted DRAM at the top of the 32bit address space)
> -  gArmTokenSpaceGuid.PcdSystemMemoryBase|0x80000000
> -  gArmTokenSpaceGuid.PcdSystemMemorySize|0x7F000000
> -
>     # ACPI Table Version
>     gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiExposedTableVersions|0x20
>   


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#117262): https://edk2.groups.io/g/devel/message/117262
Mute This Topic: https://groups.io/mt/104862628/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-