From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 977E27803CC for ; Sun, 31 Mar 2024 12:02:13 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=Pq20m6hNRuWkz62U06CMq+DMWybBayVeq4IOceKWJdw=; c=relaxed/simple; d=groups.io; h=Received-SPF:Message-ID:Date:User-Agent:Subject:To:Cc:References:From:In-Reply-To:MIME-Version:NoDisclaimer:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20240206; t=1711886532; v=1; b=VaQ3SjYHJyrXij38nsi23IXfxDrYNogBVMWzkj2I7G1FqnYlqix2j1oFQnOvXjP7nQdL7fQL fmCVeY6WFjzPef/+o7oLPAR6z0oIASgZ6k4dYo1MQufKQ9nU4HWm4acs7UmeIR7b3pZRrm5WYfw F9ZY9XqxOAzEri1DzXNyUE/hp5qqXzK+GRHkx8AUddPPYkLmGjBTBhsLRcffOLShEP+aMEDJd8C U7KicO1J5aN505GeAYHR78RoLjlv8FWTwvCHFsXhf+gEYH4w3A9D+UMEwGkot/gFrcG/Kd/Xgjl LUmO2mOedmqVRLoak9zTu1B6WD1sTKu7nmBAh0gS4oN0Q== X-Received: by 127.0.0.2 with SMTP id 8R90YY7687511xi1gIQ9YJzX; Sun, 31 Mar 2024 05:02:12 -0700 X-Received: from EUR05-DB8-obe.outbound.protection.outlook.com (EUR05-DB8-obe.outbound.protection.outlook.com [40.107.20.48]) by mx.groups.io with SMTP id smtpd.web11.15680.1711886531587233133 for ; Sun, 31 Mar 2024 05:02:11 -0700 X-Received: from AM6P192CA0018.EURP192.PROD.OUTLOOK.COM (2603:10a6:209:83::31) by AS2PR08MB8718.eurprd08.prod.outlook.com (2603:10a6:20b:55e::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.45; Sun, 31 Mar 2024 12:02:05 +0000 X-Received: from AM4PEPF00027A6C.eurprd04.prod.outlook.com (2603:10a6:209:83:cafe::b) by AM6P192CA0018.outlook.office365.com (2603:10a6:209:83::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.46 via Frontend Transport; Sun, 31 Mar 2024 12:02:05 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM4PEPF00027A6C.mail.protection.outlook.com (10.167.16.90) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.7409.10 via Frontend Transport; Sun, 31 Mar 2024 12:02:05 +0000 X-Received: ("Tessian outbound 9b7417e2a8eb:v300"); Sun, 31 Mar 2024 12:02:05 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 26145bd2a02489a3 X-CR-MTA-TID: 64aa7808 X-Received: from 13761b492fed.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 0B06E7D6-ECE3-404F-892A-8B0D6F1BF7F5.1; Sun, 31 Mar 2024 12:01:54 +0000 X-Received: from EUR04-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 13761b492fed.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Sun, 31 Mar 2024 12:01:54 +0000 X-Received: from AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) by GVXPR08MB10430.eurprd08.prod.outlook.com (2603:10a6:150:14e::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.42; Sun, 31 Mar 2024 12:01:52 +0000 X-Received: from AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::1e13:dc65:224e:219c]) by AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::1e13:dc65:224e:219c%5]) with mapi id 15.20.7409.042; Sun, 31 Mar 2024 12:01:52 +0000 Message-ID: Date: Sun, 31 Mar 2024 13:01:50 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] [edk2-platforms][PATCH v5 3/9] Platform/Sgi: Refactor system memory base and size definitions To: Prabin CA , devel@edk2.groups.io Cc: Ard Biesheuvel , Leif Lindholm , Thomas Abraham , "nd@arm.com" References: <20240311131416.823580-1-prabin.ca@arm.com> <20240311131416.823580-4-prabin.ca@arm.com> From: "Sami Mujawar" In-Reply-To: <20240311131416.823580-4-prabin.ca@arm.com> X-ClientProxiedBy: LO4P123CA0335.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:18c::16) To AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: AS8PR08MB6806:EE_|GVXPR08MB10430:EE_|AM4PEPF00027A6C:EE_|AS2PR08MB8718:EE_ x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: NRj3Uk1GEaGoGLXjRporjvNz+nbF+0Vy8d6NosACr3CHCh9ugCQGG87EzqHMoU0iQNhW2pGSXBkA61Vj9OFeOpa34uRjqsjyvWrVy3BUh9JhVq/qVn0LrJwIkrmhBn9gxKfaAKq00zQ70iwatFtDWY976Agn8TiYsf1nqKVA3GkpEhftd0fMMkGNJfYQD7TpX8o0i2EcyKY8AIMKjBIpbJP+I/9OCVn2pNQi731zyyTFdGcPAoG2CqHC0bQn3iTDhmqcJ0MqE1KvECU3qiHjcgKN9Jom6MIzup1dBZbprMy+Rq06YtHZvbvfm3x06rHnO2oRsYh5/TPe7fAeOfp79ShfYHI0ksOMbXOLWyMRO5Eo4eXLilALfzjoTGeGYAXv3S6qPWP9V3SR38moD6mEWlBWcsPGXiwBLtL+dOkADZRfj5KojukrFM8KMJ9iks/rcIKobOuvcjT7imjBiZ9OvPp1NvLwaIXxaL3cejB1i+eC0t5Ox2Um8fcAuBKH+FzoI80TLn8Ie+nU4kwvwxXxtWKZPU0PuZeTuAJlNX39YEWVgQRX64EpdUavPoPbpM3vYpneGVrKCaXN/VaTIDeYHkIAuSqG8J4wVTLql9bYCObaPKeb08vKx7VKnIbtLAdSxfTIF34KDLwe3Qg/Kzwz0ql83oaMAqi/5XXxLMe4xX4= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB6806.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(366007)(376005)(1800799015);DIR:OUT;SFP:1102; X-MS-Exchange-Transport-CrossTenantHeadersStamped: GVXPR08MB10430 X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM4PEPF00027A6C.eurprd04.prod.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 79807795-a433-429d-765c-08dc517a6229 X-Microsoft-Antispam-Message-Info: 8B1idYF4hqQ1VSpORURwGw7jvxadCoFppZLaUHSgL2Hmh+PmEmVYDdVjIEBRN1RxTS93YbSRHHVTx9/sLjZBoHqLM4YdiuYoXJsPeENN0SJxxus9VkRHW6CQLCyt4I3iQhwYtkbla/V7Df4AWTNHfWIiDVCzF7mNAekFW6UINy2VPwuNgadS3hx5+7hO9QU8TBCk8JCo3i5PGKmpMpm2HFDWQHUf0Cvsauu7pjzm+ytbyNyKbyu5fUBFJ7XURqitXuZj7ERiTgWxz/YYmY5keV4xA/aLp93hKmkJohg2dnLa44YRClzmrLB/i4dKC5lSgRywnRuPKYDGt9wFmIo4Y5MugPGQap5mB7B5hM+CKpOZ2HBVDztRvXX5uAz9imc0UGylB8n6hK+IX7Psm+J8v5fEI9FI9M9gCXdUZCNRZ7R9FURANqE2jW+4IWEu5YKYdUyMv+fuqGC+i4LkFP8JD/c9HQNRXNBd8xEB8jPTee++y+IjX6PqP0oMkhg9zdRgOtMJgvmAMWiiTsXS7TkFgAr09MYgyLyEntG4YgcuNDdpqnBzL1pDnBRjU91BGdQyGyvG6FZUd1cUSaww0VhA9NsFuYJAv+62YdRyvgIv0YWjSlFBykFlHW7zl8BYXLdkfhQ9G4tltFpSCiE4JvzXK7uG7pv46pecnGhYSbwjKe5GbaRlXy6ANbfRbeIWyC5s7cEfmqeJg4gYUCEtOB73nCl9IMf2HMnbJDirEa99OLSJzn56AqbHWNPDh6rL/YuE X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Mar 2024 12:02:05.3887 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 79807795-a433-429d-765c-08dc517a6229 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM4PEPF00027A6C.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS2PR08MB8718 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Sun, 31 Mar 2024 05:02:11 -0700 Reply-To: devel@edk2.groups.io,sami.mujawar@arm.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: tkTrHslFLpREmgm0TlmQ3aQyx7686176AA= Content-Language: en-GB Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=VaQ3SjYH; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=arm.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Hi Prabin, Thank you for this patch. These changes look good to me. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 11/03/2024 01:14 pm, Prabin CA wrote: > In preparation of adding the next generation of reference design > platform that have different memory map, refactor the > PcdSystemMemoryBase and PcdSystemMemorySize PCD definitions from the > common PCD definitions file into the various platform generation > specific memory map PCD definitions file. > > Signed-off-by: Prabin CA > --- > Platform/ARM/SgiPkg/SgiMemoryMap.dsc.inc | 8 +++++++- > Platform/ARM/SgiPkg/SgiMemoryMap2.dsc.inc | 8 +++++++- > Platform/ARM/SgiPkg/SgiPlatform.dsc.inc | 6 +----- > 3 files changed, 15 insertions(+), 7 deletions(-) > > diff --git a/Platform/ARM/SgiPkg/SgiMemoryMap.dsc.inc b/Platform/ARM/SgiP= kg/SgiMemoryMap.dsc.inc > index 0cffff577c42..eab43b23ec6d 100644 > --- a/Platform/ARM/SgiPkg/SgiMemoryMap.dsc.inc > +++ b/Platform/ARM/SgiPkg/SgiMemoryMap.dsc.inc > @@ -1,5 +1,5 @@ > # > -# Copyright (c) 2020 - 2022, Arm Limited. All rights reserved. > +# Copyright (c) 2020 - 2024, Arm Limited. All rights reserved. > # > # SPDX-License-Identifier: BSD-2-Clause-Patent > # > @@ -67,3 +67,9 @@ [PcdsFixedAtBuild.common] > gArmSgiTokenSpaceGuid.PcdGpioController0BaseAddress|0x1C1D0000 > gArmSgiTokenSpaceGuid.PcdGpioController0Size|0x00010000 > gArmSgiTokenSpaceGuid.PcdGpioController0Interrupt|136 > + > + # System Memory (1GB - 16MB of Trusted DRAM at the top of the > + # 32bit address space) > + gArmTokenSpaceGuid.PcdSystemMemoryBase|0x80000000 > + gArmTokenSpaceGuid.PcdSystemMemorySize|0x7F000000 > + > diff --git a/Platform/ARM/SgiPkg/SgiMemoryMap2.dsc.inc b/Platform/ARM/Sgi= Pkg/SgiMemoryMap2.dsc.inc > index de1d8ea24b89..35e27d42d5a2 100644 > --- a/Platform/ARM/SgiPkg/SgiMemoryMap2.dsc.inc > +++ b/Platform/ARM/SgiPkg/SgiMemoryMap2.dsc.inc > @@ -1,5 +1,5 @@ > # > -# Copyright (c) 2020 - 2023, Arm Limited. All rights reserved. > +# Copyright (c) 2020 - 2024, Arm Limited. All rights reserved. > # > # SPDX-License-Identifier: BSD-2-Clause-Patent > # > @@ -75,3 +75,9 @@ [PcdsFixedAtBuild.common] > =20 > # IO virtualization block > gArmSgiTokenSpaceGuid.PcdIoVirtSocExpBlk0Base|0x1080000000 > + > + # System Memory (1GB - 16MB of Trusted DRAM at the top of the > + # 32bit address space) > + gArmTokenSpaceGuid.PcdSystemMemoryBase|0x80000000 > + gArmTokenSpaceGuid.PcdSystemMemorySize|0x7F000000 > + > diff --git a/Platform/ARM/SgiPkg/SgiPlatform.dsc.inc b/Platform/ARM/SgiPk= g/SgiPlatform.dsc.inc > index 26ecd9ed59a7..1cfe07c7e4ed 100644 > --- a/Platform/ARM/SgiPkg/SgiPlatform.dsc.inc > +++ b/Platform/ARM/SgiPkg/SgiPlatform.dsc.inc > @@ -1,5 +1,5 @@ > # > -# Copyright (c) 2018 - 2022, ARM Limited. All rights reserved. > +# Copyright (c) 2018 - 2024, Arm Limited. All rights reserved. > # (C) Copyright 2021 Hewlett Packard Enterprise Development LP
> # > # SPDX-License-Identifier: BSD-2-Clause-Patent > @@ -131,10 +131,6 @@ [PcdsFixedAtBuild.common] > gArmPlatformTokenSpaceGuid.PcdCPUCorePrimaryStackSize|0x40000 > gArmPlatformTokenSpaceGuid.PcdCPUCoreSecondaryStackSize|0x0 > =20 > - # System Memory (1GB - 16MB of Trusted DRAM at the top of the 32bit ad= dress space) > - gArmTokenSpaceGuid.PcdSystemMemoryBase|0x80000000 > - gArmTokenSpaceGuid.PcdSystemMemorySize|0x7F000000 > - > # ACPI Table Version > gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiExposedTableVersions|0x20 > =20 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#117262): https://edk2.groups.io/g/devel/message/117262 Mute This Topic: https://groups.io/mt/104862628/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-