From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from aserp2130.oracle.com (aserp2130.oracle.com [141.146.126.79]) by mx.groups.io with SMTP id smtpd.web08.486.1611701592705892909 for ; Tue, 26 Jan 2021 14:53:12 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@oracle.com header.s=corp-2020-01-29 header.b=POx3RWde; spf=pass (domain: oracle.com, ip: 141.146.126.79, mailfrom: ankur.a.arora@oracle.com) Received: from pps.filterd (aserp2130.oracle.com [127.0.0.1]) by aserp2130.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 10QMZ98X184218; Tue, 26 Jan 2021 22:53:09 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=subject : to : cc : references : from : message-id : date : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2020-01-29; bh=lG+JpxyDqDzgsM5lA7wnfIfDXd0Yzw/kVV1zVjiVGDU=; b=POx3RWdeBttwJgi7yDlPV6dCdX7tHVa7LJPW8e+bnQKgwmUnCEhoay0RB4ApG9MWiA1x 6ebcl+hdiVFA9oEOYrwpu7iePQel9mjC6ztu1iliws/GGrzMkT36uxsVdlOflwZc6Dk6 4dLnGt1+myN7Y1O7XQE7mY9D3CucKnRmg07vM6SPD8RU4LrFuTq2EfNKOymECr7c//FT spX+MKjYLqL+mrRBvv1b0I6OF9EQAXs/SnG3JPNbGXs5f/xrR+cna4ZkwXj27mrMxqZN D7QAfAVAzuffF/+uXqmyWiTOmBPRylciTwxcPZFkhZrP4aV5Rpg/JkkkKJ021mFA3a0i mg== Received: from userp3020.oracle.com (userp3020.oracle.com [156.151.31.79]) by aserp2130.oracle.com with ESMTP id 3689aamkty-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 26 Jan 2021 22:53:08 +0000 Received: from pps.filterd (userp3020.oracle.com [127.0.0.1]) by userp3020.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 10QMZcUO149604; Tue, 26 Jan 2021 22:53:08 GMT Received: from nam02-sn1-obe.outbound.protection.outlook.com (mail-sn1nam02lp2051.outbound.protection.outlook.com [104.47.36.51]) by userp3020.oracle.com with ESMTP id 368wjrsb01-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 26 Jan 2021 22:53:07 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EXCrg14o3LOXGXSJWKDG2BbJCGjvyr9fiKh4KtJ47074OeCG3DHRlTCfcTznoQV1KzXQn4VcJYtPPeDPY0fYlE8G3eIWFAe8NpfjmaOWxHv8rwBct2/a+Ka9kjJ6WUw/q9z061xM2gi5ke89rMWzT3x1qWm5+3+KaJKYOVvLsdmygak1IVF9lqEp2EKYmAWvDgSKLrIK6N54hMWenJImY7RIHEGbFx36uHXHvqI2QP9ux+LoBaNFs+KTdePpoLLQ3dtp/mVWLCh5NHy2YLVXC7jok46vYkzjx4OYbb4+cJo7HLKUYKt5S2WVGfkGJmkceGAD3bAllSCina61hcCZEA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lG+JpxyDqDzgsM5lA7wnfIfDXd0Yzw/kVV1zVjiVGDU=; b=Oxvb0LZT5/tQy2vLMQCvC1mVX4xN2Vr9k56NEgsg8LhXLnKpH09MFqSvNguNhDzGxX6ztBrnUgw/SkA8EP2PBvB5VsO2iMsmcpwK5zsNh3ve6Bv/A42ev0hUHwlbScJs8bnlJ2D66JxToYjfQ/XJSVu8y+J8JxwW+CIz/0pvNMF+f0QHmNyb9KpKmLTjDrr3C7/XEhdY2fE+4Pl2OdxtGPAgIqxdPN6F4T7eHovZHTKuTgLMBqGQJlLWrJ/vCq+f7OJBIJkyMCHDV/pNRagXIerjSdDJoAuD06Uni0I8BQv3HcgEUoZ7kApeXqYvRSjlNb0lIc4LovDgbx2SciHQ0w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lG+JpxyDqDzgsM5lA7wnfIfDXd0Yzw/kVV1zVjiVGDU=; b=m4zTo7iJu9nQOXUEuR+jhlsLQD/DfHHqhav8oIF0CBGDH3FaDJLYFDVybtyN+/xVO8RfuMJBDmRAx+LDS+XCEA7StMdgOlicKkDYAq87fvilbODD4MWxkJMjFrfjjZs+EVrKkSEeNomiYcL9WncidJEL/X3SATj7QRW1jyFq4CE= Received: from CY4PR10MB1718.namprd10.prod.outlook.com (2603:10b6:910:9::17) by CY4PR10MB2038.namprd10.prod.outlook.com (2603:10b6:903:122::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3784.11; Tue, 26 Jan 2021 22:53:06 +0000 Received: from CY4PR10MB1718.namprd10.prod.outlook.com ([fe80::39dc:6ba7:9397:cb6]) by CY4PR10MB1718.namprd10.prod.outlook.com ([fe80::39dc:6ba7:9397:cb6%6]) with mapi id 15.20.3784.019; Tue, 26 Jan 2021 22:53:06 +0000 Subject: Re: [PATCH v5 1/9] OvmfPkg/CpuHotplugSmm: refactor hotplug logic To: Laszlo Ersek , devel@edk2.groups.io Cc: imammedo@redhat.com, boris.ostrovsky@oracle.com, Jordan Justen , Ard Biesheuvel , Aaron Young References: <20210126064440.299596-1-ankur.a.arora@oracle.com> <20210126064440.299596-2-ankur.a.arora@oracle.com> <3f3fd01d-78a9-315c-85e3-b5788b8d6489@redhat.com> <4a1e8dd7-51e4-165c-64c1-d7d6fea6eafc@oracle.com> <53e8f8dc-99ef-9b13-c92f-e3d63ab39409@redhat.com> <02cc6e35-1bc0-9f92-54f8-b26ecaa597c9@oracle.com> <0bcaba31-2e44-f228-1ab6-396194c3b77f@redhat.com> From: "Ankur Arora" Message-ID: Date: Tue, 26 Jan 2021 14:53:03 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 In-Reply-To: <0bcaba31-2e44-f228-1ab6-396194c3b77f@redhat.com> X-Originating-IP: [70.36.60.91] X-ClientProxiedBy: MW4PR03CA0365.namprd03.prod.outlook.com (2603:10b6:303:114::10) To CY4PR10MB1718.namprd10.prod.outlook.com (2603:10b6:910:9::17) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [192.168.0.108] (70.36.60.91) by MW4PR03CA0365.namprd03.prod.outlook.com (2603:10b6:303:114::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3784.12 via Frontend Transport; Tue, 26 Jan 2021 22:53:05 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 14113f51-dd27-4686-8f58-08d8c24d24a2 X-MS-TrafficTypeDiagnostic: CY4PR10MB2038: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: SIew6ygn9jVFU/Cb4dxiMsNgRINtZUTOhEf5/cfKVStqlqJX6Kxo4sVokd3+/g+hq23mZEEgUbstVBUp/rj+hN0szv+HxxYod/y0tyKDJbQvsmnQxQMku6mspiAe43zZPKhDxBv2oJPHVTBQ7sgIOB9Uh92YXxy/OrFVQ5CqIF6U5eKHGZy/GLDJaNR8y12QlO+2iUPeCpMocB34eHYF7CLdDyvhj8j6Tnbzgp2VhON03BK+mMQ6i1ZQamXu9qhWCaa3KRBxfuUwtuJuY69D7DGKvrHar+vwM7K2zK2Kuz3B1HfveHuEbgtmyKis8xpXbPvDbOyARBGf6PznTn3BwM6VoXkpTZloykT7JFlQlt5Rc5aq1+9r/2rvb5hNoPhujRq4HJpB/dHWkVe4w0/e3PA/saNrg9goEZ9paij5fRjo7QJwDMfF6QfqiYvGkkhyKXa97C448CdIhJ6cDI4Mt151CEdXrcdrogvLXyujRos= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CY4PR10MB1718.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(376002)(39860400002)(136003)(396003)(366004)(346002)(478600001)(53546011)(956004)(54906003)(2616005)(5660300002)(8936002)(26005)(16576012)(31696002)(4326008)(316002)(107886003)(2906002)(6486002)(36756003)(66946007)(66556008)(66476007)(31686004)(86362001)(8676002)(186003)(16526019)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?SDFXNm5ueWRRQjFQVU9XZExqK0hFTVV1R1BWbnI5M0NrdElCdUx0TituTWpw?= =?utf-8?B?T0NtTVdCTEd5MWw0VURxZmgxV3NCaFBiZ2drS0hFZkFzVnh4NWRZQjVnSjRZ?= =?utf-8?B?ZXZaemxpanJQVGFOTU9sUzdGa0hJeDY5Z0dOYnpPaUVZRUZkQk9YUm5XeGRu?= =?utf-8?B?bjU4MHA1b2xYblIxRDZIOG5sZVM5cHJ2UkJNaGhPMnNPZDRscWRjSVMrUnFJ?= =?utf-8?B?ZEMzbnd1VDRQVTRGSE1ZQ3lsMGhkaTlXVGZ0em1Wc2tyY0NSWm9TeFdzck9O?= =?utf-8?B?NWJvcUtucFpkdWdMRFJzYVF6WERNVnJYUVgyOVo0Q1A5NURCaXVGQkhYUEtV?= =?utf-8?B?WUdreHhSOG1iQW95Ukd5ZU9OdGtib09PWTBpRkF4R1dCU2V6aFY5cmdaOXV1?= =?utf-8?B?WU8xSjVnekk5ZFNiWTVUNk9aOWZTN2VHV0hJZXdJMVBUUmhkWndEbk5HU2dH?= =?utf-8?B?Qkx4ZGdYd1h5czdFNTlpUzkyNjhaT3c4a215L25zb1NldUM5OElnTTNpdjhV?= =?utf-8?B?Q2dHS015aHlIZ3UwYWI4UGtZZ0t4WUtsTzU3TUQwdXk0aFBqYVMwOHMrM0Vt?= =?utf-8?B?MExLQm1qT3V6YlRDY0VsQTNwU0hLaEtxa0VSNlBBekZ3eUw2YUU5c2NMRFEv?= =?utf-8?B?SWV3cTU3ejZJQTc3Z1dCaklISnI0NlpEYVdiR2JJNVpmM1JVRFM3OUhVV092?= =?utf-8?B?OHJ6elgwaExoNGxyOTY4Y0dWTk1ZRE9lRkNjRWJUZTFyU3pGcDBQTk0yWndn?= =?utf-8?B?ajY2bzhTUytaamY0RmxDMk5CYU5MV2dIZ2xhZUR1WmtIRWovSTVCRG85bUxS?= =?utf-8?B?dVBrYnpCY2pPemVjM3JncW9wd210TjhGdXJaSDhwU3Exb0o4Nm1oY1J6WVlB?= =?utf-8?B?dFB3VVc2MkgrZWQzUzJNa3E4UjU5a2VPK2crY1pnNUVwN1VmNTdPMnhXRGdV?= =?utf-8?B?S01YTXdsRGNrYlFic0Zwc1ZobUIyVlFPQlI0VFFlcW9JTkxMWDMvMllRNW1E?= =?utf-8?B?V3pEVWhEczFjeHR0RmNtTzRHUXhYUUJFUjdjaHU4RWZjTk1zQzZRbjlkaGNq?= =?utf-8?B?UkFkbzVnVkx6RWdHVW5JdGxDd1gyV0d6VVVWNitGcld1NWxSek1rNmNsWXBo?= =?utf-8?B?VC9vWUFEb3hKaW5kZm5ydVAwTmtSK1gzcVNlNlNRdG9Hc0lwSkZwL0lwL2Fa?= =?utf-8?B?L3loVmZQd1Z6aGo0dnU2dFhYbmM0NlgvSURKTG05aFlldFlsdzVOTGFuVkRC?= =?utf-8?B?OENRMTZiZzR5N0ozRllxS0g3ckNkQjFxUW1oZmVBUFVjdm92V1dxUlVqRVh6?= =?utf-8?B?QkhaaG1FbXVvZlY3cjBNNFAwNmovMW9zVWwrYUlMajRjbllYaGNHL2FFc0R3?= =?utf-8?B?QkNhWlR1QmUzZitPU0hhUXhQM0FkcmJlNVdOWisrRE9kU3F3YUovSkJXQTJB?= =?utf-8?Q?hdxkENdW?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 14113f51-dd27-4686-8f58-08d8c24d24a2 X-MS-Exchange-CrossTenant-AuthSource: CY4PR10MB1718.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jan 2021 22:53:05.9197 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 4MHPeigaWmV2C0P2KumoDQ5hoK/WyhUlN/alK+WuDKxsb4EOiZ6QeNtBUz0dg60uAI7OyRpvDgorSf+H3KBi/ILj5E1tgFy+Gn0AdGlYdPU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR10MB2038 X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9876 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 suspectscore=0 adultscore=0 mlxscore=0 malwarescore=0 spamscore=0 mlxlogscore=999 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2101260112 X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9876 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 adultscore=0 lowpriorityscore=0 mlxlogscore=999 clxscore=1015 phishscore=0 bulkscore=0 spamscore=0 priorityscore=1501 mlxscore=0 suspectscore=0 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2101260112 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit On 2021-01-26 1:32 p.m., Laszlo Ersek wrote: > On 01/26/21 22:17, Ankur Arora wrote: >> On 2021-01-26 1:07 p.m., Laszlo Ersek wrote: >>> On 01/26/21 20:15, Ankur Arora wrote: >>>> On 2021-01-26 11:01 a.m., Laszlo Ersek wrote: >>> >>>>> I'll continue the review later this week. >>>> >>>> Acking the comments above. >>> >>> Thank you! >>> >>>> Meanwhile let me reprocess the series in light of the comments above. >>> >>> I'm at such a point now, during the v5 review, that I think I can easily >>> re-sync. >>> >>> In general, I don't mind the posting of a new version of a series >>> mid-review, *IF* we agree about it in advance. >>> >>> If you prefer to post a v6, for addressing the comments I've made thus >>> far, I'm OK with that. If you'd like me to continue reviewing v5, I'm >>> also OK with that. >>> >>> So it's up to you -- please state your decision, so that I know if I >>> should proceed with v5 (later this week), or wait for v6. >> >> I think I would prefer to send v6. Looking at the v5 comments so far, I'm >> sure that there's a lot of non conforming coding style issues. >> Addressing them now (or at least a hopefully significant subset) would >> probably save time. > > I agree; thank you. > > (And, for all the yelling that ECC does, I'm really surprised it didn't > catch the "missing space between function designator and opening paren" > wart!) Heh. Yeah, I was surprised at how little fault ECC found in the code. Thanks for reviewing. Ankur > >> I'm looking at sending these out by Thursday morning PT, and given that >> you plan to continue later this week, sounds like it might not lose too >> much review time either. > > Yes, that should work fine. > > Thank you, Ankur! > Laszlo >