From: "Maciej Rabeda" <maciej.rabeda@linux.intel.com>
To: devel@edk2.groups.io, scott@scott.ph, Laszlo Ersek <lersek@redhat.com>
Cc: Rebecca Cran <rebecca@bsdio.com>
Subject: Re: [edk2-devel] [PATCH] NetworkPkg/HttpDxe: Clear TlsChildHandle during cleanup
Date: Tue, 15 Sep 2020 15:01:27 +0200 [thread overview]
Message-ID: <b67624fc-2673-3439-d2c3-ad56d2275561@linux.intel.com> (raw)
In-Reply-To: <EXTHXAg5y1oWChWeO3c4ylDAob4wqzn4EJDM6bJ_mD9_7n0LkT1BTuGrQctFtbzzyArq6JjstzrLsj0aAi5vA1a0MBy3DuCJE-b8y-PhCjA=@scott.ph>
[-- Attachment #1: Type: text/plain, Size: 2189 bytes --]
Hi Scott,
Thanks for submitting the patch - I am about to approve the patch,
however - a couple of small remarks to the commit message.
1. Please remove the "From:" line
2. Please add "Cc:" lines before "Signed-off-by". Cc people are added
based on appropriate EDK2 package maintainer & reviewer list:
https://github.com/tianocore/edk2/blob/master/Maintainers.txt
Example of a patch from NetworkPkg:
https://github.com/tianocore/edk2/commit/0716b2390f005e84961cb98af28bd16cdcc5db42
Thanks,
Maciej
On 08-Sep-20 06:50, D Scott Phillips wrote:
> On Monday, September 7, 2020 4:33 AM, Laszlo Ersek <lersek@redhat.com> wrote:
>
>> Hi Scott,
>>
>> (+Rebecca)
>>
>> On 09/05/20 03:15, D Scott Phillips wrote:
>>
>>> *From: D Scott Phillips d.scott.phillips@amperecomputing.com*
>>> Leaving TlsChildHandle with the stale handle causes later use of https
>>> with the http instance to incorrectly skip tls reconfiguration, use
>>> the stale handle, and eventually call a garbage function pointer.
>>>
>>> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1917
>>> Signed-off-by: D Scott Phillips d.scott.phillips@amperecomputing.com
>>>
>>> ------------------------------------------------------------------------------------------------------------------------------
>>>
>>> NetworkPkg/HttpDxe/HttpProto.c | 1 +
>>> 1 file changed, 1 insertion(+)
>>> diff --git a/NetworkPkg/HttpDxe/HttpProto.c b/NetworkPkg/HttpDxe/HttpProto.c
>>> index 3c7c6ff9f0..afc7db5a72 100644
>>> --- a/NetworkPkg/HttpDxe/HttpProto.c
>>> +++ b/NetworkPkg/HttpDxe/HttpProto.c
>>> @@ -873,6 +873,7 @@ HttpCleanProtocol (
>>> // Destroy the TLS instance.
>>> //
>>> HttpInstance->TlsSb->DestroyChild (HttpInstance->TlsSb, HttpInstance->TlsChildHandle);
>>>
>>> - HttpInstance->TlsChildHandle = NULL;
>>> }
>>>
>>>
>>> if (HttpInstance->Tcp4ChildHandle != NULL) {
>> thanks a lot for tracking this down!
>>
>> I've reopened BZ#1917, and linked your patch email in a new comment.
>>
>> But, I'd also like to assign the BZ to you, if that's OK with you. Can
>> you please register in the TianoCore bugzilla instance for that?
> Certainly, account created and assignment taken. Thanks Laszlo.
>
> Scott
>
>
>
>
[-- Attachment #2: Type: text/html, Size: 3494 bytes --]
prev parent reply other threads:[~2020-09-15 13:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-05 1:15 [PATCH] NetworkPkg/HttpDxe: Clear TlsChildHandle during cleanup D Scott Phillips
2020-09-07 11:33 ` [edk2-devel] " Laszlo Ersek
2020-09-08 4:50 ` D Scott Phillips
2020-09-15 13:01 ` Maciej Rabeda [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b67624fc-2673-3439-d2c3-ad56d2275561@linux.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox