Re: [edk2-devel] [PATCH RFC v3 01/22] UefiCpuPkg: Define the SEV-SNP specific dynamic PCDs

["Laszlo Ersek" <lersek@redhat.com>]

On 05/27/21 01:10, Brijesh Singh wrote:
> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3275
> 
> Define the PCDs used by the MpLib while creating the AP when SEV-SNP is
> active in the guest VMs.

(1) I think MpLib should be MpInitLib.

(2) If it's not too annoying, I'd suggest using "APs" (plural) and "VM"
(singular).

I'll have to see in the rest of the series how these PCDs are set and
read, but as a starting point, this patch looks good OK to me.

Reviewed-by: Laszlo Ersek <lersek@redhat.com>

Thanks
Laszlo

> 
> Cc: James Bottomley <jejb@linux.ibm.com>
> Cc: Min Xu <min.m.xu@intel.com>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Tom Lendacky <thomas.lendacky@amd.com>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Erdem Aktas <erdemaktas@google.com>
> Signed-off-by: Brijesh Singh <brijesh.singh@amd.com>
> ---
>  UefiCpuPkg/UefiCpuPkg.dec | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/UefiCpuPkg/UefiCpuPkg.dec b/UefiCpuPkg/UefiCpuPkg.dec
> index 62acb291f309..0ec25871a50f 100644
> --- a/UefiCpuPkg/UefiCpuPkg.dec
> +++ b/UefiCpuPkg/UefiCpuPkg.dec
> @@ -396,5 +396,16 @@ [PcdsDynamic, PcdsDynamicEx]
>    # @Prompt SEV-ES Status
>    gUefiCpuPkgTokenSpaceGuid.PcdSevEsIsEnabled|FALSE|BOOLEAN|0x60000016
>  
> +  ## This dynamic PCD indicates whether SEV-SNP is enabled
> +  #   TRUE  - SEV-SNP is enabled
> +  #   FALSE - SEV-SNP is not enabled
> +  # @Prompt SEV-SNP Status
> +  gUefiCpuPkgTokenSpaceGuid.PcdSevSnpIsEnabled|FALSE|BOOLEAN|0x60000017
> +
> +  ## This dynamic PCD contains the hypervisor features value obtained through the GHCB HYPERVISOR
> +  #  features VMGEXIT defined in the version 2 of GHCB spec.
> +  # @Prompt GHCB Hypervisor Features
> +  gUefiCpuPkgTokenSpaceGuid.PcdGhcbHypervisorFeatures|0x0|UINT64|0x60000018
> +
>  [UserExtensions.TianoCore."ExtraFiles"]
>    UefiCpuPkgExtra.uni
>