From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web12.7915.1622727510134632236 for ; Thu, 03 Jun 2021 06:38:30 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=ABrZGSTQ; spf=pass (domain: redhat.com, ip: 170.10.133.124, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1622727509; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hsQJ/MRdvWLiCNGNiOdLoHcptiecd1hhTxfcIr7N+90=; b=ABrZGSTQtFhArYuowOhTGwjIikrVsQVBR7IfVQ2m+gmK/EEBmkPjcCu7mfb+DcMIdIJFAQ VA3zCQWOWU9VVstk7pysOklNdZPzPkoqnDmcyYqH+bcYJ3/T9HiiavlOHQrU7RIB58HKsr o8KB/ECfCULQ7L6U1vIt7iR0Ius2OBE= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-320-ymUnAPsjMQyguywyPgQZLg-1; Thu, 03 Jun 2021 09:38:24 -0400 X-MC-Unique: ymUnAPsjMQyguywyPgQZLg-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 6BB72107ACF4; Thu, 3 Jun 2021 13:38:22 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-112-70.ams2.redhat.com [10.36.112.70]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 009481A26A; Thu, 3 Jun 2021 13:38:19 +0000 (UTC) Subject: Re: [edk2-devel] [PATCH RFC v3 01/22] UefiCpuPkg: Define the SEV-SNP specific dynamic PCDs To: devel@edk2.groups.io, brijesh.singh@amd.com, James Bottomley , Min Xu , Jiewen Yao , Tom Lendacky , Jordan Justen , Erdem Aktas , Eric Dong , Ray Ni , Rahul Kumar Cc: Ard Biesheuvel References: <20210526231118.12946-1-brijesh.singh@amd.com> <20210526231118.12946-2-brijesh.singh@amd.com> From: "Laszlo Ersek" Message-ID: Date: Thu, 3 Jun 2021 15:38:18 +0200 MIME-Version: 1.0 In-Reply-To: <20210526231118.12946-2-brijesh.singh@amd.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=lersek@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 05/27/21 01:10, Brijesh Singh wrote: > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3275 > > Define the PCDs used by the MpLib while creating the AP when SEV-SNP is > active in the guest VMs. (1) I think MpLib should be MpInitLib. (2) If it's not too annoying, I'd suggest using "APs" (plural) and "VM" (singular). I'll have to see in the rest of the series how these PCDs are set and read, but as a starting point, this patch looks good OK to me. Reviewed-by: Laszlo Ersek Thanks Laszlo > > Cc: James Bottomley > Cc: Min Xu > Cc: Jiewen Yao > Cc: Tom Lendacky > Cc: Jordan Justen > Cc: Ard Biesheuvel > Cc: Laszlo Ersek > Cc: Erdem Aktas > Signed-off-by: Brijesh Singh > --- > UefiCpuPkg/UefiCpuPkg.dec | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/UefiCpuPkg/UefiCpuPkg.dec b/UefiCpuPkg/UefiCpuPkg.dec > index 62acb291f309..0ec25871a50f 100644 > --- a/UefiCpuPkg/UefiCpuPkg.dec > +++ b/UefiCpuPkg/UefiCpuPkg.dec > @@ -396,5 +396,16 @@ [PcdsDynamic, PcdsDynamicEx] > # @Prompt SEV-ES Status > gUefiCpuPkgTokenSpaceGuid.PcdSevEsIsEnabled|FALSE|BOOLEAN|0x60000016 > > + ## This dynamic PCD indicates whether SEV-SNP is enabled > + # TRUE - SEV-SNP is enabled > + # FALSE - SEV-SNP is not enabled > + # @Prompt SEV-SNP Status > + gUefiCpuPkgTokenSpaceGuid.PcdSevSnpIsEnabled|FALSE|BOOLEAN|0x60000017 > + > + ## This dynamic PCD contains the hypervisor features value obtained through the GHCB HYPERVISOR > + # features VMGEXIT defined in the version 2 of GHCB spec. > + # @Prompt GHCB Hypervisor Features > + gUefiCpuPkgTokenSpaceGuid.PcdGhcbHypervisorFeatures|0x0|UINT64|0x60000018 > + > [UserExtensions.TianoCore."ExtraFiles"] > UefiCpuPkgExtra.uni >