Re: [edk2-devel] [PATCH v2 0/2] ArmPkg/MdePkg: Move Chipset/* files to MdePkg

["PierreGondois" <pierre.gondois@arm.com>]

On 6/10/24 18:28, Leif Lindholm wrote:
> On 2024-03-14 20:21, PierreGondois wrote:
>> v2:
>> - Move files to MdePkg/Include/Register/ instead of  MdePkg/Include/
>>
>> This patch relies on [1].
>>
>> Following the RFC v1: ArmPkg,MdePkg: move ArmLib.h to MdePkg [1],
>> move the Chipset/* files to the MdePkg as the Armlib.h relies on
>> them.
>>
>> These patches span over multiple packages as these Chipset/* files
>> are relocated to a new directory and include paths must be updated.
>>
>> [1] https://edk2.groups.io/g/devel/message/111566
> 
> For my part, for the series:
> Reviewed-by: Leif Lindholm <quic_llindhol@quicinc.com>

Thanks !
I created a PR including your patch at:
https://github.com/tianocore/edk2/pull/5766

Regards,
Pierre

> 
>> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
>> Cc: Gerd Hoffmann <kraxel@redhat.com>
>> Cc: Jiewen Yao <jiewen.yao@intel.com>
>> Cc: Leif Lindholm <quic_llindhol@quicinc.com>
>> Cc: Liming Gao <gaoliming@byosoft.com.cn>
>> Cc: Michael D Kinney <michael.d.kinney@intel.com>
>> Cc: Pierre Gondois <pierre.gondois@arm.com>
>> Cc: Sami Mujawar <sami.mujawar@arm.com>
>> Cc: Zhiguang Liu <zhiguang.liu@intel.com>
>>
>> Pierre Gondois (2):
>>     ArmPkg,MdePkg: Move ArmPkg/Chipset/AArch64[|Mmu].h to MdePkg
>>     ArmPkg,MdePkg: Move ArmPkg/Chipset/ArmV7[|Mmu].h to MdePkg
>>
>>    ArmPkg/Library/ArmExceptionLib/AArch64/AArch64Exception.c     | 2 +-
>>    ArmPkg/Library/ArmExceptionLib/AArch64/ExceptionSupport.S     | 2 +-
>>    ArmPkg/Library/ArmExceptionLib/Arm/ArmException.c             | 2 +-
>>    ArmPkg/Library/ArmLib/AArch64/AArch64Lib.c                    | 2 +-
>>    ArmPkg/Library/ArmLib/AArch64/AArch64Support.S                | 2 +-
>>    ArmPkg/Library/ArmLib/Arm/ArmV7Lib.c                          | 2 +-
>>    ArmPkg/Library/ArmMmuLib/AArch64/ArmMmuLibCore.c              | 2 +-
>>    ArmPkg/Library/ArmMmuLib/Arm/ArmMmuLibConvert.c               | 2 +-
>>    ArmPkg/Library/ArmMmuLib/Arm/ArmMmuLibCore.c                  | 2 +-
>>    ArmPkg/Library/ArmMmuLib/Arm/ArmMmuLibUpdate.c                | 2 +-
>>    ArmPlatformPkg/PrePeiCore/AArch64/Exception.S                 | 2 +-
>>    ArmPlatformPkg/PrePeiCore/AArch64/Helper.S                    | 2 +-
>>    ArmPlatformPkg/PrePi/AArch64/ArchPrePi.c                      | 2 +-
>>    ArmPlatformPkg/PrePi/Arm/ModuleEntryPoint.S                   | 2 +-
>>    ArmVirtPkg/PrePi/AArch64/ArchPrePi.c                          | 2 +-
>>    MdePkg/Include/Library/ArmLib.h                               | 4 ++--
>>    .../Chipset => MdePkg/Include/Register/AArch64}/AArch64.h     | 2 +-
>>    .../Chipset => MdePkg/Include/Register/AArch64}/AArch64Mmu.h  | 0
>>    .../Chipset/ArmV7.h => MdePkg/Include/Register/Arm/AArch32.h  | 2 +-
>>    .../ArmV7Mmu.h => MdePkg/Include/Register/Arm/AArch32Mmu.h    | 0
>>    20 files changed, 19 insertions(+), 19 deletions(-)
>>    rename {ArmPkg/Include/Chipset => MdePkg/Include/Register/AArch64}/AArch64.h (94%)
>>    rename {ArmPkg/Include/Chipset => MdePkg/Include/Register/AArch64}/AArch64Mmu.h (100%)
>>    rename ArmPkg/Include/Chipset/ArmV7.h => MdePkg/Include/Register/Arm/AArch32.h (94%)
>>    rename ArmPkg/Include/Chipset/ArmV7Mmu.h => MdePkg/Include/Register/Arm/AArch32Mmu.h (100%)
>>
> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#119549): https://edk2.groups.io/g/devel/message/119549
Mute This Topic: https://groups.io/mt/104927819/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-