Re: [edk2-devel] [edk2-platforms][PATCH v2 4/5] Platform/Intel: Early hook-up Acer Aspire VN7-572G

["Michael Kubacki" <mikuback@linux.microsoft.com>]

Reviewed-by: Michael Kubacki <michael.kubacki@microsoft.com>

On 8/13/2021 8:24 PM, Benjamin Doron wrote:
> Note that the SKU IDs do not represent register values, they were chosen
> somewhat arbitrarily. We perform the mapping ourselves, so the
> definitions can be changed.
>
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Michael Kubacki <michael.kubacki@microsoft.com>
> Signed-off-by: Benjamin Doron <benjamin.doron00@gmail.com>
> ---
>   Platform/Intel/KabylakeOpenBoardPkg/Include/PlatformBoardId.h | 2 ++
>   Platform/Intel/KabylakeOpenBoardPkg/OpenBoardPkg.dec          | 1 +
>   Platform/Intel/build.cfg                                      | 1 +
>   3 files changed, 4 insertions(+)
>
> diff --git a/Platform/Intel/KabylakeOpenBoardPkg/Include/PlatformBoardId.h b/Platform/Intel/KabylakeOpenBoardPkg/Include/PlatformBoardId.h
> index e83c56252d2c..0db4fb23583e 100644
> --- a/Platform/Intel/KabylakeOpenBoardPkg/Include/PlatformBoardId.h
> +++ b/Platform/Intel/KabylakeOpenBoardPkg/Include/PlatformBoardId.h
> @@ -22,6 +22,8 @@ Kaby Lake Platform Board Identifiers
>   
>
>   #define BoardIdSkylakeRvp3                  0x4
>
>   #define BoardIdGalagoPro3                   0x20
>
> +#define BoardIdRayleighSLx_dGPU             0x41
>
> +#define BoardIdNewgateSLx_dGPU              0x42
>
>   #define BoardIdKabyLakeYLpddr3Rvp3          0x60
>
>   
>
>   #define BoardIdUnknown1                     0xffff
>
> diff --git a/Platform/Intel/KabylakeOpenBoardPkg/OpenBoardPkg.dec b/Platform/Intel/KabylakeOpenBoardPkg/OpenBoardPkg.dec
> index 01d611661603..ac87fe486c4b 100644
> --- a/Platform/Intel/KabylakeOpenBoardPkg/OpenBoardPkg.dec
> +++ b/Platform/Intel/KabylakeOpenBoardPkg/OpenBoardPkg.dec
> @@ -20,6 +20,7 @@ PACKAGE_GUID = 0A8BA6E8-C8AC-4AC1-87AC-52772FA6AE5E
>   
>
>   [Includes]
>
>   Include
>
> +AspireVn7Dash572G/Include
>
>   GalagoPro3/Include
>
>   KabylakeRvp3/Include
>
>   Features/Tbt/Include
>
> diff --git a/Platform/Intel/build.cfg b/Platform/Intel/build.cfg
> index eba25d36a806..28273347971d 100644
> --- a/Platform/Intel/build.cfg
> +++ b/Platform/Intel/build.cfg
> @@ -57,6 +57,7 @@ BIOS_INFO_GUID =
>   # board_name = path_to_board_build_config.cfg
>
>   BoardMtOlympus = PurleyOpenBoardPkg/BoardMtOlympus/build_config.cfg
>
>   BoardX58Ich10 = SimicsOpenBoardPkg/BoardX58Ich10/build_config.cfg
>
> +AspireVn7Dash572G = KabylakeOpenBoardPkg/AspireVn7Dash572G/build_config.cfg
>
>   GalagoPro3 = KabylakeOpenBoardPkg/GalagoPro3/build_config.cfg
>
>   KabylakeRvp3 = KabylakeOpenBoardPkg/KabylakeRvp3/build_config.cfg
>
>   UpXtreme = WhiskeylakeOpenBoardPkg/UpXtreme/build_config.cfg
>