public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Michael Kubacki" <mikuback@linux.microsoft.com>
To: devel@edk2.groups.io, benjamin.doron00@gmail.com
Cc: Chasel Chiu <chasel.chiu@intel.com>,
	Nate DeSimone <nathaniel.l.desimone@intel.com>,
	Michael Kubacki <michael.kubacki@microsoft.com>
Subject: Re: [edk2-devel] [edk2-platforms][PATCH v2 4/5] Platform/Intel: Early hook-up Acer Aspire VN7-572G
Date: Mon, 16 Aug 2021 11:51:00 -0400	[thread overview]
Message-ID: <b6b0d14f-76ae-6292-3224-4417eec622df@linux.microsoft.com> (raw)
In-Reply-To: <20210814002445.10084-5-benjamin.doron00@gmail.com>

Reviewed-by: Michael Kubacki <michael.kubacki@microsoft.com>

On 8/13/2021 8:24 PM, Benjamin Doron wrote:
> Note that the SKU IDs do not represent register values, they were chosen
> somewhat arbitrarily. We perform the mapping ourselves, so the
> definitions can be changed.
>
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Michael Kubacki <michael.kubacki@microsoft.com>
> Signed-off-by: Benjamin Doron <benjamin.doron00@gmail.com>
> ---
>   Platform/Intel/KabylakeOpenBoardPkg/Include/PlatformBoardId.h | 2 ++
>   Platform/Intel/KabylakeOpenBoardPkg/OpenBoardPkg.dec          | 1 +
>   Platform/Intel/build.cfg                                      | 1 +
>   3 files changed, 4 insertions(+)
>
> diff --git a/Platform/Intel/KabylakeOpenBoardPkg/Include/PlatformBoardId.h b/Platform/Intel/KabylakeOpenBoardPkg/Include/PlatformBoardId.h
> index e83c56252d2c..0db4fb23583e 100644
> --- a/Platform/Intel/KabylakeOpenBoardPkg/Include/PlatformBoardId.h
> +++ b/Platform/Intel/KabylakeOpenBoardPkg/Include/PlatformBoardId.h
> @@ -22,6 +22,8 @@ Kaby Lake Platform Board Identifiers
>   
>
>   #define BoardIdSkylakeRvp3                  0x4
>
>   #define BoardIdGalagoPro3                   0x20
>
> +#define BoardIdRayleighSLx_dGPU             0x41
>
> +#define BoardIdNewgateSLx_dGPU              0x42
>
>   #define BoardIdKabyLakeYLpddr3Rvp3          0x60
>
>   
>
>   #define BoardIdUnknown1                     0xffff
>
> diff --git a/Platform/Intel/KabylakeOpenBoardPkg/OpenBoardPkg.dec b/Platform/Intel/KabylakeOpenBoardPkg/OpenBoardPkg.dec
> index 01d611661603..ac87fe486c4b 100644
> --- a/Platform/Intel/KabylakeOpenBoardPkg/OpenBoardPkg.dec
> +++ b/Platform/Intel/KabylakeOpenBoardPkg/OpenBoardPkg.dec
> @@ -20,6 +20,7 @@ PACKAGE_GUID = 0A8BA6E8-C8AC-4AC1-87AC-52772FA6AE5E
>   
>
>   [Includes]
>
>   Include
>
> +AspireVn7Dash572G/Include
>
>   GalagoPro3/Include
>
>   KabylakeRvp3/Include
>
>   Features/Tbt/Include
>
> diff --git a/Platform/Intel/build.cfg b/Platform/Intel/build.cfg
> index eba25d36a806..28273347971d 100644
> --- a/Platform/Intel/build.cfg
> +++ b/Platform/Intel/build.cfg
> @@ -57,6 +57,7 @@ BIOS_INFO_GUID =
>   # board_name = path_to_board_build_config.cfg
>
>   BoardMtOlympus = PurleyOpenBoardPkg/BoardMtOlympus/build_config.cfg
>
>   BoardX58Ich10 = SimicsOpenBoardPkg/BoardX58Ich10/build_config.cfg
>
> +AspireVn7Dash572G = KabylakeOpenBoardPkg/AspireVn7Dash572G/build_config.cfg
>
>   GalagoPro3 = KabylakeOpenBoardPkg/GalagoPro3/build_config.cfg
>
>   KabylakeRvp3 = KabylakeOpenBoardPkg/KabylakeRvp3/build_config.cfg
>
>   UpXtreme = WhiskeylakeOpenBoardPkg/UpXtreme/build_config.cfg
>


  parent reply	other threads:[~2021-08-16 15:51 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-04 20:36 [edk2-platforms][PATCH v1 0/4] KabylakeOpenBoardPkg: Add AspireVn7Dash572G Benjamin Doron
2021-08-04 20:36 ` [edk2-platforms][PATCH v1 1/4] KabylakeOpenBoardPkg/AspireVn7Dash572G: Duplicate KabylakeRvp3 directory Benjamin Doron
2021-08-04 20:36 ` [edk2-platforms][PATCH v1 2/4] KabylakeOpenBoardPkg/AspireVn7Dash572G: Rename KabylakeRvp3 files Benjamin Doron
2021-08-04 20:36 ` [edk2-platforms][PATCH v1 3/4] Platform/Intel: Early hook-up Acer Aspire VN7-572G Benjamin Doron
2021-08-04 20:36 ` [edk2-platforms][PATCH v1 4/4] KabylakeOpenBoardPkg/AspireVn7Dash572G: Add initial support Benjamin Doron
2021-08-14  0:24 ` [edk2-platforms][PATCH v2 0/5] KabylakeOpenBoardPkg: Add AspireVn7Dash572G Benjamin Doron
2021-08-14  0:24   ` [edk2-platforms][PATCH v2 1/5] KabylakeOpenBoardPkg/BaseEcLib: Add some common EC commands Benjamin Doron
2021-08-16  5:32     ` [edk2-devel] " Nate DeSimone
2021-08-16 15:50     ` Michael Kubacki
2021-08-14  0:24   ` [edk2-platforms][PATCH v2 2/5] KabylakeOpenBoardPkg/AspireVn7Dash572G: Duplicate KabylakeRvp3 directory Benjamin Doron
2021-08-16  5:32     ` Nate DeSimone
2021-08-16 15:50     ` [edk2-devel] " Michael Kubacki
2021-08-14  0:24   ` [edk2-platforms][PATCH v2 3/5] KabylakeOpenBoardPkg/AspireVn7Dash572G: Rename KabylakeRvp3 files Benjamin Doron
2021-08-16  5:32     ` Nate DeSimone
2021-08-16 15:50     ` [edk2-devel] " Michael Kubacki
2021-08-14  0:24   ` [edk2-platforms][PATCH v2 4/5] Platform/Intel: Early hook-up Acer Aspire VN7-572G Benjamin Doron
2021-08-16  5:32     ` Nate DeSimone
2021-08-16 15:51     ` Michael Kubacki [this message]
2021-08-14  0:24   ` [edk2-platforms][PATCH v2 5/5] KabylakeOpenBoardPkg/AspireVn7Dash572G: Add initial support Benjamin Doron
2021-08-16  5:21     ` Nate DeSimone
2021-08-16 15:49       ` [edk2-devel] " Michael Kubacki
2021-08-18 20:17         ` Benjamin Doron
2021-08-16  5:22   ` [edk2-devel] [edk2-platforms][PATCH v2 0/5] KabylakeOpenBoardPkg: Add AspireVn7Dash572G Nate DeSimone
2021-08-18 20:05     ` Benjamin Doron
     [not found]   ` <169BB1F1F47FC595.23238@groups.io>
2021-08-16  5:31     ` Nate DeSimone
2021-08-18 20:31       ` Benjamin Doron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b6b0d14f-76ae-6292-3224-4417eec622df@linux.microsoft.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox