From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 15B777803D0 for ; Fri, 26 Jan 2024 17:21:24 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=CAFo1s3AL1H48/h2pYxDeexGm3lqd+UE46fqtxA/dAU=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:Message-ID:Date:User-Agent:Subject:To:Cc:References:From:In-Reply-To:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1706289683; v=1; b=ml4d9A8Px6L45pOECHOtqwrww/9HW3Fcm8ViomzFSSPKGwRZHDsfwJdp/2wN61DMbUgKfpXP gMC1WW7WC9N4aAhV1Z/O71/DbTQHCSkSqCdpGMBLvLZIB/zcRDBjM+ynE6s2CEmUw5RRrGVGZan RrnOZylE8X/FZDR0cA+BESz4= X-Received: by 127.0.0.2 with SMTP id kqYNYY7687511xebVUcxWftQ; Fri, 26 Jan 2024 09:21:23 -0800 X-Received: from NAM12-DM6-obe.outbound.protection.outlook.com (NAM12-DM6-obe.outbound.protection.outlook.com [40.107.243.48]) by mx.groups.io with SMTP id smtpd.web10.3932.1706289682798487379 for ; Fri, 26 Jan 2024 09:21:23 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nsKp2G6jDQnfvthbjqvexJ/2ikjRVBwpHFRx2rN0ieitlX+q9/LDShz9Rxr+bZSzwK+u6sQiXZh1ItTirkzAPekGsUWYXtoaaRCu+PLnKASX9nkWT7Nz41mzwckfRzOjl456cD8FyORZyPfZckB4byQPBHk0lWe0OSAqFyizp4jSn7G3nnp/vSi8zrCJTB1FMfkWxrGzajTxYa2kVYWWYs01BpO1T8rxvqM9Dg6whPQOYh25osvX9Eqqt+HYWdZsqKyCfzNLqP4SSCabFWwg/C8M9WZEoLOHJdk7vf/fNy3wptWwftO5uQHd1tsIvMYzxy+8hC45samdxRS2qV2Hag== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=a6GYbob2VkbbYIUkSAP1GavSWbzuY51SI+yHV4DJdzY=; b=Z+LeQ+3Eml36onaMXc7z37bQ6ovp5EydeJVxCv8PfBKOFFHtf1a11K3Y9HJVHMMJvmRTwW2jynyTB0SEuCkOfBLC+N7VMYDrnZ2yWyyGwK1izaVIJc2enG+iRrs8RAy29lPIQCfayKWL3Ll5LogQ1lvE4T4qIWhIp2Y1qfeKumKrCJe0J5Z7X/4sMierPXZqVKo2xumeQubL3KICIup8B6teFdazKSf6OCiBRuvOLXrkubzoK74yu0igixvTHnyKEMH1fJ2GtmAOEwN3DfulpfhIJIu2JsdehKN+GhRok8tXaoEd33US03uNnxl9Mge7Bq8dkM279Ilw5NVw7OQoWQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none X-Received: from BL1PR12MB5732.namprd12.prod.outlook.com (2603:10b6:208:387::17) by CH0PR12MB5385.namprd12.prod.outlook.com (2603:10b6:610:d4::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7228.24; Fri, 26 Jan 2024 17:21:18 +0000 X-Received: from BL1PR12MB5732.namprd12.prod.outlook.com ([fe80::200:c1d0:b9aa:e16c]) by BL1PR12MB5732.namprd12.prod.outlook.com ([fe80::200:c1d0:b9aa:e16c%4]) with mapi id 15.20.7228.027; Fri, 26 Jan 2024 17:21:18 +0000 Message-ID: Date: Fri, 26 Jan 2024 11:21:16 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [edk2-devel] [PATCH] MdeModulePkg/PciBusDxe: Add feedback status for PciIoMap To: devel@edk2.groups.io, w.sheng@intel.com Cc: Ray Ni , Huang Jenny , Chiang Chris References: <20240122064706.2059-1-w.sheng@intel.com> From: "Lendacky, Thomas via groups.io" In-Reply-To: <20240122064706.2059-1-w.sheng@intel.com> X-ClientProxiedBy: SA9PR10CA0024.namprd10.prod.outlook.com (2603:10b6:806:a7::29) To BL1PR12MB5732.namprd12.prod.outlook.com (2603:10b6:208:387::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL1PR12MB5732:EE_|CH0PR12MB5385:EE_ X-MS-Office365-Filtering-Correlation-Id: 4849fa81-2f89-44ae-e948-08dc1e933565 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Message-Info: yMbuyOjIEBbrj6kIzzTLRT68WYX4JQ1U2lnAVHXe/GDV39cu4ablxMPMUpUr4rlfTU2DtSfV/JIs2YNicz87MUCR2bWSTyPqQvOfspaPhuX2ODhHjmhn/Zk9B7t7uAyVBh5Gx4Sw8oU9g/7Depzzi8LpsMxcUtQvdvixQ0g8hPQkI6oCOxjAMxJ+pgR+EVROLfTCA+LavmojdkA1J1PP32hhH5FD95QhT3pvIbmNjnlkRXN+mcWF9sAwdymuZrFIEZiaqXxFuTjRzQOT01HB009pISZcJhlfcWdmQftVFgLBidywboh2DXJalxK6Rdiulpw2Aq3MhWGYJEqzaI56fLTU2fZF2PDOp5HEbrocvckrJNMoXHcaV1tRRogw1YfWbSF6JejQaWidvA3PTPtO6eMZjsomBuQ4yp6NHsFtYPaZ8fU1Hw8AKzBFqyHhP5yHoYOkzJmbGbHddAc5+/AOWdogTRVNE9VJx7dR0S8vbv2MyulMwgTq7src9DUZCM74gdyU614GjdemNhETg7ngkbF9BKHzxPobIEHkI/l9I4YPGujKdT9iLT5UW1Hpto5mZjox8g0PdQAVvm6fWQi/l8iFdc6tBCpLDq1FmFpSs/dkVVplJdkKDAdAxUxZSboOOq5zqaQI4kBie2N/G0oI/Q== X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?T0JSVThDTnd4VzdBWm8xKy9JQVVHdCtWMy9wMk1XT0hxQnpCR0o1WUJWakpu?= =?utf-8?B?OXQ0eXZUM1NyRE1mbnlGczNQa2REbE9PdVA0enUrY29ubUxVaE1jNmxQeVRW?= =?utf-8?B?Nk9tQkJJaFpvVTAxbGdtb0daWFBiRU1WbmdmWW1pK0JEZnpxWGc1ZUhCUFpj?= =?utf-8?B?R2t2MUdKU0toNkphM3haNzNOMHZLQ3hRTEYzNkNaL2FxUFVoUzNlVUphQ1JI?= =?utf-8?B?ckFUeUpVaVBLa2EwNWZZaXhmMFhEY3Q5TzZpb1VNcjFGOUErTDVFQmJtZlhN?= =?utf-8?B?ZGpXSmJxeUlCMHZaSVcydXhxcDdUeW9wbkRuRWo1TENjSWpxalVvZkRrSHgz?= =?utf-8?B?NHZNb3M3dDRDaE56K1NjMDFRbmpiai9nL2RWckp3UTRRNmMzS2dnVzFLbHA3?= =?utf-8?B?SC9SYnNYVTZkR3h4N1AvYkpXNmd6WThWZU40NjlqTWtTTXBmR1lSVWZ0SWFq?= =?utf-8?B?VDh0dUkvNTNQY1ZqMGJ2SjUybUdMTEd4Z1g0WGFvWU9yZUZRTE1ibXVJMGNn?= =?utf-8?B?TjhYdmR0czR2QWZoc2NOQUJ6MEU5SDc3TmcyVE1HT2YvcEZzWlkwcDBUbXJw?= =?utf-8?B?TncwT3NyN2p3SS9XOVgwTWZodXJSVkVTR0lwNHZCL1d6TzR4OVlWUTVRaUFY?= =?utf-8?B?bFk1V3dhcVZNRGdDalNwUXdSUlhEeUhNUUpVcHMwMmJPYlV0VDJyaWVqcHZI?= =?utf-8?B?QzZvUDQ3N1RHSlhQZTIxREtVQnlpV3Q5UVluWmtsemdmL0lzQjZ4YXdsSFl3?= =?utf-8?B?VkJKR0JPVkR3Vy9ZRE1taTlaSWJKWjkvWHNoK2lwSnh3THpDamRTUnVrejJK?= =?utf-8?B?ajJ5TXJRQ3BRbkxRUU5nZEFjZXBhbkpvemxQcERTd1RiRjNrYk9PM3RJcjNX?= =?utf-8?B?ZkZLME1kY1oxeUpPcG9UVEsvYkN5UW8rSWlsVmpTMVlqUlloT21vZTgyR0ZX?= =?utf-8?B?RVhrQ1FmVDVrS24zTFd6NFdxaGJMTThYRW9BalhlZFFyQWZIeFVMbGNFcEZs?= =?utf-8?B?MTJiTVc1QXBZQW5CcU0wY0g2ZzJ0aFJhYjNQTFFDa0U4cytwOExmVEpQQm5W?= =?utf-8?B?Z3lFUWY1NFg2QUxEWGlOMFhYejE5ZlpvNTNicE56ZVpHOVVtRDBKWjY2MlND?= =?utf-8?B?eVJrZnpvQitRZDUwdlZ3MHlhYW5ETmljUFpRR1lxN1g5K09yT3J0clVsWkl2?= =?utf-8?B?MkFkem9iMFhjcG5NNml5bGpORHYrcHBzTitNQ0dWL0Z1Q3Q2VnZpSkhHY2h4?= =?utf-8?B?NnZickt1V0MvU0diNzk4d1pCbUFCbGZTWnF1ZncvQjdQRjVlcVN0RGlxNzQ1?= =?utf-8?B?TVcyNG1BYzlQRTNJM1QzMDdXclBEZUlWRkwzUVJWaDdHQnY4NmZkamtXQXY1?= =?utf-8?B?U1F0Ym56aGdmcGFvNDVtL0Y0U0d4dEMxb0hrNERQdXFrMEYza2FvNjdKZGpw?= =?utf-8?B?MWdZMm5iN3FXaGR1dmtPRXJ3UFJCK25XN1JLcWE3eG8vQjVqN2lESW9zT0Za?= =?utf-8?B?VkVScm0yVEQ3bS9rSUtjSDkzQXZvSTFtTTQyYnQwdzA2RzliQlJHZXlYTEJy?= =?utf-8?B?M0l4QkozME15VU9LZ2hzeUJ3K0oxdDVhRmhIVWlNUE1QWE5kSEdNVnY1ZVd1?= =?utf-8?B?RFdicGtoVUJrTTVhUGhJZCtTVE5ucFZxWUFKY1FBSi9JYU5uME1IbFR5dWFL?= =?utf-8?B?SjRjQSt3elJzSDBlbTRqVWZiVkwvcWtZZ3Z5MFN3V1o4Vjc0NUY3bUpqbWww?= =?utf-8?B?ZWk0ZGY4L3pYVndsRTNyTXRJbW1ZZ1RkK2JIcldvN3k3dFpYeVI3RWN3NXpm?= =?utf-8?B?NTBTazdXZmxzOE5XWGlmcTlYQW41VmkxZWpSOGYxa1BacXJORE4xQVc4a3JY?= =?utf-8?B?RFc5LzM4MjZHL0czSitoQm1zdTF5dktENUpwdi9YQkhUWmpNMGQxeHBRaWlL?= =?utf-8?B?Q3lYcW4zQ1lMb1RuclVJVU1xbXdmZWMvSnF0ei8ySkNUUFBIMFQ0RCtRRWF6?= =?utf-8?B?RzRTL1lKYVA3NGQ1L0hoTDN5TDRjODNzNXZQbHljM0FZd1Q0ZlhwYUFKNGdv?= =?utf-8?B?bjFZWWgxb3dyNUxKTlQ1MkpWNkpteDFhOGNUYnQzeXRmUHA4dXVyYUJUeWkv?= =?utf-8?Q?Q3x66SN49/+CWh3x6laW5eDf3?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4849fa81-2f89-44ae-e948-08dc1e933565 X-MS-Exchange-CrossTenant-AuthSource: BL1PR12MB5732.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jan 2024 17:21:18.5736 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: X9kSUAV5wfbUjKYo0VSlzx7R6ZCmGxwi1q1RkilBXK4GEf3giOSjX0CgYpSllR5l4V3PXWdivI60zz2yeFTnJA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR12MB5385 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,thomas.lendacky@amd.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: DYHv9DCsG2xDLBygsaFBxxH9x7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=ml4d9A8P; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On 1/22/24 00:47, Sheng Wei via groups.io wrote: > PciIoMap () need to feedback the status of > mIoMmuProtocol->SetAttribute () return value. >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4652 I'm still investigating, but this commit breaks booting all types of SEV=20 guests. Without this patch, there is a boot device mapping and the Grub=20 menu is displayed. But with this patch, I receive: map: No mapping found. Press ESC in 1 seconds to skip startup.nsh or any other key to continue. and then drop to the shell prompt. Thanks, Tom >=20 > Cc: Ray Ni > Cc: Huang Jenny > Cc: Chiang Chris > Signed-off-by: Sheng Wei > --- > MdeModulePkg/Bus/Pci/PciBusDxe/PciIo.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) >=20 > diff --git a/MdeModulePkg/Bus/Pci/PciBusDxe/PciIo.c b/MdeModulePkg/Bus/Pc= i/PciBusDxe/PciIo.c > index 14bed54729..e85544d08d 100644 > --- a/MdeModulePkg/Bus/Pci/PciBusDxe/PciIo.c > +++ b/MdeModulePkg/Bus/Pci/PciBusDxe/PciIo.c > @@ -1024,12 +1024,12 @@ PciIoMap ( > return EFI_INVALID_PARAMETER; > } > =20 > - mIoMmuProtocol->SetAttribute ( > - mIoMmuProtocol, > - PciIoDevice->Handle, > - *Mapping, > - IoMmuAttribute > - ); > + Status =3D mIoMmuProtocol->SetAttribute ( > + mIoMmuProtocol, > + PciIoDevice->Handle, > + *Mapping, > + IoMmuAttribute > + ); > } > } > =20 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#114621): https://edk2.groups.io/g/devel/message/114621 Mute This Topic: https://groups.io/mt/103881889/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-