From: "Laszlo Ersek" <lersek@redhat.com>
To: devel@edk2.groups.io, ray.ni@intel.com
Cc: Eric Dong <eric.dong@intel.com>, Jiewen Yao <jiewen.yao@intel.com>
Subject: Re: [edk2-devel] [PATCH 5/5] UefiCpuPkg: Remove PcdCpuSmmStaticPageTable
Date: Mon, 26 Aug 2019 19:39:42 +0200 [thread overview]
Message-ID: <b6c68cd7-2083-21dc-507e-1d093cb5acaf@redhat.com> (raw)
In-Reply-To: <20190825224513.171572-6-ray.ni@intel.com>
On 08/26/19 00:45, Ni, Ray wrote:
> PcdCpuSmmRestrictedMemoryAccess is introduced to replace
> PcdCpuSmmStaticPageTable.
>
> Signed-off-by: Ray Ni <ray.ni@intel.com>
> Cc: Eric Dong <eric.dong@intel.com>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> ---
> UefiCpuPkg/UefiCpuPkg.dec | 11 -----------
> 1 file changed, 11 deletions(-)
>
> diff --git a/UefiCpuPkg/UefiCpuPkg.dec b/UefiCpuPkg/UefiCpuPkg.dec
> index 9a03bdd716..031a2ccd68 100644
> --- a/UefiCpuPkg/UefiCpuPkg.dec
> +++ b/UefiCpuPkg/UefiCpuPkg.dec
> @@ -247,17 +247,6 @@ [PcdsFixedAtBuild, PcdsPatchableInModule, PcdsDynamic, PcdsDynamicEx]
> # @Prompt The specified AP target C-state for Mwait.
> gUefiCpuPkgTokenSpaceGuid.PcdCpuApTargetCstate|0|UINT8|0x00000007
>
> - ## Indicates if SMM uses static page table.
> - # If enabled, SMM will not use on-demand paging. SMM will build static page table for all memory.
> - # This flag only impacts X64 build, because SMM always builds static page table for IA32.
> - # It could not be enabled at the same time with SMM profile feature (PcdCpuSmmProfileEnable).
> - # It could not be enabled also at the same time with heap guard feature for SMM
> - # (PcdHeapGuardPropertyMask in MdeModulePkg).<BR><BR>
> - # TRUE - SMM uses static page table for all memory.<BR>
> - # FALSE - SMM uses static page table for below 4G memory and use on-demand paging for above 4G memory.<BR>
> - # @Prompt Use static page table for all memory in SMM.
> - gUefiCpuPkgTokenSpaceGuid.PcdCpuSmmStaticPageTable|TRUE|BOOLEAN|0x3213210D
> -
> ## Specifies timeout value in microseconds for the BSP in SMM to wait for all APs to come into SMM.
> # @Prompt AP synchronization timeout value in SMM.
> gUefiCpuPkgTokenSpaceGuid.PcdCpuSmmApSyncTimeout|1000000|UINT64|0x32132104
>
Please update the UNI file as well.
Reviewed-by: Laszlo Ersek <lersek@redhat.com>
next prev parent reply other threads:[~2019-08-26 17:39 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-25 22:45 [PATCH 0/5] restrict memory access per PcdCpuSmmRestrictedMemoryAccess Ni, Ray
2019-08-25 22:45 ` [PATCH 1/5] UefiCpuPkg: Add PcdCpuSmmRestrictedMemoryAccess Ni, Ray
2019-08-26 17:09 ` [edk2-devel] " Laszlo Ersek
2019-08-27 1:43 ` Dong, Eric
2019-08-25 22:45 ` [PATCH 2/5] UefiCpuPkg/PiSmmCpu: Use new PCD PcdCpuSmmRestrictedMemoryAccess Ni, Ray
2019-08-26 17:12 ` [edk2-devel] " Laszlo Ersek
2019-08-27 1:43 ` Dong, Eric
2019-08-25 22:45 ` [PATCH 3/5] UefiCpuPkg/PiSmmCpu: Restrict access per PcdCpuSmmRestrictedMemoryAccess Ni, Ray
2019-08-26 17:16 ` [edk2-devel] " Laszlo Ersek
2019-08-27 1:43 ` Dong, Eric
2019-08-25 22:45 ` [PATCH 4/5] UefiCpuPkg: Explain relationship between several SMM PCDs Ni, Ray
2019-08-26 17:38 ` [edk2-devel] " Laszlo Ersek
2019-08-27 1:47 ` Dong, Eric
2019-08-25 22:45 ` [PATCH 5/5] UefiCpuPkg: Remove PcdCpuSmmStaticPageTable Ni, Ray
2019-08-26 17:39 ` Laszlo Ersek [this message]
2019-08-27 1:47 ` Dong, Eric
2019-09-20 8:44 ` [edk2-devel] [PATCH 0/5] restrict memory access per PcdCpuSmmRestrictedMemoryAccess Laszlo Ersek
2019-09-21 2:53 ` Ni, Ray
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b6c68cd7-2083-21dc-507e-1d093cb5acaf@redhat.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox