From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: redhat.com, ip: 209.132.183.28, mailfrom: lersek@redhat.com) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by groups.io with SMTP; Mon, 26 Aug 2019 10:39:44 -0700 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 5137281F19; Mon, 26 Aug 2019 17:39:44 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-117-34.ams2.redhat.com [10.36.117.34]) by smtp.corp.redhat.com (Postfix) with ESMTP id 5944360126; Mon, 26 Aug 2019 17:39:43 +0000 (UTC) Subject: Re: [edk2-devel] [PATCH 5/5] UefiCpuPkg: Remove PcdCpuSmmStaticPageTable To: devel@edk2.groups.io, ray.ni@intel.com Cc: Eric Dong , Jiewen Yao References: <20190825224513.171572-1-ray.ni@intel.com> <20190825224513.171572-6-ray.ni@intel.com> From: "Laszlo Ersek" Message-ID: Date: Mon, 26 Aug 2019 19:39:42 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20190825224513.171572-6-ray.ni@intel.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Mon, 26 Aug 2019 17:39:44 +0000 (UTC) Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 08/26/19 00:45, Ni, Ray wrote: > PcdCpuSmmRestrictedMemoryAccess is introduced to replace > PcdCpuSmmStaticPageTable. > > Signed-off-by: Ray Ni > Cc: Eric Dong > Cc: Jiewen Yao > Cc: Laszlo Ersek > --- > UefiCpuPkg/UefiCpuPkg.dec | 11 ----------- > 1 file changed, 11 deletions(-) > > diff --git a/UefiCpuPkg/UefiCpuPkg.dec b/UefiCpuPkg/UefiCpuPkg.dec > index 9a03bdd716..031a2ccd68 100644 > --- a/UefiCpuPkg/UefiCpuPkg.dec > +++ b/UefiCpuPkg/UefiCpuPkg.dec > @@ -247,17 +247,6 @@ [PcdsFixedAtBuild, PcdsPatchableInModule, PcdsDynamic, PcdsDynamicEx] > # @Prompt The specified AP target C-state for Mwait. > gUefiCpuPkgTokenSpaceGuid.PcdCpuApTargetCstate|0|UINT8|0x00000007 > > - ## Indicates if SMM uses static page table. > - # If enabled, SMM will not use on-demand paging. SMM will build static page table for all memory. > - # This flag only impacts X64 build, because SMM always builds static page table for IA32. > - # It could not be enabled at the same time with SMM profile feature (PcdCpuSmmProfileEnable). > - # It could not be enabled also at the same time with heap guard feature for SMM > - # (PcdHeapGuardPropertyMask in MdeModulePkg).

> - # TRUE - SMM uses static page table for all memory.
> - # FALSE - SMM uses static page table for below 4G memory and use on-demand paging for above 4G memory.
> - # @Prompt Use static page table for all memory in SMM. > - gUefiCpuPkgTokenSpaceGuid.PcdCpuSmmStaticPageTable|TRUE|BOOLEAN|0x3213210D > - > ## Specifies timeout value in microseconds for the BSP in SMM to wait for all APs to come into SMM. > # @Prompt AP synchronization timeout value in SMM. > gUefiCpuPkgTokenSpaceGuid.PcdCpuSmmApSyncTimeout|1000000|UINT64|0x32132104 > Please update the UNI file as well. Reviewed-by: Laszlo Ersek