From: "Laszlo Ersek" <lersek@redhat.com>
To: devel@edk2.groups.io, thomas.lendacky@amd.com
Cc: Brijesh Singh <brijesh.singh@amd.com>,
Jordan Justen <jordan.l.justen@intel.com>,
Ard Biesheuvel <ard.biesheuvel@arm.com>
Subject: Re: [edk2-devel] [PATCH v2 03/11] OvmfPkg/VmgExitLib: Implement new VmgExitLib interfaces
Date: Mon, 19 Oct 2020 22:51:20 +0200 [thread overview]
Message-ID: <b6c75b12-00c7-619e-8583-f63d0b70609a@redhat.com> (raw)
In-Reply-To: <495003dd5667796b7e79ac30b8d72308e46bd91a.1602864557.git.thomas.lendacky@amd.com>
On 10/16/20 18:09, Lendacky, Thomas wrote:
> From: Tom Lendacky <thomas.lendacky@amd.com>
>
> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3008
>
> The VmgExitLib library added two new interfaces, VmgSetOffsetValid() and
> VmgIsOffsetValid(), that must now be implemented in the OvmfPkg version
> of the library.
>
> Implement VmgSetOffsetValid() and VmgIsOffsetValid() and update existing
> code, that is directly accessing ValidBitmap, to use the new interfaces.
>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
> Cc: Tom Lendacky <thomas.lendacky@amd.com>
> Cc: Brijesh Singh <brijesh.singh@amd.com>
> Signed-off-by: Tom Lendacky <thomas.lendacky@amd.com>
> ---
> OvmfPkg/Library/VmgExitLib/VmgExitLib.c | 54 +++++++++
> OvmfPkg/Library/VmgExitLib/VmgExitVcHandler.c | 118 +++++---------------
> 2 files changed, 85 insertions(+), 87 deletions(-)
>
> diff --git a/OvmfPkg/Library/VmgExitLib/VmgExitLib.c b/OvmfPkg/Library/VmgExitLib/VmgExitLib.c
> index 53040cc6f649..3072c2265df7 100644
> --- a/OvmfPkg/Library/VmgExitLib/VmgExitLib.c
> +++ b/OvmfPkg/Library/VmgExitLib/VmgExitLib.c
> @@ -157,3 +157,57 @@ VmgDone (
> {
> }
>
> +/**
> + Marks a field at the specified offset as valid in the GHCB.
> +
> + The ValidBitmap area represents the areas of the GHCB that have been marked
> + valid. Set the bit in ValidBitmap for the input offset.
> +
> + @param[in, out] Ghcb Pointer to the Guest-Hypervisor Communication Block
> + @param[in] Offset Qword offset in the GHCB to mark valid
> +
> +**/
> +VOID
> +EFIAPI
> +VmgSetOffsetValid (
> + IN OUT GHCB *Ghcb,
> + IN GHCB_QWORD_OFFSET Offset
> + )
> +{
> + UINT32 OffsetIndex;
> + UINT32 OffsetBit;
> +
> + OffsetIndex = Offset / 8;
> + OffsetBit = Offset % 8;
> +
> + Ghcb->SaveArea.ValidBitmap[OffsetIndex] |= (1 << OffsetBit);
> +}
> +
> +/**
> + Checks if a specified offset is valid in the GHCB.
> +
> + The ValidBitmap area represents the areas of the GHCB that have been marked
> + valid. Return whether the bit in the ValidBitmap is set for the input offset.
> +
> + @param[in] Ghcb A pointer to the GHCB
> + @param[in] Offset Qword offset in the GHCB to mark valid
> +
> + @retval TRUE Offset is marked vald in the GHCB
s/vald/valid/
with that:
Reviewed-by: Laszlo Ersek <lersek@redhat.com>
Thanks
laszlo
> + @retval FALSE Offset is not marked valid in the GHCB
> +
> +**/
> +BOOLEAN
> +EFIAPI
> +VmgIsOffsetValid (
> + IN GHCB *Ghcb,
> + IN GHCB_QWORD_OFFSET Offset
> + )
> +{
> + UINT32 OffsetIndex;
> + UINT32 OffsetBit;
> +
> + OffsetIndex = Offset / 8;
> + OffsetBit = Offset % 8;
> +
> + return ((Ghcb->SaveArea.ValidBitmap[OffsetIndex] & (1 << OffsetBit)) != 0);
> +}
> diff --git a/OvmfPkg/Library/VmgExitLib/VmgExitVcHandler.c b/OvmfPkg/Library/VmgExitLib/VmgExitVcHandler.c
> index c5484a3f478c..7d14341d592b 100644
> --- a/OvmfPkg/Library/VmgExitLib/VmgExitVcHandler.c
> +++ b/OvmfPkg/Library/VmgExitLib/VmgExitVcHandler.c
> @@ -135,62 +135,6 @@ typedef struct {
> } SEV_ES_PER_CPU_DATA;
>
>
> -/**
> - Checks the GHCB to determine if the specified register has been marked valid.
> -
> - The ValidBitmap area represents the areas of the GHCB that have been marked
> - valid. Return an indication of whether the area of the GHCB that holds the
> - specified register has been marked valid.
> -
> - @param[in] Ghcb Pointer to the Guest-Hypervisor Communication Block
> - @param[in] Reg Offset in the GHCB of the register to check
> -
> - @retval TRUE Register has been marked vald in the GHCB
> - @retval FALSE Register has not been marked valid in the GHCB
> -
> -**/
> -STATIC
> -BOOLEAN
> -GhcbIsRegValid (
> - IN GHCB *Ghcb,
> - IN GHCB_QWORD_OFFSET Reg
> - )
> -{
> - UINT32 RegIndex;
> - UINT32 RegBit;
> -
> - RegIndex = Reg / 8;
> - RegBit = Reg & 0x07;
> -
> - return ((Ghcb->SaveArea.ValidBitmap[RegIndex] & (1 << RegBit)) != 0);
> -}
> -
> -/**
> - Marks a register as valid in the GHCB.
> -
> - The ValidBitmap area represents the areas of the GHCB that have been marked
> - valid. Set the area of the GHCB that holds the specified register as valid.
> -
> - @param[in, out] Ghcb Pointer to the Guest-Hypervisor Communication Block
> - @param[in] Reg Offset in the GHCB of the register to mark valid
> -
> -**/
> -STATIC
> -VOID
> -GhcbSetRegValid (
> - IN OUT GHCB *Ghcb,
> - IN GHCB_QWORD_OFFSET Reg
> - )
> -{
> - UINT32 RegIndex;
> - UINT32 RegBit;
> -
> - RegIndex = Reg / 8;
> - RegBit = Reg & 0x07;
> -
> - Ghcb->SaveArea.ValidBitmap[RegIndex] |= (1 << RegBit);
> -}
> -
> /**
> Return a pointer to the contents of the specified register.
>
> @@ -891,9 +835,9 @@ MwaitExit (
> DecodeModRm (Regs, InstructionData);
>
> Ghcb->SaveArea.Rax = Regs->Rax;
> - GhcbSetRegValid (Ghcb, GhcbRax);
> + VmgSetOffsetValid (Ghcb, GhcbRax);
> Ghcb->SaveArea.Rcx = Regs->Rcx;
> - GhcbSetRegValid (Ghcb, GhcbRcx);
> + VmgSetOffsetValid (Ghcb, GhcbRcx);
>
> return VmgExit (Ghcb, SVM_EXIT_MWAIT, 0, 0);
> }
> @@ -923,11 +867,11 @@ MonitorExit (
> DecodeModRm (Regs, InstructionData);
>
> Ghcb->SaveArea.Rax = Regs->Rax; // Identity mapped, so VA = PA
> - GhcbSetRegValid (Ghcb, GhcbRax);
> + VmgSetOffsetValid (Ghcb, GhcbRax);
> Ghcb->SaveArea.Rcx = Regs->Rcx;
> - GhcbSetRegValid (Ghcb, GhcbRcx);
> + VmgSetOffsetValid (Ghcb, GhcbRcx);
> Ghcb->SaveArea.Rdx = Regs->Rdx;
> - GhcbSetRegValid (Ghcb, GhcbRdx);
> + VmgSetOffsetValid (Ghcb, GhcbRdx);
>
> return VmgExit (Ghcb, SVM_EXIT_MONITOR, 0, 0);
> }
> @@ -988,9 +932,9 @@ RdtscpExit (
> return Status;
> }
>
> - if (!GhcbIsRegValid (Ghcb, GhcbRax) ||
> - !GhcbIsRegValid (Ghcb, GhcbRcx) ||
> - !GhcbIsRegValid (Ghcb, GhcbRdx)) {
> + if (!VmgIsOffsetValid (Ghcb, GhcbRax) ||
> + !VmgIsOffsetValid (Ghcb, GhcbRcx) ||
> + !VmgIsOffsetValid (Ghcb, GhcbRdx)) {
> return UnsupportedExit (Ghcb, Regs, InstructionData);
> }
> Regs->Rax = Ghcb->SaveArea.Rax;
> @@ -1027,16 +971,16 @@ VmmCallExit (
> DecodeModRm (Regs, InstructionData);
>
> Ghcb->SaveArea.Rax = Regs->Rax;
> - GhcbSetRegValid (Ghcb, GhcbRax);
> + VmgSetOffsetValid (Ghcb, GhcbRax);
> Ghcb->SaveArea.Cpl = (UINT8) (Regs->Cs & 0x3);
> - GhcbSetRegValid (Ghcb, GhcbCpl);
> + VmgSetOffsetValid (Ghcb, GhcbCpl);
>
> Status = VmgExit (Ghcb, SVM_EXIT_VMMCALL, 0, 0);
> if (Status != 0) {
> return Status;
> }
>
> - if (!GhcbIsRegValid (Ghcb, GhcbRax)) {
> + if (!VmgIsOffsetValid (Ghcb, GhcbRax)) {
> return UnsupportedExit (Ghcb, Regs, InstructionData);
> }
> Regs->Rax = Ghcb->SaveArea.Rax;
> @@ -1074,15 +1018,15 @@ MsrExit (
> case 0x30: // WRMSR
> ExitInfo1 = 1;
> Ghcb->SaveArea.Rax = Regs->Rax;
> - GhcbSetRegValid (Ghcb, GhcbRax);
> + VmgSetOffsetValid (Ghcb, GhcbRax);
> Ghcb->SaveArea.Rdx = Regs->Rdx;
> - GhcbSetRegValid (Ghcb, GhcbRdx);
> + VmgSetOffsetValid (Ghcb, GhcbRdx);
> //
> // fall through
> //
> case 0x32: // RDMSR
> Ghcb->SaveArea.Rcx = Regs->Rcx;
> - GhcbSetRegValid (Ghcb, GhcbRcx);
> + VmgSetOffsetValid (Ghcb, GhcbRcx);
> break;
> default:
> return UnsupportedExit (Ghcb, Regs, InstructionData);
> @@ -1094,8 +1038,8 @@ MsrExit (
> }
>
> if (ExitInfo1 == 0) {
> - if (!GhcbIsRegValid (Ghcb, GhcbRax) ||
> - !GhcbIsRegValid (Ghcb, GhcbRdx)) {
> + if (!VmgIsOffsetValid (Ghcb, GhcbRax) ||
> + !VmgIsOffsetValid (Ghcb, GhcbRdx)) {
> return UnsupportedExit (Ghcb, Regs, InstructionData);
> }
> Regs->Rax = Ghcb->SaveArea.Rax;
> @@ -1311,7 +1255,7 @@ IoioExit (
> } else {
> CopyMem (&Ghcb->SaveArea.Rax, &Regs->Rax, IOIO_DATA_BYTES (ExitInfo1));
> }
> - GhcbSetRegValid (Ghcb, GhcbRax);
> + VmgSetOffsetValid (Ghcb, GhcbRax);
>
> Status = VmgExit (Ghcb, SVM_EXIT_IOIO_PROT, ExitInfo1, 0);
> if (Status != 0) {
> @@ -1319,7 +1263,7 @@ IoioExit (
> }
>
> if ((ExitInfo1 & IOIO_TYPE_IN) != 0) {
> - if (!GhcbIsRegValid (Ghcb, GhcbRax)) {
> + if (!VmgIsOffsetValid (Ghcb, GhcbRax)) {
> return UnsupportedExit (Ghcb, Regs, InstructionData);
> }
> CopyMem (&Regs->Rax, &Ghcb->SaveArea.Rax, IOIO_DATA_BYTES (ExitInfo1));
> @@ -1379,15 +1323,15 @@ CpuidExit (
> UINT64 Status;
>
> Ghcb->SaveArea.Rax = Regs->Rax;
> - GhcbSetRegValid (Ghcb, GhcbRax);
> + VmgSetOffsetValid (Ghcb, GhcbRax);
> Ghcb->SaveArea.Rcx = Regs->Rcx;
> - GhcbSetRegValid (Ghcb, GhcbRcx);
> + VmgSetOffsetValid (Ghcb, GhcbRcx);
> if (Regs->Rax == CPUID_EXTENDED_STATE) {
> IA32_CR4 Cr4;
>
> Cr4.UintN = AsmReadCr4 ();
> Ghcb->SaveArea.XCr0 = (Cr4.Bits.OSXSAVE == 1) ? AsmXGetBv (0) : 1;
> - GhcbSetRegValid (Ghcb, GhcbXCr0);
> + VmgSetOffsetValid (Ghcb, GhcbXCr0);
> }
>
> Status = VmgExit (Ghcb, SVM_EXIT_CPUID, 0, 0);
> @@ -1395,10 +1339,10 @@ CpuidExit (
> return Status;
> }
>
> - if (!GhcbIsRegValid (Ghcb, GhcbRax) ||
> - !GhcbIsRegValid (Ghcb, GhcbRbx) ||
> - !GhcbIsRegValid (Ghcb, GhcbRcx) ||
> - !GhcbIsRegValid (Ghcb, GhcbRdx)) {
> + if (!VmgIsOffsetValid (Ghcb, GhcbRax) ||
> + !VmgIsOffsetValid (Ghcb, GhcbRbx) ||
> + !VmgIsOffsetValid (Ghcb, GhcbRcx) ||
> + !VmgIsOffsetValid (Ghcb, GhcbRdx)) {
> return UnsupportedExit (Ghcb, Regs, InstructionData);
> }
> Regs->Rax = Ghcb->SaveArea.Rax;
> @@ -1434,15 +1378,15 @@ RdpmcExit (
> UINT64 Status;
>
> Ghcb->SaveArea.Rcx = Regs->Rcx;
> - GhcbSetRegValid (Ghcb, GhcbRcx);
> + VmgSetOffsetValid (Ghcb, GhcbRcx);
>
> Status = VmgExit (Ghcb, SVM_EXIT_RDPMC, 0, 0);
> if (Status != 0) {
> return Status;
> }
>
> - if (!GhcbIsRegValid (Ghcb, GhcbRax) ||
> - !GhcbIsRegValid (Ghcb, GhcbRdx)) {
> + if (!VmgIsOffsetValid (Ghcb, GhcbRax) ||
> + !VmgIsOffsetValid (Ghcb, GhcbRdx)) {
> return UnsupportedExit (Ghcb, Regs, InstructionData);
> }
> Regs->Rax = Ghcb->SaveArea.Rax;
> @@ -1480,8 +1424,8 @@ RdtscExit (
> return Status;
> }
>
> - if (!GhcbIsRegValid (Ghcb, GhcbRax) ||
> - !GhcbIsRegValid (Ghcb, GhcbRdx)) {
> + if (!VmgIsOffsetValid (Ghcb, GhcbRax) ||
> + !VmgIsOffsetValid (Ghcb, GhcbRdx)) {
> return UnsupportedExit (Ghcb, Regs, InstructionData);
> }
> Regs->Rax = Ghcb->SaveArea.Rax;
> @@ -1531,7 +1475,7 @@ Dr7WriteExit (
> // Using a value of 0 for ExitInfo1 means RAX holds the value
> //
> Ghcb->SaveArea.Rax = *Register;
> - GhcbSetRegValid (Ghcb, GhcbRax);
> + VmgSetOffsetValid (Ghcb, GhcbRax);
>
> Status = VmgExit (Ghcb, SVM_EXIT_DR7_WRITE, 0, 0);
> if (Status != 0) {
>
next prev parent reply other threads:[~2020-10-19 20:51 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-16 16:09 [PATCH v2 00/11] SEV-ES guest support fixes and cleanup Lendacky, Thomas
2020-10-16 16:09 ` [PATCH v2 01/11] MdePkg, OvmfPkg: Clean up GHCB field offsets and save area Lendacky, Thomas
2020-10-19 1:41 ` 回复: " gaoliming
2020-10-19 12:50 ` Lendacky, Thomas
2020-10-19 20:17 ` Laszlo Ersek
2020-10-19 20:48 ` Lendacky, Thomas
2020-10-19 20:42 ` Laszlo Ersek
2020-10-20 1:08 ` 回复: " gaoliming
2020-10-20 8:31 ` Laszlo Ersek
2020-10-20 13:10 ` Lendacky, Thomas
2020-10-21 0:54 ` 回复: " gaoliming
2020-10-21 21:54 ` Lendacky, Thomas
2020-10-22 1:25 ` 回复: [edk2-devel] " gaoliming
2020-10-22 13:12 ` Laszlo Ersek
2020-10-23 2:57 ` 回复: " gaoliming
2020-10-26 16:34 ` Lendacky, Thomas
2020-10-27 7:57 ` Dong, Eric
2020-10-28 17:42 ` Lendacky, Thomas
2020-10-21 12:29 ` Laszlo Ersek
2020-10-16 16:09 ` [PATCH v2 02/11] UefiCpuPkg/VmgExitLib: Add interfaces to set/read GHCB ValidBitmap bits Lendacky, Thomas
2020-10-19 20:46 ` [edk2-devel] " Laszlo Ersek
2020-10-16 16:09 ` [PATCH v2 03/11] OvmfPkg/VmgExitLib: Implement new VmgExitLib interfaces Lendacky, Thomas
2020-10-19 20:51 ` Laszlo Ersek [this message]
2020-10-16 16:09 ` [PATCH v2 04/11] OvmfPkg/VmgExitLib: Set the SW exit fields when performing VMGEXIT Lendacky, Thomas
2020-10-19 20:53 ` [edk2-devel] " Laszlo Ersek
2020-10-16 16:09 ` [PATCH v2 05/11] OvmfPkg/VmgExitLib: Set the SwScratch valid bit for IOIO events Lendacky, Thomas
2020-10-19 20:54 ` [edk2-devel] " Laszlo Ersek
2020-10-16 16:09 ` [PATCH v2 06/11] OvmfPkg/VmgExitLib: Set the SwScratch valid bit for MMIO events Lendacky, Thomas
2020-10-16 16:09 ` [PATCH v2 07/11] UefiCpuPkg/MpInitLib: Set the SW exit fields when performing VMGEXIT Lendacky, Thomas
2020-10-16 16:09 ` [PATCH v2 08/11] OvmfPkg/QemuFlashFvbServicesRuntimeDxe: Set the SwScratch valid bit Lendacky, Thomas
2020-10-19 20:57 ` [edk2-devel] " Laszlo Ersek
2020-10-16 16:09 ` [PATCH v2 09/11] OvmfPkg/QemuFlashFvbServicesRuntimeDxe: Fix erase blocks for SEV-ES Lendacky, Thomas
2020-10-16 16:09 ` [PATCH v2 10/11] UefiCpuPkg, OvmfPkg: Disable interrupts when using the GHCB Lendacky, Thomas
2020-10-19 21:07 ` [edk2-devel] " Laszlo Ersek
2020-10-16 16:09 ` [PATCH v2 11/11] UefiCpuPkg/MpInitLib: For SEV-ES guest, set stack based on processor number Lendacky, Thomas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b6c75b12-00c7-619e-8583-f63d0b70609a@redhat.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox