From: "Michael Brown" <mcb30@ipxe.org>
To: devel@edk2.groups.io, richardho@ami.com
Cc: "Andrew Fish" <afish@apple.com>,
"Leif Lindholm" <quic_llindhol@quicinc.com>,
"Michael D Kinney" <michael.d.kinney@intel.com>,
"Michael Kubacki" <michael.kubacki@microsoft.com>,
"Zhiguang Liu" <zhiguang.liu@intel.com>,
"Liming Gao" <gaoliming@byosoft.com.cn>,
"TonyLo [羅金松]" <TonyLo@ami.com>
Subject: Re: [edk2-devel] [PATCH 1/3] UsbNetworkPkg/UsbRndis: Add USB RNDIS devices support
Date: Fri, 2 Dec 2022 10:09:07 +0000 [thread overview]
Message-ID: <b720ec18-f55b-8a30-d7c7-287642453195@ipxe.org> (raw)
In-Reply-To: <20221003092643.4813-1-richardho@ami.com>
On 03/10/2022 10:26, RichardHo [何明忠] via groups.io wrote:
> diff --git a/UsbNetworkPkg/NetworkCommon/DriverBinding.h b/UsbNetworkPkg/NetworkCommon/DriverBinding.h
> new file mode 100644
> index 0000000000..29f1f967f5
> --- /dev/null
> +++ b/UsbNetworkPkg/NetworkCommon/DriverBinding.h
> +VOID
> +UndiApiEntry (
> + IN UINT64 Cdb
> + );
Needs an EFIAPI modifier, i.e.
VOID
EFIAPI
UndiApiEntry (
IN UINT64 Cdb
);
to avoid runtime failures when using a non-Microsoft compiler.
> diff --git a/UsbNetworkPkg/NetworkCommon/PxeFunction.c b/UsbNetworkPkg/NetworkCommon/PxeFunction.c
> new file mode 100644
> index 0000000000..f6505f7018
> --- /dev/null
> +++ b/UsbNetworkPkg/NetworkCommon/PxeFunction.c
> +/**
> + UNDI API table entry.
> +
> + @param[in] Cdb A pointer to the command descriptor block.
> +
> +**/
> +VOID
> +UndiApiEntry (
> + IN UINT64 Cdb
> + )
As above:
VOID
EFIAPI
UndiApiEntry (
IN UINT64 Cdb
)
Thanks,
Michael
next prev parent reply other threads:[~2022-12-02 10:09 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-03 9:26 [PATCH 1/3] UsbNetworkPkg/UsbRndis: Add USB RNDIS devices support RichardHo [何明忠]
2022-10-07 8:21 ` Chang, Abner
2022-10-13 5:48 ` RichardHo [何明忠]
2022-10-17 12:25 ` Nickle Wang
2022-12-01 15:46 ` [edk2-devel] " Rebecca Cran
2022-12-02 10:42 ` RichardHo [何明忠]
2022-12-02 10:09 ` Michael Brown [this message]
2022-12-02 10:42 ` RichardHo [何明忠]
2022-12-02 11:49 ` Chang, Abner
2022-12-02 23:27 ` Rebecca Cran
-- strict thread matches above, loose matches on Subject: below --
2022-12-08 3:44 RichardHo [何明忠]
2022-12-08 4:41 ` [edk2-devel] " Rebecca Cran
2022-12-08 4:57 ` Rebecca Cran
2022-12-12 5:48 ` RichardHo [何明忠]
2023-01-08 10:41 ` tinhnguyen
2023-01-09 23:50 ` Michael Brown
2023-01-12 8:36 ` RichardHo [何明忠]
2023-01-20 21:36 ` Rebecca Cran
2023-02-05 8:04 ` Tinh Nguyen
2023-02-05 10:26 ` Michael Brown
2023-01-10 5:07 ` Rebecca Cran
2023-01-11 7:34 ` tinhnguyen
2023-01-11 9:55 ` Michael Brown
2023-01-11 10:56 ` Tinh Nguyen
[not found] ` <53d2211e-d8ad-fafe-38ad-814ed77d19cf@ipxe.org>
2023-01-11 1:11 ` Michael Brown
2023-01-11 1:17 ` Michael Brown
2023-01-11 9:47 ` RichardHo [何明忠]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b720ec18-f55b-8a30-d7c7-287642453195@ipxe.org \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox