From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from blyat.fensystems.co.uk (blyat.fensystems.co.uk [54.246.183.96])
 by mx.groups.io with SMTP id smtpd.web11.71653.1669975752424542762
 for <devel@edk2.groups.io>;
 Fri, 02 Dec 2022 02:09:13 -0800
Authentication-Results: mx.groups.io;
 dkim=missing; spf=pass (domain: ipxe.org, ip: 54.246.183.96, mailfrom: mcb30@ipxe.org)
Received: from [IPV6:2a00:23c6:5486:8700:eaa7:4ea6:88e4:6f0e] (unknown [IPv6:2a00:23c6:5486:8700:eaa7:4ea6:88e4:6f0e])
	by blyat.fensystems.co.uk (Postfix) with ESMTPSA id 30E7144139;
	Fri,  2 Dec 2022 10:09:08 +0000 (UTC)
Message-ID: <b720ec18-f55b-8a30-d7c7-287642453195@ipxe.org>
Date: Fri, 2 Dec 2022 10:09:07 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.2
Subject: Re: [edk2-devel] [PATCH 1/3] UsbNetworkPkg/UsbRndis: Add USB RNDIS devices support
To: devel@edk2.groups.io, richardho@ami.com
Cc: Andrew Fish <afish@apple.com>, Leif Lindholm <quic_llindhol@quicinc.com>,
 Michael D Kinney <michael.d.kinney@intel.com>,
 Michael Kubacki <michael.kubacki@microsoft.com>,
 Zhiguang Liu <zhiguang.liu@intel.com>, Liming Gao
 <gaoliming@byosoft.com.cn>, =?UTF-8?B?VG9ueUxvIFvnvoXph5Hmnb5d?=
 <TonyLo@ami.com>
References: <20221003092643.4813-1-richardho@ami.com>
From: "Michael Brown" <mcb30@ipxe.org>
In-Reply-To: <20221003092643.4813-1-richardho@ami.com>
X-Spam-Status: No, score=-2.9 required=5.0 tests=ALL_TRUSTED,BAYES_00,
	URIBL_DBL_BLOCKED_OPENDNS,URIBL_ZEN_BLOCKED_OPENDNS autolearn=ham
	autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
	blyat.fensystems.co.uk
Content-Language: en-US
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: quoted-printable

On 03/10/2022 10:26, RichardHo [=E4=BD=95=E6=98=8E=E5=BF=A0] via groups.i=
o wrote:
> diff --git a/UsbNetworkPkg/NetworkCommon/DriverBinding.h b/UsbNetworkPk=
g/NetworkCommon/DriverBinding.h
> new file mode 100644
> index 0000000000..29f1f967f5
> --- /dev/null
> +++ b/UsbNetworkPkg/NetworkCommon/DriverBinding.h

> +VOID
> +UndiApiEntry (
> +  IN  UINT64  Cdb
> +  );

Needs an EFIAPI modifier, i.e.

VOID
EFIAPI
UndiApiEntry (
   IN  UINT64  Cdb
   );

to avoid runtime failures when using a non-Microsoft compiler.

> diff --git a/UsbNetworkPkg/NetworkCommon/PxeFunction.c b/UsbNetworkPkg/=
NetworkCommon/PxeFunction.c
> new file mode 100644
> index 0000000000..f6505f7018
> --- /dev/null
> +++ b/UsbNetworkPkg/NetworkCommon/PxeFunction.c
> +/**
> +  UNDI API table entry.
> +
> +  @param[in]  Cdb  A pointer to the command descriptor block.
> +
> +**/
> +VOID
> +UndiApiEntry (
> +  IN  UINT64  Cdb
> +  )

As above:

VOID
EFIAPI
UndiApiEntry (
   IN  UINT64  Cdb
   )

Thanks,

Michael