From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id BB6422007D1EB for ; Thu, 14 Sep 2017 14:46:53 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id AC6D3883C4; Thu, 14 Sep 2017 21:49:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com AC6D3883C4 Authentication-Results: ext-mx02.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx02.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=lersek@redhat.com Received: from lacos-laptop-7.usersys.redhat.com (ovpn-121-80.rdu2.redhat.com [10.10.121.80]) by smtp.corp.redhat.com (Postfix) with ESMTP id F33A45D753; Thu, 14 Sep 2017 21:49:50 +0000 (UTC) To: Brijesh Singh , edk2-devel@lists.01.org Cc: Jordan Justen , Tom Lendacky , Ard Biesheuvel References: <20170914212247.124937-1-brijesh.singh@amd.com> <20170914212247.124937-8-brijesh.singh@amd.com> From: Laszlo Ersek Message-ID: Date: Thu, 14 Sep 2017 23:49:49 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <20170914212247.124937-8-brijesh.singh@amd.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Thu, 14 Sep 2017 21:49:52 +0000 (UTC) Subject: Re: [PATCH v4 7/8] OvmfPkg/VirtioNetDxe: map caller-supplied Tx packet to device-address X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 Sep 2017 21:46:53 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 09/14/17 23:22, Brijesh Singh wrote: > When device is behind the IOMMU, driver is require to pass the device > address of caller-supplied transmit buffer for the bus master operations. > > The patch uses VirtioNetMapTxBuf() to map caller-supplied Tx packet to a > device-address and enqueue the device address in VRING for transfer and > perform the reverse mapping when transfer is completed so that we can > return the caller-supplied buffer. > > Cc: Ard Biesheuvel > Cc: Jordan Justen > Cc: Tom Lendacky > Cc: Laszlo Ersek > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Brijesh Singh > --- > OvmfPkg/VirtioNetDxe/SnpGetStatus.c | 35 ++++++++++++++++---- > OvmfPkg/VirtioNetDxe/SnpTransmit.c | 27 +++++++++++---- > 2 files changed, 49 insertions(+), 13 deletions(-) Reviewed-by: Laszlo Ersek I'll do some tests. Thanks Laszlo