From: "Laszlo Ersek" <lersek@redhat.com>
To: Leif Lindholm <leif.lindholm@linaro.org>, devel@edk2.groups.io
Cc: Andrew Fish <afish@apple.com>,
Michael D Kinney <michael.d.kinney@intel.com>,
Philippe Mathieu-Daude <philmd@redhat.com>,
Bob Feng <bob.c.feng@intel.com>,
Liming Gao <liming.gao@intel.com>
Subject: Re: [PATCH 3/3] BaseTools: add GetMaintainer.py script
Date: Sat, 13 Jul 2019 00:58:18 +0200 [thread overview]
Message-ID: <b740870c-5e2d-230b-89b8-ed5986e9fa79@redhat.com> (raw)
In-Reply-To: <20190712170128.6495-4-leif.lindholm@linaro.org>
On 07/12/19 19:01, Leif Lindholm wrote:
> Add a new script GetMaintainer.py that uses the new Maintainer.txt format
> to determine which addresses to cc on patch submission.
>
> Signed-off-by: Leif Lindholm <leif.lindholm@linaro.org>
> Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>
> Tested-by: Philippe Mathieu-Daude <philmd@redhat.com>
> ---
> BaseTools/Scripts/GetMaintainer.py | 190 +++++++++++++++++++++++++++++
> 1 file changed, 190 insertions(+)
> create mode 100644 BaseTools/Scripts/GetMaintainer.py
I should really re-review this from zero, but it's 0:55 AM again. :/
Anyway, I think this script is a good candidate for gradual improvements
(should such ever become necessary, that is). The script doesn't have to
be perfect to be incredibly useful.
Acked-by: Laszlo Ersek <lersek@redhat.com>
... Did you have me in mind for the ArmVirtPkg and OvmfPkg pathname
patterns, for replacing the natural language pointers? :)
Thanks!
Laszlo
next prev parent reply other threads:[~2019-07-12 22:58 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-12 17:01 [PATCH 0/3] add GetMaintainer.py helper script Leif Lindholm
2019-07-12 17:01 ` [PATCH 1/3] Maintainers.txt: update for filesystem area descriptions Leif Lindholm
2019-07-12 22:54 ` Laszlo Ersek
2019-07-12 17:01 ` [PATCH 2/3] Maintainers.txt: add wildcard path association for Arm/AArch64 Leif Lindholm
2019-07-12 22:54 ` Laszlo Ersek
2019-07-12 17:01 ` [PATCH 3/3] BaseTools: add GetMaintainer.py script Leif Lindholm
2019-07-12 22:58 ` Laszlo Ersek [this message]
2019-07-13 10:41 ` Leif Lindholm
2019-07-15 17:08 ` [edk2-devel] " Laszlo Ersek
2019-07-12 22:54 ` [PATCH 0/3] add GetMaintainer.py helper script Laszlo Ersek
2019-07-18 16:27 ` Leif Lindholm
2019-07-18 17:01 ` Philippe Mathieu-Daudé
2019-07-18 17:40 ` Leif Lindholm
2019-07-18 17:50 ` Philippe Mathieu-Daudé
2019-07-18 21:17 ` Laszlo Ersek
2019-07-18 21:56 ` Leif Lindholm
2019-07-24 1:39 ` Liming Gao
2019-07-19 9:00 ` [PATCH 0/3] add GetMaintainer.py helper script (and Maintainers.txt format change) Leif Lindholm
2019-07-24 2:03 ` [edk2-devel] " Bob Feng
2019-07-24 16:49 ` Leif Lindholm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b740870c-5e2d-230b-89b8-ed5986e9fa79@redhat.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox