From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: redhat.com, ip: 209.132.183.28, mailfrom: lersek@redhat.com) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by groups.io with SMTP; Fri, 12 Jul 2019 15:58:23 -0700 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 560AC3092652; Fri, 12 Jul 2019 22:58:23 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-116-65.ams2.redhat.com [10.36.116.65]) by smtp.corp.redhat.com (Postfix) with ESMTP id A61AE60BFB; Fri, 12 Jul 2019 22:58:19 +0000 (UTC) Subject: Re: [PATCH 3/3] BaseTools: add GetMaintainer.py script To: Leif Lindholm , devel@edk2.groups.io Cc: Andrew Fish , Michael D Kinney , Philippe Mathieu-Daude , Bob Feng , Liming Gao References: <20190712170128.6495-1-leif.lindholm@linaro.org> <20190712170128.6495-4-leif.lindholm@linaro.org> From: "Laszlo Ersek" Message-ID: Date: Sat, 13 Jul 2019 00:58:18 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20190712170128.6495-4-leif.lindholm@linaro.org> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.43]); Fri, 12 Jul 2019 22:58:23 +0000 (UTC) Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 07/12/19 19:01, Leif Lindholm wrote: > Add a new script GetMaintainer.py that uses the new Maintainer.txt format > to determine which addresses to cc on patch submission. > > Signed-off-by: Leif Lindholm > Reviewed-by: Philippe Mathieu-Daude > Tested-by: Philippe Mathieu-Daude > --- > BaseTools/Scripts/GetMaintainer.py | 190 +++++++++++++++++++++++++++++ > 1 file changed, 190 insertions(+) > create mode 100644 BaseTools/Scripts/GetMaintainer.py I should really re-review this from zero, but it's 0:55 AM again. :/ Anyway, I think this script is a good candidate for gradual improvements (should such ever become necessary, that is). The script doesn't have to be perfect to be incredibly useful. Acked-by: Laszlo Ersek ... Did you have me in mind for the ArmVirtPkg and OvmfPkg pathname patterns, for replacing the natural language pointers? :) Thanks! Laszlo