From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR03-AM5-obe.outbound.protection.outlook.com (EUR03-AM5-obe.outbound.protection.outlook.com [40.107.3.61]) by mx.groups.io with SMTP id smtpd.web12.14054.1639069265948357883 for ; Thu, 09 Dec 2021 09:01:07 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=DhWIZ/HD; spf=pass (domain: arm.com, ip: 40.107.3.61, mailfrom: sami.mujawar@arm.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OnqdguifYsqGuipcniJEkTDFSTUCU4Eo6MGKpwil+F8=; b=DhWIZ/HDfgBXPy3Kld62xWZX1gdMeQqyJLIvm7MAhRYNEELpZmam2tA2SstGCmqaNXKhHsai3FZA4cApIWmvKlCf8vg6RqoffGSX29cDRt5oS6iUbijWdQqvVpUPD0W/3dstEhRWDY7VX871nHTpRWx50QFjVS7Vgj1S5C++CvM= Received: from AM5PR0602CA0009.eurprd06.prod.outlook.com (2603:10a6:203:a3::19) by DB7PR08MB3162.eurprd08.prod.outlook.com (2603:10a6:5:23::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.19; Thu, 9 Dec 2021 17:00:59 +0000 Received: from AM5EUR03FT039.eop-EUR03.prod.protection.outlook.com (2603:10a6:203:a3:cafe::c3) by AM5PR0602CA0009.outlook.office365.com (2603:10a6:203:a3::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.11 via Frontend Transport; Thu, 9 Dec 2021 17:00:59 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT039.mail.protection.outlook.com (10.152.17.185) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.12 via Frontend Transport; Thu, 9 Dec 2021 17:00:57 +0000 Received: ("Tessian outbound a33f292be81b:v110"); Thu, 09 Dec 2021 17:00:57 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 9da36b7c0dcf912f X-CR-MTA-TID: 64aa7808 Received: from 562f779693d6.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 60867FDE-5844-42EC-ADF5-43187C7F35A8.1; Thu, 09 Dec 2021 17:00:40 +0000 Received: from EUR01-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 562f779693d6.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 09 Dec 2021 17:00:40 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WM1sZH+MieidfvgOK3VykgtFkhqaD52j2yS1wDF3ohOAl/EwlF/Nzgsp6hX6hxE4m9TOTXQZ7UioASYR4FNhZFy/uHLLDHgbMrWLa6E1GOUmcYvRHS3X34zliC1zX8aGtyN3qSME5C0j4vxq/sExFReq0IxfTU9MgHjIs77s6uodtmcnnvV1zbcz7RTN40I8jbokgHw3NIVBdCt0g3yY9djI/PTw4bJdxYPsTIjUSN944yuNxt+j7CzNkhqqWLxeFoocsqVwSBOl81B/zxQ5ngDzGqgVyXYapo6HpfUNLUFLVf7hPxthHgap6/XvUY+Kf2xDmAGpFgt02v94QbA3/A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=OnqdguifYsqGuipcniJEkTDFSTUCU4Eo6MGKpwil+F8=; b=QlpjtvgfpZGt11o7ueAq/tJrP639Rku2eTQ3Ld2tF436e3ZsNsbBn4hRH+rOj5pjS+4wSxq61liPZBJppSPLe3QUs7wlEeQuPdjUirBHaoNpvOEyqF3NP/tKfbhS8NVdmuW0LxqDh2KCykpolvVBqHlQKT9OKq/wYNbHbuYL5RmU1HLAkRFprmcxworyJRCOE6AdknH24WjIICTqfg4CGsuJKKsViG7iHXZ0RkXei3c1WG8mdKFnHB4GNGXMy8BbF5bXIDrPQ7HUXbqg9I2x0XfVmgaf3TAtQm26BhDOpykcu2fygbFZ9gPKOJ/Qpz1TaBkizB9vNKKGa9Di5Cp5Ow== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OnqdguifYsqGuipcniJEkTDFSTUCU4Eo6MGKpwil+F8=; b=DhWIZ/HDfgBXPy3Kld62xWZX1gdMeQqyJLIvm7MAhRYNEELpZmam2tA2SstGCmqaNXKhHsai3FZA4cApIWmvKlCf8vg6RqoffGSX29cDRt5oS6iUbijWdQqvVpUPD0W/3dstEhRWDY7VX871nHTpRWx50QFjVS7Vgj1S5C++CvM= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) by AM6PR08MB4721.eurprd08.prod.outlook.com (2603:10a6:20b:c7::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.22; Thu, 9 Dec 2021 17:00:38 +0000 Received: from AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::bdcf:cfa6:b2bb:38ac]) by AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::bdcf:cfa6:b2bb:38ac%6]) with mapi id 15.20.4755.021; Thu, 9 Dec 2021 17:00:38 +0000 Subject: Re: [PATCH v3 0/7] Support ACPI 6.4 PPTT changes To: Chris Jones , devel@edk2.groups.io Cc: michael.d.kinney@intel.com, gaoliming@byosoft.com.cn, zhiguang.liu@intel.com, ray.ni@intel.com, zhichao.gao@intel.com, Alexei.Fedorov@arm.com, nd@arm.com References: <20211208160630.10923-1-christopher.jones@arm.com> From: "Sami Mujawar" Message-ID: Date: Thu, 9 Dec 2021 17:00:42 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.0.1 In-Reply-To: <20211208160630.10923-1-christopher.jones@arm.com> X-ClientProxiedBy: LO4P123CA0006.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:150::11) To AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) MIME-Version: 1.0 Received: from [10.1.196.43] (217.140.106.50) by LO4P123CA0006.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:150::11) with Microsoft SMTP Server (version=TLS1_2, cipher=) via Frontend Transport; Thu, 9 Dec 2021 17:00:37 +0000 X-MS-Office365-Filtering-Correlation-Id: 39482cdb-1d63-4b52-89de-08d9bb357889 X-MS-TrafficTypeDiagnostic: AM6PR08MB4721:EE_|AM5EUR03FT039:EE_|DB7PR08MB3162:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:6430;OLM:6430; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: b7h5jbVR0iKNtHVttXMp31lmMQwDvak4L8km/0NngFpkfPIHAlESWTx18Rm4cVrYHiuP3uUBkzZbTtLH+guUHNFr3VoGvAmxiXxVUxRrk/PwcIsHfgl7xSEalI1XVGaIKByD542vSMtuTXkoGayQ9etEC92lMOuFpXoyqHYmElmL7xPAr/jsXBf0SP9n0gMxX0W0inIebfmSEuh1bxDf5CVNYhcWytN4IdrhqF8N8mWQi9q8RWvD2eeZyDYWNuZQq5N7p6vkimUUv7f6GGLqsgYod6PPgQIQkCDpATjNgXqRO6G/D5tYy5ozQtwyaFXV2A0J9qm6PmyB0EMDGrvTT74Vg5oUyCdKxI0Wr180jlpQZVflrbxM4o26vCpp3y+1bQx2bRwCTEHFLPP7e5IBuEDBgrUCWV6W7XaUy3tZmWGSzElzQQ3jwVlMF/CZQTyzLvKL5Aqi4uIvDC/AknmqIC0rDFAS+b+ORALX7B0vd+2jANlYhkpFWsG3cRri8WefNOK+Lf+YXDyzoldXYITDaIphNEwZMdX8HjsQNq047LzGwEdbWP00Gb+mFbPtbSK9ubmpZLJGOA3ib6OJOztht5DkRAAsp60arXfUeJlmv9c12/ztb7U+5UqIm+gudPKXlwcOLEKg95ExjnXoGhmcBjuX8gR/l4lRVaFBi/bGzOKzAATI3QhmTBES1qX1c+XBBwmLlSqVU2Qtg5ipf/CFq2E+nuKL2aveaUJZqzjt6YcsCZIgPJaDkC0dV+py3+WaEXzFixNbXrXkl9KzAiYlNLaPpz6CpHwAJdA3yZ559wHSBPH23wcFv3toNSDp4BxgFZm4fKIKCv+N8IyuW7B8VzdSEWxqSARP0mTVvVdgtlHBnioA5hH5UWwnvwF+EZQhIVv76dtTxi7yVIDc+U9cTg== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB6806.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(31696002)(16576012)(53546011)(83380400001)(8676002)(8936002)(316002)(36756003)(508600001)(38100700002)(38350700002)(44832011)(19627235002)(5660300002)(966005)(66946007)(2616005)(66476007)(66556008)(186003)(86362001)(956004)(4326008)(6486002)(6666004)(2906002)(26005)(31686004)(52116002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB4721 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Return-Path: Sami.Mujawar@arm.com X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT039.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: e7087f75-45ad-4bf6-9ea0-08d9bb356c53 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: fDn1M8750jFVvhGgSr2sHHh0QLFOT0D4jl6ZQihLyHGaS05yYFuy7EZ/mz2DGZKyQY4xM4q3GTSSZ4EPBMRKrtDGzlUxFQsPALBTmuzqAvizQKBaF3elfEo6madVvxKKT7MjuzWuSWnrTxKS5ghe2xUZxJuYWGXRwOHEEw9Gk+WOilCeZliR9UhNsu6XbwyzlCuMg8bdlSvccDIooZsw/gMvZu84ZS/Vj3WU1/ZuSPqon+dRyF+onc8nDIjVhJcdKQi4fJm6yKXX0wmK8YaB9R4e+K0bCAWiVWfVTXxMgYJ0yAk9Z2oJyY9/gItTrkLZanlIzslDfE52DWWs5YpxK6OAenjO/GvOve2Y7g4DH581XZCFtY5DqL7rh/7e1g9vQuxebv7djb+T3FSN5tyuuURcQDCbuNGCWsBhaxuULpaodCZS993BYuTipzg1VXCBPNdbIKtsAttqhz8MK7k0iPhO1xlvMjxb0E3f72eGvDjizE/jIUOwnIeKeet5GcmgnWJKQiZyrAJ51VHpjlVSFM443aEage1Gem3oRZD2+lH3muPRMcU0O+ReFRGduAclWlNS0w0dSP8gDwHDmMnZYbASfcRHCDGQo2DAsLWNchTV4UEfKPUr7LSz+v2pidqmawrq2nlIcqt3L5CD8ObrnF3nmHHQJO5h6iTAYBcETYEaYPhww9CVFf5yXUPd3YjmyAtEGeSdXt4IIrZNznjkE+9rtJ3wltzD0b02VfgCdDhsofKsF4KHYTUzx+iSAa8lc1hSE4U8V+4bYsFa1eXvoBwR1qpwhMR0rqsXJSPb14dAhzicZ7p41dS7OyynI2BoLbAL4bIHEY0edb5v43o1Xt5BeTocaZdaM5cX4Rzq/B2YZK0IZ7MQyAgOv0U0WnwUo6JZ8nRnWUdYSBbNKXwSvzkBFMZbTHweXk26L0v7nbk= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(36840700001)(46966006)(40470700001)(2616005)(316002)(70206006)(5660300002)(966005)(956004)(2906002)(6486002)(44832011)(16576012)(26005)(336012)(508600001)(19627235002)(6666004)(8676002)(186003)(8936002)(70586007)(4326008)(47076005)(53546011)(82310400004)(81166007)(86362001)(36860700001)(31686004)(36756003)(40460700001)(356005)(31696002)(83380400001)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Dec 2021 17:00:57.8951 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 39482cdb-1d63-4b52-89de-08d9bb357889 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT039.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR08MB3162 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-GB Hi Chris, Thank you for this patch series. Other than my feedback for optimisation in patch 7/7 (which I will address before merging), this patch series looks good to me. For this series, Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 08/12/2021 04:06 PM, Chris Jones wrote: > Bugzilla: 3697 (https://bugzilla.tianocore.org/show_bug.cgi?id=3697) > > This patch series updates the Acpiview PPTT parser and DynamicTablesPkg > PPTT generator to support ACPI 6.4. This consists of two main changes: > - The addition of the 'Cache ID' field. > - The removal of the PPTT ID (type 2) structure. > > In addition add two 'Cache ID' defines and remove the type 2 PPTT > structure from Acpi64.h as these changes were missing when Acpi64.h was > introduced. > > Changes since v2: > 1. Added mantis ID for PPTT type 2 structure removal on relevant commit > messages. No change to code. > 2. Applied uncrustify to all patches. No other changes to code. > > Changes since v1: > 1. Patch 3/7 ShellPkg: > - Changed PPTT ID error message to say "removed" instead of "deprecated". > 2. Patch 4/7 ShellPkg: > - Fixed a bug where 'CacheFlags' and 'CacheId' were only set after the > validation function had finished. Instead set them inside the > validation function using the first 'Ptr' parameter. > 3. Patch 7/7 DynamicTablesPkg: > - Make IsCacheIdUnique() return BOOLEAN instead of EFI_STATUS. > - Added a missing space to the definition of 'IsCacheIdUnique'. > > The changes can be seen at: https://github.com/chris-jones-arm/edk2/tree/1632_64_acpi_cache_id_v3 > > > Chris Jones (7): > MdePkg: Add missing Cache ID (in)valid define > MdePkg: Remove PPTT ID type structure > ShellPkg: Update Acpiview PPTT parser to ACPI 6.4 > ShellPkg: Add Cache ID to PPTT parser > DynamicTablesPkg: Remove PPTT ID structure from ACPI 6.4 generator > DynamicTablesPkg: Update PPTT generator to ACPI 6.4 > DynamicTablesPkg: Add CacheId to PPTT generator > > .../Include/ArmNameSpaceObjects.h | 27 +- > .../Acpi/Arm/AcpiPpttLibArm/PpttGenerator.c | 296 +++++++----------- > .../Acpi/Arm/AcpiPpttLibArm/PpttGenerator.h | 4 - > MdePkg/Include/IndustryStandard/Acpi64.h | 18 +- > .../Parsers/Pptt/PpttParser.c | 214 +++++++++---- > .../UefiShellAcpiViewCommandLib.c | 2 +- > 6 files changed, 272 insertions(+), 289 deletions(-) >