From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 124DA940E8C for ; Fri, 22 Mar 2024 01:11:14 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=0B1f7WD3rLTD1muwu9c0CzR316M99Q9pbI7AClhIijQ=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:User-Agent:Subject:From:To:Cc:Reply-To:References:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:List-Unsubscribe-Post:List-Unsubscribe:Content-Type; s=20240206; t=1711069873; v=1; b=q8wq1CPgiB+t9dfG7KqMLAjXrTWCGPUpvOQOUvd/IEP4q1jOxuLSY/RT/KIgDHHvDm8ike17 QLXXn5GkynOF10NnbkXZHZm7JOmOPe8zFlFShrl76NS5DloQ81igTnsGq1VmfKj+WnQwRQgrWVJ tucjBrFvLn0PDgoy1ROOZsLbffygTpWkMGUjGMGjWaA3eC4iGJKA+KqTDEeWL9QfpfZye9gnnIi zEe2llDFK42s1oqFjr+N2C/1GGhMeTSPBNH8FkR9zkZ8NqHbQnSqndYjIxFcclXhqIJ45LidMzX 1/Mikn5+SYgr7Eh69CbGACfoeDTWqS0dspHvukiRQukaw== X-Received: by 127.0.0.2 with SMTP id oQVyYY7687511xz8ZsPhLMyG; Thu, 21 Mar 2024 18:11:13 -0700 X-Received: from mail.loongson.cn (mail.loongson.cn [114.242.206.163]) by mx.groups.io with SMTP id smtpd.web10.2783.1711069871687556799 for ; Thu, 21 Mar 2024 18:11:12 -0700 X-Received: from loongson.cn (unknown [10.40.24.149]) by gateway (Coremail) with SMTP id _____8Ax++im2vxlDjccAA--.47341S3; Fri, 22 Mar 2024 09:11:02 +0800 (CST) X-Received: from [10.40.24.149] (unknown [10.40.24.149]) by localhost.localdomain (Coremail) with SMTP id AQAAf8DxDc+e2vxlTilhAA--.58501S3; Fri, 22 Mar 2024 09:10:54 +0800 (CST) Message-ID: Date: Fri, 22 Mar 2024 09:10:54 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] [PATCH v2 00/13] Part 2 patch set to add LoongArch support into UefiCpuPkg From: "Chao Li" To: devel@edk2.groups.io Cc: Rahul Kumar , Gerd Hoffmann , Sami Mujawar , Sunil V L , Bibo Mao , Dongyan Qian Reply-To: devel@edk2.groups.io,lichao@loongson.cn References: <17BE6C7171CBC84C.24580@groups.io> In-Reply-To: <17BE6C7171CBC84C.24580@groups.io> X-CM-TRANSID: AQAAf8DxDc+e2vxlTilhAA--.58501S3 X-CM-SenderInfo: xolfxt3r6o00pqjv00gofq/1tbiAQAECGX77+gHUwABsB X-Coremail-Antispam: 1Uk129KBjDUn29KB7ZKAUJUUUUU529EdanIXcx71UUUUU7KY7 ZEXasCq-sGcSsGvfJ3UbIjqfuFe4nvWSU5nxnvy29KBjDU0xBIdaVrnUUvcSsGvfC2Kfnx nUUI43ZEXa7xR_UUUUUUUUU== Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Thu, 21 Mar 2024 18:11:12 -0700 List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: NgSUB6OqC6k5mCJEnZQWqYeax7686176AA= Content-Type: multipart/alternative; boundary="------------8huCOUwa7wRibZwtaXu1yxBD" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=q8wq1CPg; dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io --------------8huCOUwa7wRibZwtaXu1yxBD Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable Hi Ray and other maintainers, I submitted this series few days ago, could you review them and give me=20 the R-B? Thanks, Chao On 2024/3/20 16:41, Chao Li wrote: > This patch set adjusted some order in UefiCpuPig alphabetically, added > LoongArch libraries and drivers into UefiCpuPkg, it is a continuation of > the first patch series v8 submitted at > https://edk2.groups.io/g/devel/message/114526. > > And also separated fromhttps://edk2.groups.io/g/devel/message/116583. > > This series only contents the changes for UefiCpuPkg. > > Patch1-Patch4: Reorder some INF files located in UefiCpuPkg > alphabetically. > > Patch5-Patch13: Added Timer, CpuMmuLib, CpuMmuInitLib, MpInitLib, CpuDxe > for LoongArch, and added some PCD and header files requested by the > above libraries and drivers. > > Modfied modules: UefiCpuPkg > > BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=3D4726 > BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=3D4734 > > PR:https://github.com/tianocore/edk2/pull/5483 > > V1 -> V2: > 1. Removed PcdCpuMmuIsEnabled. > 2. Removed API GetMemoryRegionAttributes API as it is no longer needed. > 3. Patch3, added two empty line in DXE and PEI INF files. > 4. Patch5, added the Status check in GetTimeInnanoSecond function. > 5. Separated into two series, this is series one, and the second one is > OvmfPkg. > > Cc: Ray Ni > Cc: Rahul Kumar > Cc: Gerd Hoffmann > Cc: Sami Mujawar > Cc: Sunil V L > Cc: Bibo Mao > Cc: Dongyan Qian > > Chao Li (13): > UefiCpuPkg/CpuTimerLib: Reorder the INF file alphabetically > UefiCpuPkg/CpuExceptionHandlerLib: Reorder the INF files > alphabetically > UefiCpuPkg/MpInitLib: Reorder the INF files alphabetically > UefiCpuPkg/CpuDxe: Reorder the INF file alphabetically > UefiCpuPkg: Add LoongArch64 CPU Timer instance > UefiCpuPkg: Add CPU exception library for LoongArch > UefiCpuPkg: Add CpuMmuLib.h to UefiCpuPkg > UefiCpuPkg: Added a new PCD named PcdCpuExceptionVectorBaseAddress > UefiCpuPkg: Add CpuMmuLib to UefiCpuPkg > UefiCpuPkg: Add CpuMmuInitLib.h to UefiCpuPkg > UefiCpuPkg: Add CpuMmuInitLib to UefiCpuPkg > UefiCpuPkg: Add multiprocessor library for LoongArch64 > UefiCpuPkg: Add CpuDxe driver for LoongArch64 > > UefiCpuPkg/CpuDxe/CpuDxe.inf | 37 +- > UefiCpuPkg/CpuDxe/LoongArch64/CpuDxe.c | 426 +++++ > UefiCpuPkg/CpuDxe/LoongArch64/CpuDxe.h | 288 +++ > UefiCpuPkg/CpuDxe/LoongArch64/CpuMp.c | 544 ++++++ > UefiCpuPkg/CpuDxe/LoongArch64/Exception.c | 159 ++ > UefiCpuPkg/Include/Library/CpuMmuInitLib.h | 34 + > UefiCpuPkg/Include/Library/CpuMmuLib.h | 55 + > .../DxeCpuExceptionHandlerLib.inf | 37 +- > .../LoongArch/DxeExceptionLib.c | 198 ++ > .../LoongArch/ExceptionCommon.c | 171 ++ > .../LoongArch/ExceptionCommon.h | 131 ++ > .../LoongArch64/ArchExceptionHandler.c | 268 +++ > .../LoongArch64/ExceptionHandlerAsm.S | 366 ++++ > .../LoongArch/SecPeiExceptionLib.c | 102 ++ > .../PeiCpuExceptionHandlerLib.inf | 16 +- > .../SecPeiCpuExceptionHandlerLib.inf | 31 +- > .../SmmCpuExceptionHandlerLib.inf | 16 +- > .../Library/CpuMmuInitLib/CpuMmuInitLib.inf | 41 + > .../Library/CpuMmuInitLib/CpuMmuInitLib.uni | 14 + > .../CpuMmuInitLib/LoongArch64/CpuMmuInit.c | 232 +++ > .../LoongArch64/TlbExceptionHandle.S | 51 + > .../LoongArch64/TlbExceptionHandle.h | 36 + > UefiCpuPkg/Library/CpuMmuLib/CpuMmuLib.inf | 35 + > UefiCpuPkg/Library/CpuMmuLib/CpuMmuLib.uni | 14 + > .../Library/CpuMmuLib/LoongArch64/CpuMmu.c | 638 +++++++ > .../Library/CpuMmuLib/LoongArch64/Page.h | 24 + > .../CpuMmuLib/LoongArch64/TlbInvalid.S | 24 + > .../CpuMmuLib/LoongArch64/TlbInvalid.h | 24 + > .../Library/CpuTimerLib/BaseCpuTimerLib.inf | 17 +- > .../CpuTimerLib/LoongArch64/CpuTimerLib.c | 250 +++ > UefiCpuPkg/Library/MpInitLib/DxeMpInitLib.inf | 39 +- > .../Library/MpInitLib/LoongArch64/DxeMpLib.c | 480 +++++ > .../Library/MpInitLib/LoongArch64/MpLib.c | 1621 +++++++++++++++++ > .../Library/MpInitLib/LoongArch64/MpLib.h | 361 ++++ > .../Library/MpInitLib/LoongArch64/PeiMpLib.c | 404 ++++ > UefiCpuPkg/Library/MpInitLib/PeiMpInitLib.inf | 37 +- > UefiCpuPkg/UefiCpuPkg.dec | 12 + > UefiCpuPkg/UefiCpuPkg.dsc | 7 + > 38 files changed, 7161 insertions(+), 79 deletions(-) > create mode 100644 UefiCpuPkg/CpuDxe/LoongArch64/CpuDxe.c > create mode 100644 UefiCpuPkg/CpuDxe/LoongArch64/CpuDxe.h > create mode 100644 UefiCpuPkg/CpuDxe/LoongArch64/CpuMp.c > create mode 100644 UefiCpuPkg/CpuDxe/LoongArch64/Exception.c > create mode 100644 UefiCpuPkg/Include/Library/CpuMmuInitLib.h > create mode 100644 UefiCpuPkg/Include/Library/CpuMmuLib.h > create mode 100644 UefiCpuPkg/Library/CpuExceptionHandlerLib/LoongArch/= DxeExceptionLib.c > create mode 100644 UefiCpuPkg/Library/CpuExceptionHandlerLib/LoongArch/= ExceptionCommon.c > create mode 100644 UefiCpuPkg/Library/CpuExceptionHandlerLib/LoongArch/= ExceptionCommon.h > create mode 100644 UefiCpuPkg/Library/CpuExceptionHandlerLib/LoongArch/= LoongArch64/ArchExceptionHandler.c > create mode 100644 UefiCpuPkg/Library/CpuExceptionHandlerLib/LoongArch/= LoongArch64/ExceptionHandlerAsm.S > create mode 100644 UefiCpuPkg/Library/CpuExceptionHandlerLib/LoongArch/= SecPeiExceptionLib.c > create mode 100644 UefiCpuPkg/Library/CpuMmuInitLib/CpuMmuInitLib.inf > create mode 100644 UefiCpuPkg/Library/CpuMmuInitLib/CpuMmuInitLib.uni > create mode 100644 UefiCpuPkg/Library/CpuMmuInitLib/LoongArch64/CpuMmuI= nit.c > create mode 100644 UefiCpuPkg/Library/CpuMmuInitLib/LoongArch64/TlbExce= ptionHandle.S > create mode 100644 UefiCpuPkg/Library/CpuMmuInitLib/LoongArch64/TlbExce= ptionHandle.h > create mode 100644 UefiCpuPkg/Library/CpuMmuLib/CpuMmuLib.inf > create mode 100644 UefiCpuPkg/Library/CpuMmuLib/CpuMmuLib.uni > create mode 100644 UefiCpuPkg/Library/CpuMmuLib/LoongArch64/CpuMmu.c > create mode 100644 UefiCpuPkg/Library/CpuMmuLib/LoongArch64/Page.h > create mode 100644 UefiCpuPkg/Library/CpuMmuLib/LoongArch64/TlbInvalid.= S > create mode 100644 UefiCpuPkg/Library/CpuMmuLib/LoongArch64/TlbInvalid.= h > create mode 100644 UefiCpuPkg/Library/CpuTimerLib/LoongArch64/CpuTimerL= ib.c > create mode 100644 UefiCpuPkg/Library/MpInitLib/LoongArch64/DxeMpLib.c > create mode 100644 UefiCpuPkg/Library/MpInitLib/LoongArch64/MpLib.c > create mode 100644 UefiCpuPkg/Library/MpInitLib/LoongArch64/MpLib.h > create mode 100644 UefiCpuPkg/Library/MpInitLib/LoongArch64/PeiMpLib.c > -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#117018): https://edk2.groups.io/g/devel/message/117018 Mute This Topic: https://groups.io/mt/105041080/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- --------------8huCOUwa7wRibZwtaXu1yxBD Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable

Hi Ray and other maintainers,

I submitted this series few days ago, could you review them and give me the R-B?


=
Thanks,
Chao
On 2024/3/20 16:41, Chao Li wrote:
This patch set adjusted some o=
rder in UefiCpuPig alphabetically, added
LoongArch libraries and drivers into UefiCpuPkg, it is a continuation of
the first patch series v8 submitted at
https://edk2.groups.io/g/devel/message/114526.

And also separated from https://edk2.groups.io/g/devel/messa=
ge/116583.

This series only contents the changes for UefiCpuPkg.

Patch1-Patch4: Reorder some INF files located in UefiCpuPkg
alphabetically.

Patch5-Patch13: Added Timer, CpuMmuLib, CpuMmuInitLib, MpInitLib, CpuDxe
for LoongArch, and added some PCD and header files requested by the
above libraries and drivers.

Modfied modules: UefiCpuPkg

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=
=3D4726
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=
=3D4734

PR: https://github.com/tianocore/edk2/pull/5483

V1 -> V2:
1. Removed PcdCpuMmuIsEnabled.
2. Removed API GetMemoryRegionAttributes API as it is no longer needed.
3. Patch3, added two empty line in DXE and PEI INF files.
4. Patch5, added the Status check in GetTimeInnanoSecond function.
5. Separated into two series, this is series one, and the second one is
OvmfPkg.

Cc: Ray Ni <ray.ni@intel.com>
Cc: Rahul Kumar <rahul1.kumar@intel.com>
Cc: Gerd Hoffmann <kraxel@redhat.com>
Cc: Sami Mujawar <sami.mujawar@arm.com>
Cc: Sunil V L <sunilvl@ventanamicro.com>
Cc: Bibo Mao <maobibo@loongson.cn>
Cc: Dongyan Qian <qiandongyan@loongson.cn>

Chao Li (13):
  UefiCpuPkg/CpuTimerLib: Reorder the INF file alphabetically
  UefiCpuPkg/CpuExceptionHandlerLib: Reorder the INF files
    alphabetically
  UefiCpuPkg/MpInitLib: Reorder the INF files alphabetically
  UefiCpuPkg/CpuDxe: Reorder the INF file alphabetically
  UefiCpuPkg: Add LoongArch64 CPU Timer instance
  UefiCpuPkg: Add CPU exception library for LoongArch
  UefiCpuPkg: Add CpuMmuLib.h to UefiCpuPkg
  UefiCpuPkg: Added a new PCD named PcdCpuExceptionVectorBaseAddress
  UefiCpuPkg: Add CpuMmuLib to UefiCpuPkg
  UefiCpuPkg: Add CpuMmuInitLib.h to UefiCpuPkg
  UefiCpuPkg: Add CpuMmuInitLib to UefiCpuPkg
  UefiCpuPkg: Add multiprocessor library for LoongArch64
  UefiCpuPkg: Add CpuDxe driver for LoongArch64

 UefiCpuPkg/CpuDxe/CpuDxe.inf                  |   37 +-
 UefiCpuPkg/CpuDxe/LoongArch64/CpuDxe.c        |  426 +++++
 UefiCpuPkg/CpuDxe/LoongArch64/CpuDxe.h        |  288 +++
 UefiCpuPkg/CpuDxe/LoongArch64/CpuMp.c         |  544 ++++++
 UefiCpuPkg/CpuDxe/LoongArch64/Exception.c     |  159 ++
 UefiCpuPkg/Include/Library/CpuMmuInitLib.h    |   34 +
 UefiCpuPkg/Include/Library/CpuMmuLib.h        |   55 +
 .../DxeCpuExceptionHandlerLib.inf             |   37 +-
 .../LoongArch/DxeExceptionLib.c               |  198 ++
 .../LoongArch/ExceptionCommon.c               |  171 ++
 .../LoongArch/ExceptionCommon.h               |  131 ++
 .../LoongArch64/ArchExceptionHandler.c        |  268 +++
 .../LoongArch64/ExceptionHandlerAsm.S         |  366 ++++
 .../LoongArch/SecPeiExceptionLib.c            |  102 ++
 .../PeiCpuExceptionHandlerLib.inf             |   16 +-
 .../SecPeiCpuExceptionHandlerLib.inf          |   31 +-
 .../SmmCpuExceptionHandlerLib.inf             |   16 +-
 .../Library/CpuMmuInitLib/CpuMmuInitLib.inf   |   41 +
 .../Library/CpuMmuInitLib/CpuMmuInitLib.uni   |   14 +
 .../CpuMmuInitLib/LoongArch64/CpuMmuInit.c    |  232 +++
 .../LoongArch64/TlbExceptionHandle.S          |   51 +
 .../LoongArch64/TlbExceptionHandle.h          |   36 +
 UefiCpuPkg/Library/CpuMmuLib/CpuMmuLib.inf    |   35 +
 UefiCpuPkg/Library/CpuMmuLib/CpuMmuLib.uni    |   14 +
 .../Library/CpuMmuLib/LoongArch64/CpuMmu.c    |  638 +++++++
 .../Library/CpuMmuLib/LoongArch64/Page.h      |   24 +
 .../CpuMmuLib/LoongArch64/TlbInvalid.S        |   24 +
 .../CpuMmuLib/LoongArch64/TlbInvalid.h        |   24 +
 .../Library/CpuTimerLib/BaseCpuTimerLib.inf   |   17 +-
 .../CpuTimerLib/LoongArch64/CpuTimerLib.c     |  250 +++
 UefiCpuPkg/Library/MpInitLib/DxeMpInitLib.inf |   39 +-
 .../Library/MpInitLib/LoongArch64/DxeMpLib.c  |  480 +++++
 .../Library/MpInitLib/LoongArch64/MpLib.c     | 1621 +++++++++++++++++
 .../Library/MpInitLib/LoongArch64/MpLib.h     |  361 ++++
 .../Library/MpInitLib/LoongArch64/PeiMpLib.c  |  404 ++++
 UefiCpuPkg/Library/MpInitLib/PeiMpInitLib.inf |   37 +-
 UefiCpuPkg/UefiCpuPkg.dec                     |   12 +
 UefiCpuPkg/UefiCpuPkg.dsc                     |    7 +
 38 files changed, 7161 insertions(+), 79 deletions(-)
 create mode 100644 UefiCpuPkg/CpuDxe/LoongArch64/CpuDxe.c
 create mode 100644 UefiCpuPkg/CpuDxe/LoongArch64/CpuDxe.h
 create mode 100644 UefiCpuPkg/CpuDxe/LoongArch64/CpuMp.c
 create mode 100644 UefiCpuPkg/CpuDxe/LoongArch64/Exception.c
 create mode 100644 UefiCpuPkg/Include/Library/CpuMmuInitLib.h
 create mode 100644 UefiCpuPkg/Include/Library/CpuMmuLib.h
 create mode 100644 UefiCpuPkg/Library/CpuExceptionHandlerLib/LoongArch/Dxe=
ExceptionLib.c
 create mode 100644 UefiCpuPkg/Library/CpuExceptionHandlerLib/LoongArch/Exc=
eptionCommon.c
 create mode 100644 UefiCpuPkg/Library/CpuExceptionHandlerLib/LoongArch/Exc=
eptionCommon.h
 create mode 100644 UefiCpuPkg/Library/CpuExceptionHandlerLib/LoongArch/Loo=
ngArch64/ArchExceptionHandler.c
 create mode 100644 UefiCpuPkg/Library/CpuExceptionHandlerLib/LoongArch/Loo=
ngArch64/ExceptionHandlerAsm.S
 create mode 100644 UefiCpuPkg/Library/CpuExceptionHandlerLib/LoongArch/Sec=
PeiExceptionLib.c
 create mode 100644 UefiCpuPkg/Library/CpuMmuInitLib/CpuMmuInitLib.inf
 create mode 100644 UefiCpuPkg/Library/CpuMmuInitLib/CpuMmuInitLib.uni
 create mode 100644 UefiCpuPkg/Library/CpuMmuInitLib/LoongArch64/CpuMmuInit=
.c
 create mode 100644 UefiCpuPkg/Library/CpuMmuInitLib/LoongArch64/TlbExcepti=
onHandle.S
 create mode 100644 UefiCpuPkg/Library/CpuMmuInitLib/LoongArch64/TlbExcepti=
onHandle.h
 create mode 100644 UefiCpuPkg/Library/CpuMmuLib/CpuMmuLib.inf
 create mode 100644 UefiCpuPkg/Library/CpuMmuLib/CpuMmuLib.uni
 create mode 100644 UefiCpuPkg/Library/CpuMmuLib/LoongArch64/CpuMmu.c
 create mode 100644 UefiCpuPkg/Library/CpuMmuLib/LoongArch64/Page.h
 create mode 100644 UefiCpuPkg/Library/CpuMmuLib/LoongArch64/TlbInvalid.S
 create mode 100644 UefiCpuPkg/Library/CpuMmuLib/LoongArch64/TlbInvalid.h
 create mode 100644 UefiCpuPkg/Library/CpuTimerLib/LoongArch64/CpuTimerLib.=
c
 create mode 100644 UefiCpuPkg/Library/MpInitLib/LoongArch64/DxeMpLib.c
 create mode 100644 UefiCpuPkg/Library/MpInitLib/LoongArch64/MpLib.c
 create mode 100644 UefiCpuPkg/Library/MpInitLib/LoongArch64/MpLib.h
 create mode 100644 UefiCpuPkg/Library/MpInitLib/LoongArch64/PeiMpLib.c
_._,_._,_
Groups.io Links:

=20 You receive all messages sent to this group. =20 =20

View/Reply Online (#117018) | =20 | Mute= This Topic | New Topic
Your Subscriptio= n | Contact Group Owner | Unsubscribe [rebecca@openfw.io]

_._,_._,_
--------------8huCOUwa7wRibZwtaXu1yxBD--