From: "Sami Mujawar" <sami.mujawar@arm.com>
To: pierre.gondois@arm.com, devel@edk2.groups.io,
Michael D Kinney <michael.d.kinney@intel.com>,
Liming Gao <gaoliming@byosoft.com.cn>,
Zhiguang Liu <zhiguang.liu@intel.com>,
Jiewen Yao <jiewen.yao@intel.com>,
Jian J Wang <jian.j.wang@intel.com>,
Ard Biesheuvel <ardb+tianocore@kernel.org>
Cc: Jose Marinho <Jose.Marinho@arm.com>, Kun Qin <kuqin12@gmail.com>,
"nd@arm.com" <nd@arm.com>
Subject: Re: [PATCH v3 0/6] SecurityPkg/MdePkg: Update RngLib GUID identification
Date: Fri, 7 Jul 2023 09:26:23 +0100 [thread overview]
Message-ID: <b7683927-2bef-b772-820d-832a22de6360@arm.com> (raw)
In-Reply-To: <20230706085159.626374-1-pierre.gondois@arm.com>
Dear MdePkg & SecurityPkg maintainers,
This series and Kun's patch at
https://edk2.groups.io/g/devel/message/106547 are both required to fix
the RNG implementation for Arm.
Is it possible to provide feedback for this series and Kun's patch, please?
I plan to merge this series and Kun's patch, if there is no further
feedback by end of next week.
Regards,
Sami Mujawar
On 06/07/2023 09:51 am, pierre.gondois@arm.com wrote:
> From: Pierre Gondois <pierre.gondois@arm.com>
>
> v3:
> - As the unsafe algorithm GUID will not be added to the UEFI
> specification, rename:
> - gEfiRngAlgorithmUnSafe to gEdkiiRngAlgorithmUnSafe
> - EFI_RNG_ALGORITHM_UNSAFE to EDKII_RNG_ALGORITHM_UNSAFE
>
> v2:
> [1/8] MdePkg/ArmTrngLib: Remove ASSERTs in Null implementation
> - Dropped
> [2/8] MdePkg/MdePkg.dec: Move PcdCpuRngSupportedAlgorithm to MdePkg
> - Change gEfiMdePkgTokenSpaceGuid.PcdCpuRngSupportedAlgorithm
> token number
> - Rename to SecurityPkg/SecurityPkg.dec: Move
> PcdCpuRngSupportedAlgorithm to MdePkg
> [5/8] MdePkg/Rng: Add GetRngGuid() to RngLib
> - Remove gEfiRngAlgorithmUnSafe from inf file
> - Split Guids definitions in arch specific sections
> [6/8] SecurityPkg/RngDxe: Use GetRngGuid() when probing RngLib
> - Remove RngFindDefaultAlgo() and change logic accordingly.
> [7/8] SecurityPkg/RngDxe: Select safe default Rng algorithm
> - Dropped due to changes in [6/8]
>
> This patch also requires the following patch on top of the serie:
> - https://edk2.groups.io/g/devel/message/106546
>
> This patchset follows the 'code first' approach and relates to [1].
> This patchset follows the thread at [3] that aims to solve [2].
> [1] and [2] are bound and this patchset aims to solve both.
>
> In this patchset:
> a-
> The RngDxe can rely on the RngLib. However the RngLib has no
> interface allowing to describe which Rng algorithm is implemented.
> The RngDxe must advertise the algorithm that are available through
> the RngGetInfo() callback.
> Add a GetRngGuid() for interface to the RngLib.
>
> b-
> The Arm Architecture states the RNDR that the DRBG algorithm should
> be compliant with NIST SP800-90A, while not mandating a particular
> algorithm, so as to be inclusive of different geographies.
> The RngLib can rely on this Arm RNDR instruction. In order to
> accurately describe the implementation using the RNDR instruction,
> add a EFI_RNG_ALGORITHM_ARM_RNDR GUID [1].
>
> c-
> For the same reason as a/b, add a GUID describing unsafe RNG
> algorithms, allowing to accurately describe the BaseRngLibTimerLib.
>
> d-
> Use a/b/c mechanisms/GUIDs to select a safe Rng algorithm in the
> Arm implementation of the RngDxe.
>
> [1] BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4441
> [2] BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4151
> [3] https://edk2.groups.io/g/devel/message/100806
>
> Pierre Gondois (6):
> SecurityPkg/SecurityPkg.dec: Move PcdCpuRngSupportedAlgorithm to
> MdePkg
> MdePkg/DxeRngLib: Request raw algorithm instead of default
> MdePkg/Rng: Add GUIDs to describe Rng algorithms
> MdePkg/Rng: Add GetRngGuid() to RngLib
> SecurityPkg/RngDxe: Use GetRngGuid() when probing RngLib
> SecurityPkg/RngDxe: Simplify Rng algorithm selection for Arm
>
> MdePkg/Include/Library/RngLib.h | 17 ++++++
> MdePkg/Include/Protocol/Rng.h | 20 +++++++
> MdePkg/Library/BaseRngLib/AArch64/Rndr.c | 42 +++++++++++++++
> MdePkg/Library/BaseRngLib/BaseRngLib.inf | 10 ++++
> MdePkg/Library/BaseRngLib/Rand/RdRand.c | 26 +++++++++
> .../Library/BaseRngLibNull/BaseRngLibNull.c | 22 ++++++++
> .../BaseRngLibTimerLib/BaseRngLibTimerLib.inf | 3 ++
> .../Library/BaseRngLibTimerLib/RngLibTimer.c | 28 ++++++++++
> MdePkg/Library/DxeRngLib/DxeRngLib.c | 36 ++++++++++++-
> MdePkg/MdePkg.dec | 7 +++
> .../RngDxe/AArch64/AArch64Algo.c | 54 +++++++++++++------
> .../RandomNumberGenerator/RngDxe/ArmRngDxe.c | 23 ++++----
> .../RandomNumberGenerator/RngDxe/RngDxe.inf | 5 +-
> SecurityPkg/SecurityPkg.dec | 2 -
> 14 files changed, 258 insertions(+), 37 deletions(-)
>
prev parent reply other threads:[~2023-07-07 8:26 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-06 8:51 [PATCH v3 0/6] SecurityPkg/MdePkg: Update RngLib GUID identification PierreGondois
2023-07-06 8:51 ` [PATCH v3 1/6] SecurityPkg/SecurityPkg.dec: Move PcdCpuRngSupportedAlgorithm to MdePkg PierreGondois
2023-07-06 8:51 ` [PATCH v3 2/6] MdePkg/DxeRngLib: Request raw algorithm instead of default PierreGondois
2023-07-06 8:51 ` [PATCH v3 3/6] MdePkg/Rng: Add GUIDs to describe Rng algorithms PierreGondois
2023-07-07 9:14 ` [edk2-devel] " Yao, Jiewen
2023-07-07 12:49 ` PierreGondois
2023-07-07 12:56 ` Yao, Jiewen
[not found] ` <176F972B57840483.2683@groups.io>
2023-07-07 13:05 ` Yao, Jiewen
2023-07-07 14:25 ` PierreGondois
2023-07-07 14:28 ` Yao, Jiewen
[not found] ` <176F9C2F554052EE.2683@groups.io>
2023-07-07 14:34 ` Yao, Jiewen
2023-07-10 1:26 ` 回复: " gaoliming
2023-07-11 12:23 ` PierreGondois
2023-07-06 8:51 ` [PATCH v3 4/6] MdePkg/Rng: Add GetRngGuid() to RngLib PierreGondois
2023-07-06 8:51 ` [PATCH v3 5/6] SecurityPkg/RngDxe: Use GetRngGuid() when probing RngLib PierreGondois
2023-07-07 8:07 ` Sami Mujawar
2023-07-06 8:51 ` [PATCH v3 6/6] SecurityPkg/RngDxe: Simplify Rng algorithm selection for Arm PierreGondois
2023-07-06 19:01 ` [PATCH v3 0/6] SecurityPkg/MdePkg: Update RngLib GUID identification Kun Qin
2023-07-12 13:38 ` PierreGondois
2023-07-07 8:26 ` Sami Mujawar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b7683927-2bef-b772-820d-832a22de6360@arm.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox