From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by mx.groups.io with SMTP id smtpd.web09.1109.1610498502977642481 for ; Tue, 12 Jan 2021 16:41:43 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=hKUtIUIz; spf=pass (domain: redhat.com, ip: 63.128.21.124, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1610498502; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WEMQk9HMi6dm7K13+2OaX6q0qc0m+xp4sUHQ3psjHPM=; b=hKUtIUIzA/UovSpQZ4ysv55euI22OTJE3ocwS9xdrCFmyDb1ycgj/GNNUyLTi5VKdT4DAv ypuFag6VLgz8T9U/0Su/mtgUV0df6DKAbYMwRuL6T0EkcucT7L4T40SB/CETkyt2yNY8+W ozh4XRAfBA69+JW3f1Rrs0gXFFHgYCc= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-418-hqRTYVoHNju3OxYliqIfcA-1; Tue, 12 Jan 2021 19:41:38 -0500 X-MC-Unique: hqRTYVoHNju3OxYliqIfcA-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id B0E3D107ACF9; Wed, 13 Jan 2021 00:41:35 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-112-31.ams2.redhat.com [10.36.112.31]) by smtp.corp.redhat.com (Postfix) with ESMTP id B300B6267D; Wed, 13 Jan 2021 00:41:32 +0000 (UTC) Subject: Re: [edk2-devel] [PATCH v4 1/9] OvmfPkg: Introduce PciHostBridgeUtilityLib class To: devel@edk2.groups.io, cenjiahui@huawei.com Cc: Jordan Justen , Ard Biesheuvel , Rebecca Cran , Peter Grehan , Anthony Perard , Julien Grall , Leif Lindholm , Sami Mujawar , xieyingtai@huawei.com, wu.wubin@huawei.com, Yubo Miao References: <20210112094549.10238-1-cenjiahui@huawei.com> <20210112094549.10238-2-cenjiahui@huawei.com> From: "Laszlo Ersek" Message-ID: Date: Wed, 13 Jan 2021 01:41:31 +0100 MIME-Version: 1.0 In-Reply-To: <20210112094549.10238-2-cenjiahui@huawei.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=lersek@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 01/12/21 10:45, Jiahui Cen via groups.io wrote: > Introduce a new PciHostBridgeUtilityLib class to share duplicate code > between OvmfPkg and ArmVirtPkg. > > Extract function PciHostBridgeUtilityResourceConflict from > PciHostBridgeResourceConflict in OvmfPkg/PciHostBridgeLib. > > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3059 > > Cc: Jordan Justen > Cc: Laszlo Ersek > Cc: Ard Biesheuvel > Cc: Rebecca Cran > Cc: Peter Grehan > Cc: Anthony Perard > Cc: Julien Grall > Signed-off-by: Jiahui Cen > Signed-off-by: Yubo Miao > --- > OvmfPkg/OvmfPkg.dec | 4 + > OvmfPkg/AmdSev/AmdSevX64.dsc | 1 + > OvmfPkg/Bhyve/BhyveX64.dsc | 1 + > OvmfPkg/OvmfPkgIa32.dsc | 1 + > OvmfPkg/OvmfPkgIa32X64.dsc | 1 + > OvmfPkg/OvmfPkgX64.dsc | 1 + > OvmfPkg/OvmfXen.dsc | 1 + > OvmfPkg/Library/PciHostBridgeLib/PciHostBridgeLib.inf | 1 + > OvmfPkg/Library/PciHostBridgeUtilityLib/PciHostBridgeUtilityLib.inf | 37 ++++++++++ > OvmfPkg/Include/Library/PciHostBridgeUtilityLib.h | 37 ++++++++++ > OvmfPkg/Library/PciHostBridgeLib/PciHostBridgeLib.c | 41 +---------- > OvmfPkg/Library/PciHostBridgeUtilityLib/PciHostBridgeUtilityLib.c | 77 ++++++++++++++++++++ > 12 files changed, 164 insertions(+), 39 deletions(-) Reviewed-by: Laszlo Ersek