From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id D30DF21E2DA62 for ; Tue, 15 Aug 2017 17:34:10 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id CA3296552; Wed, 16 Aug 2017 00:36:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com CA3296552 Authentication-Results: ext-mx10.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx10.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=lersek@redhat.com Received: from lacos-laptop-7.usersys.redhat.com (ovpn-116-68.phx2.redhat.com [10.3.116.68]) by smtp.corp.redhat.com (Postfix) with ESMTP id 7ACF867CDC; Wed, 16 Aug 2017 00:36:34 +0000 (UTC) To: Brijesh Singh , edk2-devel@lists.01.org Cc: Jordan Justen , Tom Lendacky , Ard Biesheuvel References: <1502710605-8058-1-git-send-email-brijesh.singh@amd.com> <1502710605-8058-4-git-send-email-brijesh.singh@amd.com> From: Laszlo Ersek Message-ID: Date: Wed, 16 Aug 2017 02:36:33 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <1502710605-8058-4-git-send-email-brijesh.singh@amd.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Wed, 16 Aug 2017 00:36:36 +0000 (UTC) Subject: Re: [PATCH v2 03/23] OvmfPkg/VirtioPciDeviceDxe: add missing IN and OUT decoration X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 16 Aug 2017 00:34:11 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 08/14/17 13:36, Brijesh Singh wrote: > Cc: Ard Biesheuvel > Cc: Jordan Justen > Cc: Tom Lendacky > Cc: Laszlo Ersek > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Brijesh Singh > --- > OvmfPkg/VirtioPciDeviceDxe/VirtioPciDevice.h | 24 ++++++++++---------- > OvmfPkg/VirtioPciDeviceDxe/VirtioPciFunctions.c | 24 ++++++++++---------- > 2 files changed, 24 insertions(+), 24 deletions(-) > > diff --git a/OvmfPkg/VirtioPciDeviceDxe/VirtioPciDevice.h b/OvmfPkg/VirtioPciDeviceDxe/VirtioPciDevice.h > index 8f17a16c88f5..6f51f816ef0f 100644 > --- a/OvmfPkg/VirtioPciDeviceDxe/VirtioPciDevice.h > +++ b/OvmfPkg/VirtioPciDeviceDxe/VirtioPciDevice.h > @@ -96,15 +96,15 @@ VirtioPciGetQueueSize ( > EFI_STATUS > EFIAPI > VirtioPciSetQueueAlignment ( > - VIRTIO_DEVICE_PROTOCOL *This, > - UINT32 Alignment > + IN VIRTIO_DEVICE_PROTOCOL *This, > + IN UINT32 Alignment > ); > > EFI_STATUS > EFIAPI > VirtioPciSetPageSize ( > - VIRTIO_DEVICE_PROTOCOL *This, > - UINT32 PageSize > + IN VIRTIO_DEVICE_PROTOCOL *This, > + IN UINT32 PageSize > ); > > EFI_STATUS > @@ -131,29 +131,29 @@ VirtioPciSetQueueAddress ( > EFI_STATUS > EFIAPI > VirtioPciSetQueueSel ( > - VIRTIO_DEVICE_PROTOCOL *This, > - UINT16 Sel > + IN VIRTIO_DEVICE_PROTOCOL *This, > + IN UINT16 Sel > ); > > EFI_STATUS > EFIAPI > VirtioPciSetQueueNotify ( > - VIRTIO_DEVICE_PROTOCOL *This, > - UINT16 Index > + IN VIRTIO_DEVICE_PROTOCOL *This, > + IN UINT16 Index > ); > > EFI_STATUS > EFIAPI > VirtioPciSetQueueSize ( > - VIRTIO_DEVICE_PROTOCOL *This, > - UINT16 Size > + IN VIRTIO_DEVICE_PROTOCOL *This, > + IN UINT16 Size > ); > > EFI_STATUS > EFIAPI > VirtioPciSetDeviceStatus ( > - VIRTIO_DEVICE_PROTOCOL *This, > - UINT8 DeviceStatus > + IN VIRTIO_DEVICE_PROTOCOL *This, > + IN UINT8 DeviceStatus > ); > > #endif // _VIRTIO_PCI_DEVICE_DXE_H_ > diff --git a/OvmfPkg/VirtioPciDeviceDxe/VirtioPciFunctions.c b/OvmfPkg/VirtioPciDeviceDxe/VirtioPciFunctions.c > index 243aa14c2421..5f86914265ea 100644 > --- a/OvmfPkg/VirtioPciDeviceDxe/VirtioPciFunctions.c > +++ b/OvmfPkg/VirtioPciDeviceDxe/VirtioPciFunctions.c > @@ -196,8 +196,8 @@ VirtioPciSetQueueAddress ( > EFI_STATUS > EFIAPI > VirtioPciSetQueueSel ( > - VIRTIO_DEVICE_PROTOCOL *This, > - UINT16 Sel > + IN VIRTIO_DEVICE_PROTOCOL *This, > + IN UINT16 Sel > ) > { > VIRTIO_PCI_DEVICE *Dev; > @@ -211,8 +211,8 @@ VirtioPciSetQueueSel ( > EFI_STATUS > EFIAPI > VirtioPciSetQueueAlignment ( > - VIRTIO_DEVICE_PROTOCOL *This, > - UINT32 Alignment > + IN VIRTIO_DEVICE_PROTOCOL *This, > + IN UINT32 Alignment > ) > { > return EFI_SUCCESS; > @@ -221,8 +221,8 @@ VirtioPciSetQueueAlignment ( > EFI_STATUS > EFIAPI > VirtioPciSetPageSize ( > - VIRTIO_DEVICE_PROTOCOL *This, > - UINT32 PageSize > + IN VIRTIO_DEVICE_PROTOCOL *This, > + IN UINT32 PageSize > ) > { > return (PageSize == EFI_PAGE_SIZE) ? EFI_SUCCESS : EFI_UNSUPPORTED; > @@ -231,8 +231,8 @@ VirtioPciSetPageSize ( > EFI_STATUS > EFIAPI > VirtioPciSetQueueNotify ( > - VIRTIO_DEVICE_PROTOCOL *This, > - UINT16 Index > + IN VIRTIO_DEVICE_PROTOCOL *This, > + IN UINT16 Index > ) > { > VIRTIO_PCI_DEVICE *Dev; > @@ -246,8 +246,8 @@ VirtioPciSetQueueNotify ( > EFI_STATUS > EFIAPI > VirtioPciSetQueueSize ( > - VIRTIO_DEVICE_PROTOCOL *This, > - UINT16 Size > + IN VIRTIO_DEVICE_PROTOCOL *This, > + IN UINT16 Size > ) > { > // > @@ -260,8 +260,8 @@ VirtioPciSetQueueSize ( > EFI_STATUS > EFIAPI > VirtioPciSetDeviceStatus ( > - VIRTIO_DEVICE_PROTOCOL *This, > - UINT8 DeviceStatus > + IN VIRTIO_DEVICE_PROTOCOL *This, > + IN UINT8 DeviceStatus > ) > { > VIRTIO_PCI_DEVICE *Dev; > Reviewed-by: Laszlo Ersek Regression-tested-by: Laszlo Ersek Commit e5251fecb931763c90a032266fdd8ab5ec527744. Thanks Laszlo