From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4864:20::541; helo=mail-pg1-x541.google.com; envelope-from=ming.huang@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-pg1-x541.google.com (mail-pg1-x541.google.com [IPv6:2607:f8b0:4864:20::541]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id B54A82116821B for ; Mon, 29 Oct 2018 08:01:39 -0700 (PDT) Received: by mail-pg1-x541.google.com with SMTP id s3-v6so4013512pga.12 for ; Mon, 29 Oct 2018 08:01:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=OLsmwPhKhlRqdwJNoB7Ce0t3Jc8YxAJyx2KKNMJogPs=; b=hY+msdlt1yfcm7vGOofX0lS1M3bspEzNycV7fsF1yQ1pkSSfgtqkbphxQjfEFHbxNB WfZN1TrLFV1sTACeghXEyNpSyES2bKzhaMKcqmz78iT3nRiTRHGS0x6sWeyHtW28t7Ux MZWy0+h18qgddYaNO7ROnFjKGjxH/xYATbsLI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=OLsmwPhKhlRqdwJNoB7Ce0t3Jc8YxAJyx2KKNMJogPs=; b=aUOSSPKV83f3ag5nthSRduRW407nMdj7ks9rUZTlW3S6tZ6dtTs6QNbWeDN6s/X+Mq BobgBe+3fkciBttwaquWJfWBvHJhLUwP6s9Lh24U9soIsMcJ6/wRi1wdwo/7i2R0//F+ e0Z72nOfZauFe8WQxJlLimrK2ZOwiNqIfO7bP26XrGcbwYmfZg/h3YRIKGAm4VA/B1dZ EBEWtXDmXLcU05Sfkouqq2kLtWm84SbBhj2VRR8yhjOen4+aqDEV4GiYTMiUXrI+9JPh KZV2l0BHd7HZaBwTq9fKGTc7p4+AfjojP/VdxzpCjlImb2teBhwDRZAPV2iTD10SsCYA qmLw== X-Gm-Message-State: AGRZ1gI0zXCMXP4avMWY7zmMkEpjNi138VIE+HmR57sjOI4b9kgvuV9N BO55JhvssYhZGeB5ItNVd3mJcQ== X-Google-Smtp-Source: AJdET5e8qkmhhTNgoSdYONyiAsFDa14wXHlaHSPbHWnkTfgtCXwGuCsUELVYRRNX1+Xp+80AxEQyQg== X-Received: by 2002:a62:995c:: with SMTP id d89-v6mr7761735pfe.11.1540825298753; Mon, 29 Oct 2018 08:01:38 -0700 (PDT) Received: from [10.126.0.70] ([64.64.108.109]) by smtp.gmail.com with ESMTPSA id b18-v6sm14513254pgg.88.2018.10.29.08.01.27 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 29 Oct 2018 08:01:38 -0700 (PDT) To: Leif Lindholm Cc: linaro-uefi@lists.linaro.org, edk2-devel@lists.01.org, graeme.gregory@linaro.org, ard.biesheuvel@linaro.org, michael.d.kinney@intel.com, lersek@redhat.com, wanghuiqiang@huawei.com, huangming23@huawei.com, zhangjinsong2@huawei.com, huangdaode@hisilicon.com, john.garry@huawei.com, xinliang.liu@linaro.org, zhangfeng56@huawei.com References: <20181029033249.45363-1-ming.huang@linaro.org> <20181029114305.iixbeg2u7rel5gyq@bivouac.eciton.net> From: Ming Huang Message-ID: Date: Mon, 29 Oct 2018 23:01:19 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.0 MIME-Version: 1.0 In-Reply-To: <20181029114305.iixbeg2u7rel5gyq@bivouac.eciton.net> Subject: Re: [PATCH edk2-platforms v1 00/12] Fix D06 SBSA/SBBR issue and improve X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 Oct 2018 15:01:39 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Hi Leif, Yes, I generated this patchset with the same git configuration as previous patchset: ([PATCH edk2-platforms v5 00/28] Upload for D06 platform) and use the same command: git format-patch --stat=1000 --stat-graph-width=20 --cover-letter --no-binary --subject-prefix="PATCH edk2-platforms" -12 -v 1 -o v1 I check the URL below, no important different configuration found. Have problems with this patchset? Thanks, Ming On 10/29/2018 7:43 PM, Leif Lindholm wrote: > Hi Ming, > > On Mon, Oct 29, 2018 at 11:32:37AM +0800, Ming Huang wrote: >> The major features of this patchset include: >> 1. Modify acpi table for ACS test; >> 2. Enable secure boot for SBBR-SCT; >> 3. Other change for ACS test; >> >> For this SCT issue: >> RT.SetVariable - Create one Time Base Auth Variable, the expect return status >> should be EFI_SUCCESS – FAILURE >> >> The resule of fail is effected by the edk2 commit(67943427). >> If Modify Variable.c as below, this case will pass. >> --- a/MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c >> +++ b/MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c >> @@ -3188,7 +3188,7 @@ VariableServiceSetVariable ( >> // Maybe it's the delete operation of common authenticated variable at >> // user physical presence. >> // >> if (DataSize != AUTHINFO_SIZE) { >> - return EFI_UNSUPPORTED; >> + return EFI_SECURITY_VIOLATION; >> >> I supect ACS SCT compatible with UEFI 2.7 spec. We will analyze this issue >> continue. >> >> Code can also be found in github: >> https://github.com/hisilicon/OpenPlatformPkg.git >> branch: d06-acs-platforms >> >> >> Ming Huang (12): >> Silicon/Hisilicon/D06: Add watchdog to GTDT >> Silicon/Hisilicon/D06: Drop _CID for fwts issue >> Silicon/Hisilicon/D06: Fix fwts issue in Dbg2 >> Silicon/Hisilicon/D06: Fix fwts issue in FADT >> Hisilicon/D06: Move some functions to OemMiscLib >> Silicon/Hisilicon: Modify for SBBR fwts SetTime_Func test case >> Hisilicon/D0x: Fix secure boot bug in FlashFvbDxe >> Hisilicon/D06: Fix SBBR-SCT AuthVar issue >> Silicon/Hisilicon/D06: Reserve ECAM resource in DSDT >> Silicon/Hisilicon/D06: Modify GTDT timer flag >> Hisilicon/D06: Modify Gic base >> Silicon/Hisilicon/D06: Set TA as Node 0 for TA boot >> >> Silicon/Hisilicon/HisiPkg.dec | 1 + >> Silicon/Hisilicon/Hisilicon.dsc.inc | 16 ++ >> Platform/Hisilicon/D03/D03.dsc | 5 + >> Platform/Hisilicon/D05/D05.dsc | 5 + >> Platform/Hisilicon/D06/D06.dsc | 9 +- >> .../Drivers/FlashFvbDxe/FlashFvbDxe.inf | 2 + >> .../M41T83RealTimeClockLib.inf | 3 +- >> .../Hi1620/Hi1620AcpiTables/Hi1620Platform.h | 2 +- >> .../Hisilicon/Include/Library/OemMiscLib.h | 9 + >> .../M41T83RealTimeClock.h | 8 +- >> .../D06/Library/OemMiscLibD06/OemMiscLibD06.c | 82 ++++++ >> .../Drivers/FlashFvbDxe/FlashFvbDxe.c | 14 +- >> .../M41T83RealTimeClockLib.c | 263 ++++++++++++------ >> .../Hi1620/Hi1620AcpiTables/Dsdt/Com.asl | 1 - >> .../Hi1620AcpiTables/Dsdt/Hi1620Mbig.asl | 48 ---- >> .../Hi1620AcpiTables/Dsdt/Hi1620Pci.asl | 36 ++- >> .../Hi1620/Hi1620AcpiTables/Fadt.aslc | 2 +- >> .../Hi1620/Hi1620AcpiTables/Gtdt.aslc | 35 +-- >> .../Hi1620/Hi1620AcpiTables/Hi1620Dbg2.aslc | 4 +- >> .../Hi1620/Hi1620AcpiTables/Hi1620Iort.asl | 18 +- >> .../Hi1620/Hi1620AcpiTables/Hi1620Srat.aslc | 194 ++++++------- >> .../Hi1620/Hi1620AcpiTables/MadtHi1620.aslc | 2 +- > > Can you ensure you use the options specified in > https://github.com/tianocore/tianocore.github.io/wiki/Laszlo's-unkempt-git-guide-for-edk2-contributors-and-maintainers#contrib-23 > when generating your patches? > > This way we don't need to guess which files are being modified when > looking at the summary. > > Regards, > > Leif > >> 22 files changed, 475 insertions(+), 284 deletions(-) >> >> -- >> 2.18.0 >>