From mboxrd@z Thu Jan  1 00:00:00 1970
Authentication-Results: mx.groups.io;
 dkim=missing; spf=pass (domain: redhat.com, ip: 209.85.221.68, mailfrom: philmd@redhat.com)
Received: from mail-wr1-f68.google.com (mail-wr1-f68.google.com [209.85.221.68])
 by groups.io with SMTP; Thu, 25 Jul 2019 04:08:32 -0700
Received: by mail-wr1-f68.google.com with SMTP id 31so50357937wrm.1
        for <devel@edk2.groups.io>; Thu, 25 Jul 2019 04:08:32 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:subject:to:references:from:openpgp:message-id
         :date:user-agent:mime-version:in-reply-to:content-language
         :content-transfer-encoding;
        bh=OGuNPOIas8PrzGddtG2BNLzkwPteNP+sPKLYbOVUbN4=;
        b=Oh965l+tdcBUf+0sR4xl8ObXeu5bGYk+i9zIC1WLls9XbsF56yxHLY5FVIpnpMy+6p
         0vLzAFZjeKYm82fEkomA4U/whL5MIML41v3YGu7CK/iDvTHfXVRceXgFxZ6RI7ZiA5xx
         k1Z3Z6e6O2zf3iioftIwai+Wk25C1ANm+HIvtR744xWDlwKbDIf1OjxipWJ+jEngC8Qk
         yHFif7dk05RKTsA6xjlQIrUwoiLA3yaU3Mn35SA1EhcxVVjZJ55RYgz7t1EeEF8Y+L6P
         tWfgm68BDWLBMgYEgnfw7FefH+VwK5ZfvnDI8waHbltLzHLMJfYKkO3AuI3RiBMgdP+B
         fNvg==
X-Gm-Message-State: APjAAAUTVGwY0QcIe+2SZATtB6WstQE8Ah0EGoEbQetCPoAYxOAI8zi8
	BYiZ7YvduxvH4OcOLRtV61/fAA==
X-Google-Smtp-Source: APXvYqz3I2OYP5VtDZnemmDObQ8BFBAtmj7dC885ffh4EL2YGrKl2Ur9Yw8w8gWaD2FzDJgXDmc1Jg==
X-Received: by 2002:a5d:50d1:: with SMTP id f17mr42136157wrt.124.1564052910971;
        Thu, 25 Jul 2019 04:08:30 -0700 (PDT)
Return-Path: <philmd@redhat.com>
Received: from [192.168.1.37] (190.red-81-40-121.staticip.rima-tde.net. [81.40.121.190])
        by smtp.gmail.com with ESMTPSA id 32sm42149925wrh.76.2019.07.25.04.08.30
        (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128);
        Thu, 25 Jul 2019 04:08:30 -0700 (PDT)
Subject: Re: [edk2-devel] [PATCH v2 3/3] OvmfPkg/build.sh: remove $ADD_QEMU_HDA
To: devel@edk2.groups.io, rebecca@bsdio.com,
 Jordan Justen <jordan.l.justen@intel.com>, Laszlo Ersek <lersek@redhat.com>,
 Ard Biesheuvel <ard.biesheuvel@linaro.org>
References: <20190724214405.16162-1-rebecca@bsdio.com>
 <20190724214405.16162-3-rebecca@bsdio.com>
From: =?UTF-8?B?UGhpbGlwcGUgTWF0aGlldS1EYXVkw6k=?= <philmd@redhat.com>
Openpgp: id=89C1E78F601EE86C867495CBA2A3FD6EDEADC0DE;
 url=http://pgp.mit.edu/pks/lookup?op=get&search=0xA2A3FD6EDEADC0DE
Message-ID: <b7ddc44e-1405-fc26-285b-d7f54bc89dad@redhat.com>
Date: Thu, 25 Jul 2019 13:08:29 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.7.0
MIME-Version: 1.0
In-Reply-To: <20190724214405.16162-3-rebecca@bsdio.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit

On 7/24/19 11:44 PM, rebecca@bsdio.com wrote:
> $ADD_QEMU_HDA was added because QEMU used to refuse to run without a
> disk. Since newer versions run without any disks, remove it.

Finally :)

Should we also update the wiki documentation?

Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>

> 
> Signed-off-by: Rebecca Cran <rebecca@bsdio.com>
> ---
>  OvmfPkg/build.sh | 14 --------------
>  1 file changed, 14 deletions(-)
> 
> diff --git a/OvmfPkg/build.sh b/OvmfPkg/build.sh
> index 0219791aa8..960382f633 100755
> --- a/OvmfPkg/build.sh
> +++ b/OvmfPkg/build.sh
> @@ -213,17 +213,6 @@ if [[ "$RUN_QEMU" == "yes" ]]; then
>        ENABLE_FLASH=yes
>        ;;
>    esac
> -
> -  ADD_QEMU_HDA=yes
> -  for arg in "$@"
> -  do
> -    case $arg in
> -      -hd[a-d]|-fd[ab]|-cdrom)
> -        ADD_QEMU_HDA=no
> -        break
> -        ;;
> -    esac
> -  done
>  fi
>  
>  #
> @@ -267,9 +256,6 @@ if [[ "$RUN_QEMU" == "yes" ]]; then
>    else
>      QEMU_COMMAND="$QEMU_COMMAND -L $QEMU_FIRMWARE_DIR"
>    fi
> -  if [[ "$ADD_QEMU_HDA" == "yes" ]]; then
> -    QEMU_COMMAND="$QEMU_COMMAND -hda fat:$BUILD_ROOT_ARCH"
> -  fi
>    echo Running: $QEMU_COMMAND "$@"
>    $QEMU_COMMAND "$@"
>    exit $?
>