public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Michael Kubacki" <mikuback@linux.microsoft.com>
To: devel@edk2.groups.io, michael.d.kinney@intel.com, "Yao,
	Jiewen" <jiewen.yao@intel.com>
Subject: Re: [edk2-devel] libspdm Breaking Builds
Date: Wed, 22 May 2024 18:16:23 -0400	[thread overview]
Message-ID: <b7fcec36-e987-4e83-ad61-2b2d7bf1d7a2@linux.microsoft.com> (raw)
In-Reply-To: <CO1PR11MB4929C98E76756FB66F3C327BD2EB2@CO1PR11MB4929.namprd11.prod.outlook.com>

I don't think that's a very good solution given the diversity of 
downstream projects dependent on the repo or even for the libspdm repo 
itself.

Thanks,
Michael

On 5/22/2024 5:57 PM, Michael D Kinney wrote:
> This was discussed and the decision was made to no use recursive clone on libspdm.
> 
> Mike
> 
>> -----Original Message-----
>> From: Michael Kubacki <mikuback@linux.microsoft.com>
>> Sent: Wednesday, May 22, 2024 1:40 PM
>> To: devel@edk2.groups.io; Yao, Jiewen <jiewen.yao@intel.com>
>> Cc: Kinney, Michael D <michael.d.kinney@intel.com>
>> Subject: libspdm Breaking Builds
>>
>> Recently, the libspdm submodule was added to SecurityPkg
>> (SecurityPkg/DeviceSecurity/SpdmLib/libspdm) [1].
>>
>> That submodule points to https://github.com/DMTF/libspdm.git.
>>
>> The libspdm repo contains a submodule for cmocka that is hosted on
>> cryptomilk.org [2].
>>
>> Cloning that submodule is failing today, breaking all builds/CI
>> dependent on SecurityPkg.
>>
>> This has been an issue in the past and it is very disruptive given the
>> number of dependencies on edk2/SecurityPkg. Because of its reliability
>> issues, edk2 moved to a version of the repo hosted in tianocore [3] in
>> 2021 [4]
>>
>> Can you please make a similar change in libspdm and we get edk2 updated
>> as soon as possible?
>>
>> Thanks,
>> Michael
>>
>> [1]
>> https://github.com/tianocore/edk2/commit/54a4fd9b35cac79e7c54b750d3dddd0fbb43
>> dca1
>>
>> [2] https://github.com/DMTF/libspdm/blob/main/.gitmodules
>>
>> [3] https://github.com/tianocore/edk2-cmocka
>>
>> [4]
>> https://github.com/tianocore/edk2/commit/2ad22420a710dc07e3b644f91a5b55c09c39
>> ecf3
> 
> 
> 
> 
> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#119120): https://edk2.groups.io/g/devel/message/119120
Mute This Topic: https://groups.io/mt/106250971/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



  reply	other threads:[~2024-05-22 22:16 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-22 20:40 [edk2-devel] libspdm Breaking Builds Michael Kubacki
2024-05-22 21:57 ` Michael D Kinney
2024-05-22 22:16   ` Michael Kubacki [this message]
2024-05-22 22:24     ` Michael D Kinney
2024-05-23  1:04       ` Michael Kubacki
2024-05-23  1:51         ` Michael D Kinney
2024-05-23  2:16           ` Yao, Jiewen
     [not found]           ` <17D1FC93E885E03F.15878@groups.io>
2024-05-24  2:13             ` Yao, Jiewen
2024-05-29 18:17               ` Pete Batard via groups.io
2024-05-29 18:33                 ` Michael D Kinney
2024-05-29 19:40                   ` Michael D Kinney
2024-05-29 19:57                     ` Michael Kubacki
2024-05-30  0:31                       ` Yao, Jiewen
2024-05-29 22:00                     ` Pete Batard via groups.io
2024-05-30  0:32                       ` Michael D Kinney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b7fcec36-e987-4e83-ad61-2b2d7bf1d7a2@linux.microsoft.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox