From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web11.15165.1672931864929486963 for ; Thu, 05 Jan 2023 07:17:45 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=JBY7EpKl; spf=pass (domain: redhat.com, ip: 170.10.133.124, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1672931864; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=bOfXAW1jYF9pGPyLIBuu0BktPWz68ZlLdMDw0UTREsY=; b=JBY7EpKlcoWHxFekXv/uAUwEvJjFKWDK9O9Ap0+ofpT2zfCiUw/B2Z2Rr9YrEwOPzHoF8e J7swFvqXFZ7rF62ndoVI3LoEoGkqGrZp+klJ/ZPtyB2nD3IbZxC06pZB55nkwX07q4LL8W UNTUFJWugl1qR/7D2rzivBVzBlKsUko= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-630-NzLdE-yHMbmYeETBSsyRNw-1; Thu, 05 Jan 2023 10:17:41 -0500 X-MC-Unique: NzLdE-yHMbmYeETBSsyRNw-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 46B7E85C6E6; Thu, 5 Jan 2023 15:17:40 +0000 (UTC) Received: from [10.39.192.44] (unknown [10.39.192.44]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 04DFA2166B30; Thu, 5 Jan 2023 15:17:37 +0000 (UTC) Message-ID: Date: Thu, 5 Jan 2023 16:17:36 +0100 MIME-Version: 1.0 Subject: Re: [edk2-devel] [PATCH 0/1] OvmfPkg/PlatformInitLib: catch QEMU's CPU hotplug reg block regression From: "Laszlo Ersek" To: "Kinney, Michael D" , "devel@edk2.groups.io" , "Guo, Gua" Cc: Ard Biesheuvel , Brijesh Singh , "Aktas, Erdem" , Gerd Hoffmann , James Bottomley , "Yao, Jiewen" , "Justen, Jordan L" , "Xu, Min M" , "Boeuf, Sebastien" , Tom Lendacky References: <20230104151234.286030-1-lersek@redhat.com> In-Reply-To: X-Scanned-By: MIMEDefang 3.1 on 10.11.54.6 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit ugh, unless you meant the Build_VS2019_TARGET_CODE_COVERAGE and Build_GCC5_TARGET_CODE_COVERAGE test failures, which I mentioned in passing -- I agree that those don't look healthy. Thanks Laszlo On 1/5/23 16:15, Laszlo Ersek wrote: > Hi Mike, > > On 1/5/23 00:34, Kinney, Michael D wrote: >> Hi Laszlo, >> >> Unit test code coverage was enabled just a couple days ago in CI. Looks like you uncovered a corner case that was missed that should not generate a CI failure. >> >> I have asked Gua to investigate. > > the CI env is healthy, as far as I can tell. It's just that this patch > catches a grave bug in QEMU, and refuses continue booting if the bug is > present (intentionally). The issue is that currently there's no released > QEMU version with the fix, so if this patch is merged immediately into > OVMF, then OVMF will hang every test case in CI. (Every test scenario > that boots OVMF one way or another.) > > Practically, this patch must be postponed until QEMU can be upgraded in > the CI env -- it turns out though that the latter could be possible much > earlier than I had hoped. > > Thanks! > Laszlo > > > >> >> Thanks, >> >> Mike >> >>> -----Original Message----- >>> From: devel@edk2.groups.io On Behalf Of Laszlo Ersek >>> Sent: Wednesday, January 4, 2023 7:13 AM >>> To: devel@edk2.groups.io >>> Cc: Ard Biesheuvel ; Brijesh Singh ; Aktas, Erdem ; Gerd >>> Hoffmann ; James Bottomley ; Yao, Jiewen ; Justen, Jordan L >>> ; Xu, Min M ; Boeuf, Sebastien ; Tom Lendacky >>> >>> Subject: [edk2-devel] [PATCH 0/1] OvmfPkg/PlatformInitLib: catch QEMU's CPU hotplug reg block regression >>> >>> Repo: https://pagure.io/lersek/edk2.git >>> Branch: cpuhp-reg-catch-4250 >>> Test build: https://github.com/tianocore/edk2/pull/3853 >>> Bugzilla: https://bugzilla.tianocore.org/show_bug.cgi?id=4250 >>> >>> NOTE: the test build linked above (in the github.com CI env) *failed*. >>> That's because the CI environment is affected by this very QEMU bug! >>> >>> Namely, the following checks failed -- due to the intentional hang >>> introduced in this patch: >>> >>> - PlatformCI_OvmfPkg_Ubuntu_GCC5_PR (12 tests) >>> - PlatformCI_OvmfPkg_Windows_VS2019_PR (11 tests) >>> >>> (The Build_VS2019_TARGET_CODE_COVERAGE and >>> Build_GCC5_TARGET_CODE_COVERAGE tests also failed, but those seem bogus >>> to me.) >>> >>> All 12+11=23 PlatformCI_OvmfPkg_* checks failed due to timeout, and the >>> firmware logs of the DEBUG and NOOPT builds end with: >>> >>>> INFO - PlatformMaxCpuCountInitialization: Broken CPU hotplug register block: Present=0 Possible=1. >>>> INFO - PlatformMaxCpuCountInitialization: Switch QEMU's acceleration from TCG to KVM, or update QEMU. >>>> INFO - PlatformMaxCpuCountInitialization: Refer to . >>>> INFO - ASSERT /home/vsts/work/1/s/OvmfPkg/Library/PlatformInitLib/Platform.c(574): ((BOOLEAN)(0==1)) >>> >>> So I'm not proposing to merge this immediately; something must be fixed >>> first: >>> >>> - use KVM in the CI env, or >>> >>> - delay this patch until my QEMU fix is merged, and a new release is >>> made, and the new QEMU release is packaged by the distros, and the new >>> distro packages are picked up by github.com CI. >>> >>> Suggestions? >>> >>> Thanks, >>> Laszlo >>> >>> Cc: Ard Biesheuvel >>> Cc: Brijesh Singh >>> Cc: Erdem Aktas >>> Cc: Gerd Hoffmann >>> Cc: James Bottomley >>> Cc: Jiewen Yao >>> Cc: Jordan Justen >>> Cc: Min Xu >>> Cc: Sebastien Boeuf >>> Cc: Tom Lendacky >>> >>> Laszlo Ersek (1): >>> OvmfPkg/PlatformInitLib: catch QEMU's CPU hotplug reg block regression >>> >>> OvmfPkg/Library/PlatformInitLib/Platform.c | 34 ++++++++++++++++++++ >>> 1 file changed, 34 insertions(+) >>> >>> >>> >>> >>> >> >