From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=209.132.183.28; helo=mx1.redhat.com; envelope-from=lersek@redhat.com; receiver=edk2-devel@lists.01.org Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id B63B32194D3B8 for ; Wed, 26 Dec 2018 13:27:46 -0800 (PST) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 38C7C3E2D2; Wed, 26 Dec 2018 21:27:46 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-121-136.rdu2.redhat.com [10.10.121.136]) by smtp.corp.redhat.com (Postfix) with ESMTP id A686C19C7D; Wed, 26 Dec 2018 21:27:42 +0000 (UTC) To: Ard Biesheuvel , edk2-devel@lists.01.org References: <20181220173104.11481-1-ard.biesheuvel@linaro.org> <20181220173104.11481-4-ard.biesheuvel@linaro.org> From: Laszlo Ersek Message-ID: Date: Wed, 26 Dec 2018 22:27:41 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20181220173104.11481-4-ard.biesheuvel@linaro.org> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Wed, 26 Dec 2018 21:27:46 +0000 (UTC) Subject: Re: [PATCH 3/4] ArmPkg/DefaultExceptionHandlerLib: drop BASE variant X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 26 Dec 2018 21:27:46 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 12/20/18 18:31, Ard Biesheuvel wrote: > Drop the redundant BASE variant, which is no longer used anywhere > now that DebugAgentSymbolsBaseLib no longer incorporates a vector > table and exception handling. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ard Biesheuvel > --- > ArmPkg/ArmPkg.dsc | 1 - > ArmPkg/Library/DefaultExceptionHandlerLib/DefaultExceptionHandlerBase.c | 35 --------------- > ArmPkg/Library/DefaultExceptionHandlerLib/DefaultExceptionHandlerLibBase.inf | 45 -------------------- > ArmVirtPkg/ArmVirt.dsc.inc | 1 - > 4 files changed, 82 deletions(-) > > diff --git a/ArmPkg/ArmPkg.dsc b/ArmPkg/ArmPkg.dsc > index 5d83c18b143e..d9f9935d70b6 100644 > --- a/ArmPkg/ArmPkg.dsc > +++ b/ArmPkg/ArmPkg.dsc > @@ -141,7 +141,6 @@ > ArmPkg/Library/ArmGicArchSecLib/ArmGicArchSecLib.inf > ArmPkg/Library/ArmLib/ArmBaseLib.inf > ArmPkg/Library/ArmSoftFloatLib/ArmSoftFloatLib.inf > - ArmPkg/Library/DefaultExceptionHandlerLib/DefaultExceptionHandlerLibBase.inf > ArmPkg/Library/PeiServicesTablePointerLib/PeiServicesTablePointerLib.inf > ArmPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf > > diff --git a/ArmPkg/Library/DefaultExceptionHandlerLib/DefaultExceptionHandlerBase.c b/ArmPkg/Library/DefaultExceptionHandlerLib/DefaultExceptionHandlerBase.c > deleted file mode 100644 > index 4a54298b1189..000000000000 > --- a/ArmPkg/Library/DefaultExceptionHandlerLib/DefaultExceptionHandlerBase.c > +++ /dev/null > @@ -1,35 +0,0 @@ > -/** @file > - > - Copyright (c) 2012, ARM Ltd. All rights reserved.
> - > - This program and the accompanying materials > - are licensed and made available under the terms and conditions of the BSD License > - which accompanies this distribution. The full text of the license may be found at > - http://opensource.org/licenses/bsd-license.php > - > - THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS, > - WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED. > - > -**/ > - > -#include > - > -/** > - > - @param FaultAddress Address to find PE/COFF image for. > - @param ImageBase Return load address of found image > - @param PeCoffSizeOfHeaders Return the size of the PE/COFF header for the image that was found > - > - @retval NULL FaultAddress not in a loaded PE/COFF image. > - @retval Path and file name of PE/COFF image. > - > -**/ > -CHAR8 * > -GetImageName ( > - IN UINTN FaultAddress, > - OUT UINTN *ImageBase, > - OUT UINTN *PeCoffSizeOfHeaders > - ) > -{ > - return NULL; > -} > diff --git a/ArmPkg/Library/DefaultExceptionHandlerLib/DefaultExceptionHandlerLibBase.inf b/ArmPkg/Library/DefaultExceptionHandlerLib/DefaultExceptionHandlerLibBase.inf > deleted file mode 100644 > index b53a5e89f507..000000000000 > --- a/ArmPkg/Library/DefaultExceptionHandlerLib/DefaultExceptionHandlerLibBase.inf > +++ /dev/null > @@ -1,45 +0,0 @@ > -#/** @file > -# > -# Copyright (c) 2012, ARM Ltd. All rights reserved.
> -# > -# This program and the accompanying materials > -# are licensed and made available under the terms and conditions of the BSD License > -# which accompanies this distribution. The full text of the license may be found at > -# http://opensource.org/licenses/bsd-license.php > -# THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS, > -# WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED. > -# > -# > -#**/ > - > -[Defines] > - INF_VERSION = 0x00010005 > - BASE_NAME = DefaultExceptionHandlerBaseLib > - FILE_GUID = 3d5261d5-5eb7-4559-98e7-475aa9d0dc42 > - MODULE_TYPE = BASE > - VERSION_STRING = 1.0 > - LIBRARY_CLASS = DefaultExceptionHandlerLib > - > -[Sources.common] > - DefaultExceptionHandlerBase.c > - > -[Sources.ARM] > - Arm/DefaultExceptionHandler.c > - > -[Sources.AARCH64] > - AArch64/DefaultExceptionHandler.c > - > -[Packages] > - MdePkg/MdePkg.dec > - ArmPkg/ArmPkg.dec > - > -[LibraryClasses] > - BaseLib > - PrintLib > - DebugLib > - PeCoffGetEntryPointLib > - ArmDisassemblerLib > - SerialPortLib > - > -[Guids] > - gEfiDebugImageInfoTableGuid > diff --git a/ArmVirtPkg/ArmVirt.dsc.inc b/ArmVirtPkg/ArmVirt.dsc.inc > index 89c2db074711..c47955be940c 100644 > --- a/ArmVirtPkg/ArmVirt.dsc.inc > +++ b/ArmVirtPkg/ArmVirt.dsc.inc > @@ -174,7 +174,6 @@ > BaseMemoryLib|MdePkg/Library/BaseMemoryLib/BaseMemoryLib.inf > > DebugAgentLib|ArmPkg/Library/DebugAgentSymbolsBaseLib/DebugAgentSymbolsBaseLib.inf > - DefaultExceptionHandlerLib|ArmPkg/Library/DefaultExceptionHandlerLib/DefaultExceptionHandlerLibBase.inf > SerialPortLib|ArmVirtPkg/Library/FdtPL011SerialPortLib/EarlyFdtPL011SerialPortLib.inf > HobLib|MdePkg/Library/PeiHobLib/PeiHobLib.inf > PeiServicesLib|MdePkg/Library/PeiServicesLib/PeiServicesLib.inf > Can you split the ArmVirtPkg hunk to a separate patch? I think that, after patch #1, it should be possible to remove the [LibraryClasses.common.SEC] resolution from "ArmVirt.dsc.inc". Then the present patch can continue saying "... no longer used anywhere". Such a split would be more idiomatic to edk2, and also more faithful to the current subject line (which says "ArmPkg/DefaultExceptionHandlerLib: ..."). Thanks Laszlo