From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.120]) by mx.groups.io with SMTP id smtpd.web12.11.1571407565925564053 for ; Fri, 18 Oct 2019 07:06:06 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=UHTmIX89; spf=pass (domain: redhat.com, ip: 207.211.31.120, mailfrom: philmd@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1571407565; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=BfR3GoC/xkllh/W9DnuH9pJCT+ftSSBqMmYEgTrxgqI=; b=UHTmIX89D7yDbFKs2IZRBciftHfCOMQwxNlJbJy8j8MRqF7aT2ohIyndA6pbFeCs7puGX5 dUBO1V/4Tk6E//fPj4vHA6187Ja58nVpb9TOLdneYhqq40RB1mFCIBA/Dbxs3TX36/W8v2 zZKfbQkIh1BWIgzSBEVcMaLrZ5xRwKM= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-101--X0LEa8bOhaRjJ5mykfcWw-1; Fri, 18 Oct 2019 10:06:03 -0400 Received: by mail-wm1-f69.google.com with SMTP id z205so2798973wmb.7 for ; Fri, 18 Oct 2019 07:06:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=04glgTwYEigF8+noC2hpTPOjaJ4nrw+leaDYVabcF2U=; b=b7sWTU9FKP/a1FJUVDLoMkRGtWMXxX3cdHWISLhB/XjmcQSGLPB+alPua8NW7bP6c9 nPcXB9Vn5Ey/oXnFKa7wsZ4mshYwouOt2qE6zvoC+CW2NKhYs3E3+6UZQw+BA0Bwt7yS agCKHkUzjSuoJrVSyltSHr/IEwm5b02RxVqsQqOI+2C3aAt7Qzq7ExZmqIesZICL0bj/ pwV/bsKq/GaQNPq/DCeLWvoAmsUp+VmPXUOWLsujLeBo9hYuHk+J4qTjYFkMtD0mcqxB /5P9ynUNqx5ByJ0SjRocmYGBNmkmRUMb1S5axXUEQprMM5olVazwEkJE7NY13HHu+qkP L5Vw== X-Gm-Message-State: APjAAAW4M54gH0eKxXX/G+yo+GgwIQ4H3xmja678t+tMs/wZMQ4w2bN4 rzKqYrQAykKymF3WH+XelOHxPQK6E6WeBE8zmlRsCQlrMfxBLeNphB1b82HXGOq/BwOjfaJV1wH klUulyum4QbSqmw== X-Received: by 2002:a5d:5271:: with SMTP id l17mr8220763wrc.19.1571407561206; Fri, 18 Oct 2019 07:06:01 -0700 (PDT) X-Google-Smtp-Source: APXvYqz8gadfH6tPEkpE73tzDyEPelrJlkiYMeFGUv3LovBhTzZJupFJHehSdYk2haEXYy3semrtHw== X-Received: by 2002:a5d:5271:: with SMTP id l17mr8220739wrc.19.1571407560940; Fri, 18 Oct 2019 07:06:00 -0700 (PDT) Return-Path: Received: from [192.168.1.36] (14.red-88-21-201.staticip.rima-tde.net. [88.21.201.14]) by smtp.gmail.com with ESMTPSA id a204sm7322858wmh.21.2019.10.18.07.06.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 18 Oct 2019 07:06:00 -0700 (PDT) Subject: Re: [edk2-devel] [edk2-platforms][PATCH v2 1/1] Platform/RPi3: Add TFTP command to UEFI Shell To: devel@edk2.groups.io, pete@akeo.ie, Leif Lindholm Cc: ard.biesheuvel@linaro.org References: <20191018124130.8456-1-pete@akeo.ie> <20191018124130.8456-2-pete@akeo.ie> <20191018125205.GE25504@bivouac.eciton.net> <6b23a960-8af8-2ab3-69c8-454f3f0eef37@akeo.ie> From: =?UTF-8?B?UGhpbGlwcGUgTWF0aGlldS1EYXVkw6k=?= Message-ID: Date: Fri, 18 Oct 2019 16:05:59 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.1 MIME-Version: 1.0 In-Reply-To: <6b23a960-8af8-2ab3-69c8-454f3f0eef37@akeo.ie> X-MC-Unique: -X0LEa8bOhaRjJ5mykfcWw-1 X-Mimecast-Spam-Score: 0 Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable On 10/18/19 3:25 PM, Pete Batard wrote: > On 2019.10.18 13:52, Leif Lindholm wrote: >> On Fri, Oct 18, 2019 at 01:41:30PM +0100, Pete Batard wrote: >>> TFTP support, which is enabled by default, can be disabled by setting >>> INCLUDE_TFTP_COMMAND to FALSE. >> >> Would you be OK with flipping the default to FALSE? >=20 > Yes, I have no issue with a default set to FALSE. >=20 >> It is a custom extension not described by the UEFI Shell >> Specification. >> >> I could flip the logic in the DEFINE and commit message if so, no need >> for a v3. >=20 > If you can do that, that would be great. Thanks! Reviewed-by: Philippe Mathieu-Daude >=20 > /Pete >=20 >> >> Regards, >> >> Leif >> >>> Signed-off-by: Pete Batard >>> --- >>> =C2=A0 Platform/RaspberryPi/RPi3/RPi3.dsc | 8 ++++++++ >>> =C2=A0 Platform/RaspberryPi/RPi3/RPi3.fdf | 3 +++ >>> =C2=A0 2 files changed, 11 insertions(+) >>> >>> diff --git a/Platform/RaspberryPi/RPi3/RPi3.dsc=20 >>> b/Platform/RaspberryPi/RPi3/RPi3.dsc >>> index bc424a06bb45..2289ad8c2ed2 100644 >>> --- a/Platform/RaspberryPi/RPi3/RPi3.dsc >>> +++ b/Platform/RaspberryPi/RPi3/RPi3.dsc >>> @@ -36,6 +36,7 @@ [Defines] >>> =C2=A0=C2=A0=C2=A0 # -D FLAG=3DVALUE >>> =C2=A0=C2=A0=C2=A0 # >>> =C2=A0=C2=A0=C2=A0 DEFINE SECURE_BOOT_ENABLE=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0 =3D FALSE >>> +=C2=A0 DEFINE INCLUDE_TFTP_COMMAND=C2=A0=C2=A0=C2=A0 =3D TRUE >>> =C2=A0=C2=A0=C2=A0 DEFINE DEBUG_PRINT_ERROR_LEVEL =3D 0x8000004F >>> =20 >>> ######################################################################= ##########=20 >>> >>> @@ -181,6 +182,10 @@ [LibraryClasses.common.DXE_DRIVER] >>> =20 >>> SecurityManagementLib|MdeModulePkg/Library/DxeSecurityManagementLib/Dx= eSecurityManagementLib.inf=20 >>> >>> =20 >>> PerformanceLib|MdeModulePkg/Library/DxePerformanceLib/DxePerformanceLi= b.inf=20 >>> >>> =20 >>> MemoryAllocationLib|MdePkg/Library/UefiMemoryAllocationLib/UefiMemoryA= llocationLib.inf=20 >>> >>> +!if $(INCLUDE_TFTP_COMMAND) =3D=3D TRUE >>> +=C2=A0 ShellLib|ShellPkg/Library/UefiShellLib/UefiShellLib.inf >>> +=C2=A0 FileHandleLib|MdePkg/Library/UefiFileHandleLib/UefiFileHandleL= ib.inf >>> +!endif >>> =C2=A0 [LibraryClasses.common.UEFI_APPLICATION] >>> =20 >>> PerformanceLib|MdeModulePkg/Library/DxePerformanceLib/DxePerformanceLi= b.inf=20 >>> >>> @@ -616,3 +621,6 @@ [Components.common] >>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 gEfiMdePkgTokenSpaceGuid.Pc= dUefiLibMaxPrintBufferSize|8000 >>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 gEfiShellPkgTokenSpaceGuid.= PcdShellFileOperationSize|0x200000 >>> =C2=A0=C2=A0=C2=A0 } >>> +!if $(INCLUDE_TFTP_COMMAND) =3D=3D TRUE >>> +=C2=A0 ShellPkg/DynamicCommand/TftpDynamicCommand/TftpDynamicCommand.= inf >>> +!endif >>> diff --git a/Platform/RaspberryPi/RPi3/RPi3.fdf=20 >>> b/Platform/RaspberryPi/RPi3/RPi3.fdf >>> index 17c0094ac1cf..b06a15fb8ec3 100644 >>> --- a/Platform/RaspberryPi/RPi3/RPi3.fdf >>> +++ b/Platform/RaspberryPi/RPi3/RPi3.fdf >>> @@ -232,6 +232,9 @@ [FV.FvMain] >>> =C2=A0=C2=A0=C2=A0 # UEFI application (Shell Embedded Boot Loader) >>> =C2=A0=C2=A0=C2=A0 # >>> =C2=A0=C2=A0=C2=A0 INF ShellPkg/Application/Shell/Shell.inf >>> +!if $(INCLUDE_TFTP_COMMAND) =3D=3D TRUE >>> +=C2=A0 INF ShellPkg/DynamicCommand/TftpDynamicCommand/TftpDynamicComm= and.inf >>> +!endif >>> =C2=A0=C2=A0=C2=A0 # >>> =C2=A0=C2=A0=C2=A0 # ACPI Support >>> --=20 >>> 2.21.0.windows.1 >>> >=20 >=20 >=20 >=20