From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f53.google.com (mail-ed1-f53.google.com [209.85.208.53]) by mx.groups.io with SMTP id smtpd.web12.123.1599843858003926190 for ; Fri, 11 Sep 2020 10:04:18 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@broadcom.com header.s=google header.b=DCa6sDGK; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: broadcom.com, ip: 209.85.208.53, mailfrom: vladimir.olovyannikov@broadcom.com) Received: by mail-ed1-f53.google.com with SMTP id t16so10745470edw.7 for ; Fri, 11 Sep 2020 10:04:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=from:references:in-reply-to:mime-version:thread-index:date :message-id:subject:to:cc; bh=3g1/t3ChF1Fxk//nEpaP8qmv6pZ39icDPpYD6+PqkcM=; b=DCa6sDGKm8j4wXnC23jvacBCCDn4zwZaOGanx7ZHu/duwbhUYsFpMx0EEsAAisiaQy n/7UGyuyMbBqGzDSkiTvDEFK8jaZ2iXS0KQkVisElQBOlZM1XFR2FS9aqqhayhUKGREk 7cgQ/rN3LfCn4Gh4GPzpiwuun/JZyNVyZFokY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:references:in-reply-to:mime-version :thread-index:date:message-id:subject:to:cc; bh=3g1/t3ChF1Fxk//nEpaP8qmv6pZ39icDPpYD6+PqkcM=; b=CD6EV2Ca6DeEoZvfOEz353Fx8rlf30wl64U4hkiwr7lT0Y7NzUy287N5PUcA4o/jHT PRj8+1l66N7zIIZuxc2kX8r+iJV3IOP6sy4oPG4eBrQRnBL1970Yzmsnsnl8KUbD80bj pr3eKCVqWYd6/zGe6i7nVLxzScsgn7voQifs5xJh3A65I4/u8wYEx/LccTmKuFj7E5Ys A+9mC7iTSlrbAOeTezKxCDyC8ybx42mPSdf/EJMyKLCTOfvGA++5pZDbNJV2WkJOYgZe 3nHGVHvJjz2cZbl5cCNdsPN9+juZNPOT4zyp43O5P2tB9TGTxF2XqOhUmpOG/qQvoOrD QHRg== X-Gm-Message-State: AOAM530Q1dKQc8cFPvmZFkMY5TBnKR1ZtDb6DyLWMtLoVUUX6ydnY0Qi 8w/Ck18cCrPagT3usSwSAC2EnNMAQ+H6URZ0wXsTug== X-Google-Smtp-Source: ABdhPJzJra0alOmujVyjDJXJgMtkV54lVgp54yfqxdLSloVb93XTWjOQ9xJXvuU66aqXC0tpkN5GW8C5aGNW59BH7ng= X-Received: by 2002:a05:6402:696:: with SMTP id f22mr3121319edy.290.1599843856258; Fri, 11 Sep 2020 10:04:16 -0700 (PDT) From: "Vladimir Olovyannikov" References: <20200909184904.11129-1-vladimir.olovyannikov@broadcom.com> In-Reply-To: MIME-Version: 1.0 X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQHg3JNJWCcY2YJbD7AEaGyhEZCY1wHe2KTlAVY+060CMMVIw6kj0YZw Date: Fri, 11 Sep 2020 10:04:14 -0700 Message-ID: Subject: Re: [PATCH v11 0/1] ShellPkg/DynamicCommand: add HttpDynamicCommand To: Laszlo Ersek , devel@edk2.groups.io Cc: Zhichao Gao , Maciej Rabeda , Jiaxin Wu , Siyuan Fu , Ray Ni , Liming Gao , Nd , Samer El-Haj-Mahmoud Content-Type: text/plain; charset="UTF-8" > -----Original Message----- > From: Laszlo Ersek > Sent: Friday, September 11, 2020 12:20 AM > To: Vladimir Olovyannikov ; > devel@edk2.groups.io > Cc: Zhichao Gao ; Maciej Rabeda > ; Jiaxin Wu ; Siyuan > Fu ; Ray Ni ; Liming Gao > ; Nd ; Samer El-Haj-Mahmoud > > Subject: Re: [PATCH v11 0/1] ShellPkg/DynamicCommand: add > HttpDynamicCommand > > On 09/10/20 22:33, Vladimir Olovyannikov wrote: > > Hi Laszlo, > > > >> -----Original Message----- > >> From: Laszlo Ersek > >> Sent: Wednesday, September 9, 2020 11:33 PM > > >>> PATCH v11 changes: > >>> Address comments from Laszlo: > >>> - use TimeBaseLib.h header to get rid of duplicated constants; > >>> - explicitly return UINT32 in EfiTimeToEpoch(). > >> > >> to be clear, I explicitly *disagree* with returning UINT32 from > >> EfiTimeToEpoch(). > >> > >> I'm not "demanding" (or even suggesting) that you update the > >> EfiTimeToEpoch() implementation in this patch to return UINTN, but > >> I'd like to be very clear that, IMO, for EfiTimeToEpoch() to suffer > >> from a year 2106 problem on 64-bit systems too, is bad design. So > >> please don't list the UINT32 return type as my suggestion -- that's > >> the exact opposite of what I'd actually suggest. > > > Sorry, I must have misunderstood. Do you want me to resubmit the > > patch? I am open to ideas. > > Ideally: > > - change the return type of EfiTimeToEpoch() to UNITN > > - drop the final UINT32 cast from EfiTimeToEpoch() > > - change the type of ElapsedSeconds to UINTN > > - change the expression > > ElapsedSeconds > 1 ? ElapsedSeconds : 1 > > to > > ElapsedSeconds > 1 ? (UINT64)ElapsedSeconds : 1 > > - print the expression mentioned above with the format specifier %Lu I see. Basically, it is PATCH v10. I just wanted to reuse TimeBaseLib.h constants in PATCH v11. > > *BUT*. These are really just small details. It would be OK to fix these up > later, > incrementally. Where I see a real problem is the lack of timely feedback > from > the ShellPkg maintainers. Agreed. Hopefully, it can be reviewed sometime soon. Thank you, Vladimir > > Laszlo