From: "Rebecca Cran" <rebecca@bsdio.com>
To: Marcin Wojtas <mw@semihalf.com>
Cc: devel@edk2.groups.io, Leif Lindholm <quic_llindhol@quicinc.com>
Subject: Re: [PATCH edk2-platforms 1/1] Silicon/Marvell: Fix setting I2cStatus in MvI2cEnableConf
Date: Wed, 10 May 2023 16:37:12 -0600 [thread overview]
Message-ID: <b8559faf-8fcb-e81c-bec2-3c147b4e82eb@bsdio.com> (raw)
In-Reply-To: <CAPv3WKekE7_ac0ukYRDQUgY-xqBrm5jbjJxzvW4ezJ6ACyH8aw@mail.gmail.com>
Pushed as 1f8ff3b1c03fab1fc5af285c2d939904e560c1c2.
On 5/10/23 15:56, Marcin Wojtas wrote:
> śr., 10 maj 2023 o 17:38 Rebecca Cran <rebecca@bsdio.com> napisał(a):
>> Fix setting I2cStatus in MvI2cEnableConf.
>>
>> Signed-off-by: Rebecca Cran <rebecca@bsdio.com>
>> ---
>> Silicon/Marvell/Drivers/I2c/MvI2cDxe/MvI2cDxe.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/Silicon/Marvell/Drivers/I2c/MvI2cDxe/MvI2cDxe.c b/Silicon/Marvell/Drivers/I2c/MvI2cDxe/MvI2cDxe.c
>> index b4dda56bbd2f..a8ff722aab22 100755
>> --- a/Silicon/Marvell/Drivers/I2c/MvI2cDxe/MvI2cDxe.c
>> +++ b/Silicon/Marvell/Drivers/I2c/MvI2cDxe/MvI2cDxe.c
>> @@ -777,7 +777,7 @@ MvI2cEnableConf (
>> {
>> /* do nothing */
>> if (I2cStatus != NULL)
>> - I2cStatus = EFI_SUCCESS;
>> + *I2cStatus = EFI_SUCCESS;
>> if (Event != NULL)
>> gBS->SignalEvent(Event);
>> return EFI_SUCCESS;
>> --
>> 2.39.2
>>
> Reviewed-by: Marcin Wojtas <mw@semihalf.com>
>
> Thanks!
> Marcin
prev parent reply other threads:[~2023-05-10 22:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-10 15:37 [PATCH edk2-platforms 1/1] Silicon/Marvell: Fix setting I2cStatus in MvI2cEnableConf Rebecca Cran
2023-05-10 21:56 ` Marcin Wojtas
2023-05-10 22:37 ` Rebecca Cran [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b8559faf-8fcb-e81c-bec2-3c147b4e82eb@bsdio.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox