From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=66.187.233.73; helo=mx1.redhat.com; envelope-from=lersek@redhat.com; receiver=edk2-devel@lists.01.org Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id ABAEF21ED1C66 for ; Wed, 7 Mar 2018 12:21:54 -0800 (PST) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 6FA3876FB9; Wed, 7 Mar 2018 20:28:09 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-123-198.rdu2.redhat.com [10.10.123.198]) by smtp.corp.redhat.com (Postfix) with ESMTP id AD3A01102E2A; Wed, 7 Mar 2018 20:28:08 +0000 (UTC) To: "Gao, Liming" , Ard Biesheuvel Cc: edk2-devel-01 , "Zhu, Yonghong" References: <20180307093259.7682-1-lersek@redhat.com> <4A89E2EF3DFEDB4C8BFDE51014F606A14E1D8C04@SHSMSX104.ccr.corp.intel.com> From: Laszlo Ersek Message-ID: Date: Wed, 7 Mar 2018 21:28:08 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <4A89E2EF3DFEDB4C8BFDE51014F606A14E1D8C04@SHSMSX104.ccr.corp.intel.com> X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.1]); Wed, 07 Mar 2018 20:28:09 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.1]); Wed, 07 Mar 2018 20:28:09 +0000 (UTC) for IP:'10.11.54.3' DOMAIN:'int-mx03.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'lersek@redhat.com' RCPT:'' Subject: Re: [PATCH] BaseTools/header.makefile: revert gcc-8 "-Wno-xxx" options on OSX X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Mar 2018 20:21:55 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 03/07/18 12:51, Gao, Liming wrote: > Reviewed-by: Liming Gao Thank you, Liming. Ard, are you OK with this patch as well? Thanks Laszlo >> -----Original Message----- >> From: Laszlo Ersek [mailto:lersek@redhat.com] >> Sent: Wednesday, March 7, 2018 5:33 PM >> To: edk2-devel-01 >> Cc: Gao, Liming ; Zhu, Yonghong >> Subject: [PATCH] BaseTools/header.makefile: revert gcc-8 "-Wno-xxx" options on OSX >> >> I recently added the gcc-8 specific "-Wno-stringop-truncation" and >> "-Wno-restrict" options to BUILD_CFLAGS, both for "Darwin" (XCODE5 / >> clang, OSX) and otherwise (gcc, Linux / Cygwin). >> >> I also regression-tested the change with gcc-4.8 on Linux -- gcc-4.8 does >> not know either of the (gcc-8 specific) "-Wno-stringop-truncation" and >> "-Wno-restrict" options, yet the build completed fine (by GCC design). >> >> Regarding OSX, my expectation was that >> >> - XCODE5 / clang would either recognize these warnings options (because >> clang does recognize most -W options of gcc), >> >> - or, similarly to gcc, clang would simply ignore the "-Wno-xxx" flags >> that it didn't recognize. >> >> Neither is the case; the new flags have broken the BaseTools build on OSX. >> Revert them (for OSX only). >> >> Cc: Liming Gao >> Cc: Yonghong Zhu >> Reported-by: Liming Gao >> Fixes: 1d212a83df0eaf32a6f5d4159beb2d77832e0231 >> Fixes: 9222154ae7b3eef75ae88cdb56158256227cb929 >> Contributed-under: TianoCore Contribution Agreement 1.1 >> Signed-off-by: Laszlo Ersek >> --- >> BaseTools/Source/C/Makefiles/header.makefile | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/BaseTools/Source/C/Makefiles/header.makefile b/BaseTools/Source/C/Makefiles/header.makefile >> index 065a998bf5de..db436773cf40 100644 >> --- a/BaseTools/Source/C/Makefiles/header.makefile >> +++ b/BaseTools/Source/C/Makefiles/header.makefile >> @@ -71,7 +71,7 @@ INCLUDE = $(TOOL_INCLUDE) -I $(MAKEROOT) -I $(MAKEROOT)/Include/Common -I $(MAKE >> BUILD_CPPFLAGS = $(INCLUDE) -O2 >> ifeq ($(DARWIN),Darwin) >> # assume clang or clang compatible flags on OS X >> -BUILD_CFLAGS = -MD -fshort-wchar -fno-strict-aliasing -Wall -Werror -Wno-deprecated-declarations -Wno-stringop-truncation >> -Wno-restrict -Wno-self-assign -Wno-unused-result -nostdlib -c -g >> +BUILD_CFLAGS = -MD -fshort-wchar -fno-strict-aliasing -Wall -Werror -Wno-deprecated-declarations -Wno-self-assign >> -Wno-unused-result -nostdlib -c -g >> else >> BUILD_CFLAGS = -MD -fshort-wchar -fno-strict-aliasing -Wall -Werror -Wno-deprecated-declarations -Wno-stringop-truncation >> -Wno-restrict -Wno-unused-result -nostdlib -c -g >> endif >> -- >> 2.14.1.3.gb7cf6e02401b >