From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by mx.groups.io with SMTP id smtpd.web11.6690.1616494186203687842 for ; Tue, 23 Mar 2021 03:09:46 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=ch9nuzAk; spf=pass (domain: redhat.com, ip: 63.128.21.124, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1616494185; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/0vtqGeTzvs+3SmC2W9rlCHIM8hClXDvkBsZWxccuDY=; b=ch9nuzAkAA8rFdQvWNfoZvJzHyDiBhpKk96NGXAl6MXRB8qVMTiY+Xkcz9Ept4FD8RzOp0 sW41rLSIR7AgeMO2V/AHRUxkaDOb/W7imTCi5LY6TyhpEfk4ogB9fjYtwiZTEVTXIUm03B go9imnsOCTSAvu0GSUQjjdn9HmztzKA= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-578-51Lw5HtDMe-coDcG3lp5xg-1; Tue, 23 Mar 2021 06:09:43 -0400 X-MC-Unique: 51Lw5HtDMe-coDcG3lp5xg-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 5088D81626; Tue, 23 Mar 2021 10:09:42 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-114-240.ams2.redhat.com [10.36.114.240]) by smtp.corp.redhat.com (Postfix) with ESMTP id 2BE4410074FC; Tue, 23 Mar 2021 10:09:40 +0000 (UTC) Subject: Re: [PATCH] UefiCpuPkg/SmmCommunication: Remove out-dated comments To: Ray Ni , devel@edk2.groups.io Cc: Eric Dong , Rahul Kumar References: <20210323011527.437-1-ray.ni@intel.com> From: "Laszlo Ersek" Message-ID: Date: Tue, 23 Mar 2021 11:09:40 +0100 MIME-Version: 1.0 In-Reply-To: <20210323011527.437-1-ray.ni@intel.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=lersek@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 03/23/21 02:15, Ray Ni wrote: > The comments in PiSmmCommunicationPei.c describe the whole memory > layout of the SMRAM regarding the SMM communication. > > But SHA-1: 8b1d14939053b63d80355465649c50f9f391a64a > PiSmmCommunicationSmm: Deprecate SMM Communication ACPI Table > removed the code that produces the ACPI Table. > > This change updates the accordingly comments. > > Signed-off-by: Ray Ni > Cc: Eric Dong > Cc: Laszlo Ersek > Cc: Rahul Kumar > --- > .../PiSmmCommunication/PiSmmCommunicationPei.c | 16 +++++----------- > 1 file changed, 5 insertions(+), 11 deletions(-) > > diff --git a/UefiCpuPkg/PiSmmCommunication/PiSmmCommunicationPei.c b/UefiCpuPkg/PiSmmCommunication/PiSmmCommunicationPei.c > index 68e5003ad4..110165b20b 100644 > --- a/UefiCpuPkg/PiSmmCommunication/PiSmmCommunicationPei.c > +++ b/UefiCpuPkg/PiSmmCommunication/PiSmmCommunicationPei.c > @@ -1,7 +1,7 @@ > /** @file > PiSmmCommunication PEI Driver. > > -Copyright (c) 2010 - 2015, Intel Corporation. All rights reserved.
> +Copyright (c) 2010 - 2021, Intel Corporation. All rights reserved.
> SPDX-License-Identifier: BSD-2-Clause-Patent > > **/ > @@ -47,16 +47,10 @@ SPDX-License-Identifier: BSD-2-Clause-Patent > +----------------------------------+<-- > | EFI_SMM_COMMUNICATION_CONTEXT | > | SwSmiNumber | <- SMRAM > - | BufferPtrAddress |---------------- > - +----------------------------------+ | > - | > - +----------------------------------+ | > - | EFI_SMM_COMMUNICATION_ACPI_TABLE | | > - | SwSmiNumber | <- AcpiTable | > - | BufferPtrAddress |--- | > - +----------------------------------+ | | > - | | > - +----------------------------------+<--------------- > + | BufferPtrAddress |--- > + +----------------------------------+ | > + | > + +----------------------------------+<-- > | Communication Buffer Pointer | <- AcpiNvs > +----------------------------------+--- > | > Acked-by: Laszlo Ersek