* [PATCH] UefiCpuPkg/SmmCommunication: Remove out-dated comments
@ 2021-03-23 1:15 Ni, Ray
2021-03-23 10:09 ` Laszlo Ersek
2021-03-23 13:48 ` Dong, Eric
0 siblings, 2 replies; 3+ messages in thread
From: Ni, Ray @ 2021-03-23 1:15 UTC (permalink / raw)
To: devel; +Cc: Eric Dong, Laszlo Ersek, Rahul Kumar
The comments in PiSmmCommunicationPei.c describe the whole memory
layout of the SMRAM regarding the SMM communication.
But SHA-1: 8b1d14939053b63d80355465649c50f9f391a64a
PiSmmCommunicationSmm: Deprecate SMM Communication ACPI Table
removed the code that produces the ACPI Table.
This change updates the accordingly comments.
Signed-off-by: Ray Ni <ray.ni@intel.com>
Cc: Eric Dong <eric.dong@intel.com>
Cc: Laszlo Ersek <lersek@redhat.com>
Cc: Rahul Kumar <rahul1.kumar@intel.com>
---
.../PiSmmCommunication/PiSmmCommunicationPei.c | 16 +++++-----------
1 file changed, 5 insertions(+), 11 deletions(-)
diff --git a/UefiCpuPkg/PiSmmCommunication/PiSmmCommunicationPei.c b/UefiCpuPkg/PiSmmCommunication/PiSmmCommunicationPei.c
index 68e5003ad4..110165b20b 100644
--- a/UefiCpuPkg/PiSmmCommunication/PiSmmCommunicationPei.c
+++ b/UefiCpuPkg/PiSmmCommunication/PiSmmCommunicationPei.c
@@ -1,7 +1,7 @@
/** @file
PiSmmCommunication PEI Driver.
-Copyright (c) 2010 - 2015, Intel Corporation. All rights reserved.<BR>
+Copyright (c) 2010 - 2021, Intel Corporation. All rights reserved.<BR>
SPDX-License-Identifier: BSD-2-Clause-Patent
**/
@@ -47,16 +47,10 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
+----------------------------------+<--
| EFI_SMM_COMMUNICATION_CONTEXT |
| SwSmiNumber | <- SMRAM
- | BufferPtrAddress |----------------
- +----------------------------------+ |
- |
- +----------------------------------+ |
- | EFI_SMM_COMMUNICATION_ACPI_TABLE | |
- | SwSmiNumber | <- AcpiTable |
- | BufferPtrAddress |--- |
- +----------------------------------+ | |
- | |
- +----------------------------------+<---------------
+ | BufferPtrAddress |---
+ +----------------------------------+ |
+ |
+ +----------------------------------+<--
| Communication Buffer Pointer | <- AcpiNvs
+----------------------------------+---
|
--
2.27.0.windows.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] UefiCpuPkg/SmmCommunication: Remove out-dated comments
2021-03-23 1:15 [PATCH] UefiCpuPkg/SmmCommunication: Remove out-dated comments Ni, Ray
@ 2021-03-23 10:09 ` Laszlo Ersek
2021-03-23 13:48 ` Dong, Eric
1 sibling, 0 replies; 3+ messages in thread
From: Laszlo Ersek @ 2021-03-23 10:09 UTC (permalink / raw)
To: Ray Ni, devel; +Cc: Eric Dong, Rahul Kumar
On 03/23/21 02:15, Ray Ni wrote:
> The comments in PiSmmCommunicationPei.c describe the whole memory
> layout of the SMRAM regarding the SMM communication.
>
> But SHA-1: 8b1d14939053b63d80355465649c50f9f391a64a
> PiSmmCommunicationSmm: Deprecate SMM Communication ACPI Table
> removed the code that produces the ACPI Table.
>
> This change updates the accordingly comments.
>
> Signed-off-by: Ray Ni <ray.ni@intel.com>
> Cc: Eric Dong <eric.dong@intel.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Rahul Kumar <rahul1.kumar@intel.com>
> ---
> .../PiSmmCommunication/PiSmmCommunicationPei.c | 16 +++++-----------
> 1 file changed, 5 insertions(+), 11 deletions(-)
>
> diff --git a/UefiCpuPkg/PiSmmCommunication/PiSmmCommunicationPei.c b/UefiCpuPkg/PiSmmCommunication/PiSmmCommunicationPei.c
> index 68e5003ad4..110165b20b 100644
> --- a/UefiCpuPkg/PiSmmCommunication/PiSmmCommunicationPei.c
> +++ b/UefiCpuPkg/PiSmmCommunication/PiSmmCommunicationPei.c
> @@ -1,7 +1,7 @@
> /** @file
> PiSmmCommunication PEI Driver.
>
> -Copyright (c) 2010 - 2015, Intel Corporation. All rights reserved.<BR>
> +Copyright (c) 2010 - 2021, Intel Corporation. All rights reserved.<BR>
> SPDX-License-Identifier: BSD-2-Clause-Patent
>
> **/
> @@ -47,16 +47,10 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
> +----------------------------------+<--
> | EFI_SMM_COMMUNICATION_CONTEXT |
> | SwSmiNumber | <- SMRAM
> - | BufferPtrAddress |----------------
> - +----------------------------------+ |
> - |
> - +----------------------------------+ |
> - | EFI_SMM_COMMUNICATION_ACPI_TABLE | |
> - | SwSmiNumber | <- AcpiTable |
> - | BufferPtrAddress |--- |
> - +----------------------------------+ | |
> - | |
> - +----------------------------------+<---------------
> + | BufferPtrAddress |---
> + +----------------------------------+ |
> + |
> + +----------------------------------+<--
> | Communication Buffer Pointer | <- AcpiNvs
> +----------------------------------+---
> |
>
Acked-by: Laszlo Ersek <lersek@redhat.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] UefiCpuPkg/SmmCommunication: Remove out-dated comments
2021-03-23 1:15 [PATCH] UefiCpuPkg/SmmCommunication: Remove out-dated comments Ni, Ray
2021-03-23 10:09 ` Laszlo Ersek
@ 2021-03-23 13:48 ` Dong, Eric
1 sibling, 0 replies; 3+ messages in thread
From: Dong, Eric @ 2021-03-23 13:48 UTC (permalink / raw)
To: Ni, Ray, devel@edk2.groups.io; +Cc: Laszlo Ersek, Kumar, Rahul1
Reviewed-by: Eric Dong <eric.dong@intel.com>
-----Original Message-----
From: Ni, Ray <ray.ni@intel.com>
Sent: Tuesday, March 23, 2021 9:15 AM
To: devel@edk2.groups.io
Cc: Dong, Eric <eric.dong@intel.com>; Laszlo Ersek <lersek@redhat.com>; Kumar, Rahul1 <rahul1.kumar@intel.com>
Subject: [PATCH] UefiCpuPkg/SmmCommunication: Remove out-dated comments
The comments in PiSmmCommunicationPei.c describe the whole memory
layout of the SMRAM regarding the SMM communication.
But SHA-1: 8b1d14939053b63d80355465649c50f9f391a64a
PiSmmCommunicationSmm: Deprecate SMM Communication ACPI Table
removed the code that produces the ACPI Table.
This change updates the accordingly comments.
Signed-off-by: Ray Ni <ray.ni@intel.com>
Cc: Eric Dong <eric.dong@intel.com>
Cc: Laszlo Ersek <lersek@redhat.com>
Cc: Rahul Kumar <rahul1.kumar@intel.com>
---
.../PiSmmCommunication/PiSmmCommunicationPei.c | 16 +++++-----------
1 file changed, 5 insertions(+), 11 deletions(-)
diff --git a/UefiCpuPkg/PiSmmCommunication/PiSmmCommunicationPei.c b/UefiCpuPkg/PiSmmCommunication/PiSmmCommunicationPei.c
index 68e5003ad4..110165b20b 100644
--- a/UefiCpuPkg/PiSmmCommunication/PiSmmCommunicationPei.c
+++ b/UefiCpuPkg/PiSmmCommunication/PiSmmCommunicationPei.c
@@ -1,7 +1,7 @@
/** @file
PiSmmCommunication PEI Driver.
-Copyright (c) 2010 - 2015, Intel Corporation. All rights reserved.<BR>
+Copyright (c) 2010 - 2021, Intel Corporation. All rights reserved.<BR>
SPDX-License-Identifier: BSD-2-Clause-Patent
**/
@@ -47,16 +47,10 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
+----------------------------------+<--
| EFI_SMM_COMMUNICATION_CONTEXT |
| SwSmiNumber | <- SMRAM
- | BufferPtrAddress |----------------
- +----------------------------------+ |
- |
- +----------------------------------+ |
- | EFI_SMM_COMMUNICATION_ACPI_TABLE | |
- | SwSmiNumber | <- AcpiTable |
- | BufferPtrAddress |--- |
- +----------------------------------+ | |
- | |
- +----------------------------------+<---------------
+ | BufferPtrAddress |---
+ +----------------------------------+ |
+ |
+ +----------------------------------+<--
| Communication Buffer Pointer | <- AcpiNvs
+----------------------------------+---
|
--
2.27.0.windows.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-03-23 13:48 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-03-23 1:15 [PATCH] UefiCpuPkg/SmmCommunication: Remove out-dated comments Ni, Ray
2021-03-23 10:09 ` Laszlo Ersek
2021-03-23 13:48 ` Dong, Eric
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox