From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by mx.groups.io with SMTP id smtpd.web12.9079.1613745024666062354 for ; Fri, 19 Feb 2021 06:30:25 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=H4a3EN0B; spf=pass (domain: redhat.com, ip: 63.128.21.124, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1613745023; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rbOQePrfWOtI4Ybf65Uj2ufagSxA5cybGUDHab/d6sk=; b=H4a3EN0Bu1b0Xr6ksouTzWL4OwQH0VMEpeFm18yqjWw6sNWMuzVTRZ/6cGeb25jgN5HNOJ ell+bJYkcnP7J168H63fjNCnadzDI7Fj/z5y3BxZ0zJyTAWnAeqNXDMWipjWUnBv1OattC +MQhoS87T4iNZelcLAwtkZ6o/Z31X5Q= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-310-pgXWE07dPaadcmHd7iQg4g-1; Fri, 19 Feb 2021 09:30:19 -0500 X-MC-Unique: pgXWE07dPaadcmHd7iQg4g-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 4D560107ACE6; Fri, 19 Feb 2021 14:30:18 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-113-87.ams2.redhat.com [10.36.113.87]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4A74E63B8C; Fri, 19 Feb 2021 14:30:17 +0000 (UTC) Subject: Re: [edk2-devel] [PATCH v1 1/1] BaseTools: Update the NASM dependency To: Bret Barkelew , gaoliming Cc: devel@edk2.groups.io References: <20210212204926.1114-1-bret.barkelew@microsoft.com> <9dd900ea-5b9f-aa54-04b9-cddf4a0f3ede@redhat.com> <000f01d705a7$9c1c59e0$d4550da0$@byosoft.com.cn> From: "Laszlo Ersek" Message-ID: Date: Fri, 19 Feb 2021 15:30:16 +0100 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=lersek@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 02/18/21 05:07, Bret Barkelew wrote: > I'm not opposed to moving to 2.15.03 for consistency, but we'll have to > publish a new package. This one is already pushed to Nuget. Thanks for the answers. From Liming's answer, I understand we don't try to keep CI strictly in sync with edk2's (internal) BaseTools. So the patch should be fine; however, I think the subject line could be clarified. "BaseTools: Update the NASM dependency" doesn't make it clear that the CI builds are targeted primarily. Thanks Laszlo > > On Wed, Feb 17, 2021 at 7:39 PM gaoliming wrote: > >> Laszlo: >> >>> -----邮件原件----- >>> 发件人: bounce+27952+71686+4905953+8761045@groups.io >>> 代表 Laszlo Ersek >>> 发送时间: 2021年2月16日 5:00 >>> 收件人: devel@edk2.groups.io; bret@corthon.com >>> 主题: Re: [edk2-devel] [PATCH v1 1/1] BaseTools: Update the NASM >>> dependency >>> >>> Hi Bret, >>> >>> On 02/12/21 21:49, Bret Barkelew wrote: >>>> This is primarily used by CI builds, but may also be used by platforms. >>>> >>>> Update NASM to support newer structures and features, as agreed in >> recent >>>> community meetings: >>>> https://edk2.groups.io/g/devel/message/71289 >>>> --- >>>> BaseTools/Bin/nasm_ext_dep.yaml | 2 +- >>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>> >>>> diff --git a/BaseTools/Bin/nasm_ext_dep.yaml >>> b/BaseTools/Bin/nasm_ext_dep.yaml >>>> index 60b1f71b56aa..56703d4c18e7 100644 >>>> --- a/BaseTools/Bin/nasm_ext_dep.yaml >>>> +++ b/BaseTools/Bin/nasm_ext_dep.yaml >>>> @@ -13,6 +13,6 @@ >>>> "type": "nuget", >>>> "name": "mu_nasm", >>>> "source": "https://api.nuget.org/v3/index.json", >>>> - "version": "2.14.02", >>>> + "version": "2.15.5", >>>> "flags": ["set_path", "host_specific"] >>>> } >>>> >>> >>> (1) I'm confused by the "patchlevel" number being "5" and not "05", in >>> the "2.15.5" version. Per >>> , my understanding has >>> been that the latest release is "2.15.05". >>> >>> (2) The minimum required version, according to >>> , is "2.15.01". In the >>> RHEL build environments that matter to me, I can satisfy a NASM >>> dependency up to 2.15.03, at this time, but not beyond. And this matters >>> because... >>> >> I understand CI environment tries to use the latest tool version for >> verification. >> >>> (3) ... arguably, the NASM requirement in >>> "BaseTools/Conf/tools_def.template" should be updated too, in the same >>> patch: >>> >>> # - NASM 2.10 or later for use with the GCC toolchain family >>> # - NASM 2.12.01 or later for use with all other toolchain families >>> >> This is edk2 build environment requirement. It will be updated when the >> source code change is added. >> >> Thanks >> Liming >>> Thanks >>> Laszlo >>> >>> >>> >>> >>> >> >> >> >> >