From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 647FB7803E5 for ; Fri, 17 Nov 2023 09:20:48 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=C2pCl3Y6bOJ64mJps0eFaSP+cspoGV7X7fmwtkETSos=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:Subject:To:References:From:Cc:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1700212847; v=1; b=pJOAM3IZFb66zbWXbp7CM06hRvoc74h6q8xjs9Gdubp0nemVRqw/pKu2oU1KNXpP4cujA5DF 9ylhXBA9RtfbU2q9klwrjaZR+fegZMfgVe8okGPjQXDVXco9SJIZsRj0R9pfGu63IGNb6RGK6RZ BjArIHMEpr0PKjhtlA22UiAk= X-Received: by 127.0.0.2 with SMTP id YmWGYY7687511xNVdK8V7sUi; Fri, 17 Nov 2023 01:20:47 -0800 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web11.8290.1700212846379629397 for ; Fri, 17 Nov 2023 01:20:46 -0800 X-Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-190-DhhuWp0hOvGGKD_xhc-LFw-1; Fri, 17 Nov 2023 04:20:41 -0500 X-MC-Unique: DhhuWp0hOvGGKD_xhc-LFw-1 X-Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 54CD4811E82; Fri, 17 Nov 2023 09:20:41 +0000 (UTC) X-Received: from [10.39.193.21] (unknown [10.39.193.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 0777E2026D4C; Fri, 17 Nov 2023 09:20:39 +0000 (UTC) Message-ID: Date: Fri, 17 Nov 2023 10:20:38 +0100 MIME-Version: 1.0 Subject: Re: [edk2-devel] [PATCH] DynamicTablesPkg: Fix ETE _UID Creation To: devel@edk2.groups.io, ashishsingha@nvidia.com, quic_llindhol@quicinc.com, ardb+tianocore@kernel.org, sami.mujawar@arm.com, jbrasen@nvidia.com References: <0dfe6159ce24094f914dbe340a5656b95895b808.1700018266.git.ashishsingha@nvidia.com> From: "Laszlo Ersek" Cc: Michael Kinney , "Liming Gao (Byosoft address)" In-Reply-To: <0dfe6159ce24094f914dbe340a5656b95895b808.1700018266.git.ashishsingha@nvidia.com> X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.4 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,lersek@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: FbE7FZ8pK6hLLruX8SeKN0Vbx7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=pJOAM3IZ; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On 11/15/23 04:19, Ashish Singhal via groups.io wrote: > Just like CPU _UID, ETE UID also needs to be unique so > use AcpiProcessorUid instead of CpuName >=20 > Signed-off-by: Ashish Singhal > --- > .../Arm/AcpiSsdtCpuTopologyLibArm/SsdtCpuTopologyGenerator.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) Is this a fixup for the recent feature [PATCH v3 00/11] Update MADT for ACPI 6.5, and add TRBE & ETE support https://edk2.groups.io/g/devel/message/108996 ? If so, then I *think* this qualifies to be merged during the hard feature freeze (+Liming +Mike), but: - I think we should have a "Fixes:" tag in the commit message (for pointing out the commit that should have contained the code being added/updated now) - I think we should have a BZ too (also linked into the commit message). Laszlo >=20 > diff --git a/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtCpuTopologyLibArm/= SsdtCpuTopologyGenerator.c b/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtCpuT= opologyLibArm/SsdtCpuTopologyGenerator.c > index 8228c7845a..724f33c660 100644 > --- a/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtCpuTopologyLibArm/SsdtCpu= TopologyGenerator.c > +++ b/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtCpuTopologyLibArm/SsdtCpu= TopologyGenerator.c > @@ -359,6 +359,7 @@ CreateAmlCpcNode ( > =20 > @param [in] Generator The SSDT Cpu Topology generator. > @param [in] ParentNode Parent node to attach the Cpu node to. > + @param [in] GicCInfo CM_ARM_GICC_INFO object used to create the n= ode. > @param [in] CpuName Value used to generate the node name. > @param [out] EtNodePtr If not NULL, return the created Cpu node. > =20 > @@ -372,6 +373,7 @@ EFIAPI > CreateAmlEtd ( > IN ACPI_CPU_TOPOLOGY_GENERATOR *Generator, > IN AML_NODE_HANDLE ParentNode, > + IN CM_ARM_GICC_INFO *GicCInfo, > IN UINT32 CpuName, > OUT AML_OBJECT_NODE_HANDLE *EtNodePtr OPTIONAL > ) > @@ -397,7 +399,7 @@ CreateAmlEtd ( > =20 > Status =3D AmlCodeGenNameInteger ( > "_UID", > - CpuName, > + GicCInfo->AcpiProcessorUid, > EtNode, > NULL > ); > @@ -474,6 +476,7 @@ CreateAmlEtNode ( > Status =3D CreateAmlEtd ( > Generator, > Node, > + GicCInfo, > CpuName, > NULL > ); -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#111346): https://edk2.groups.io/g/devel/message/111346 Mute This Topic: https://groups.io/mt/102598848/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/19134562= 12/xyzzy [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-