From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.groups.io with SMTP id smtpd.web09.16.1615575075047193808 for ; Fri, 12 Mar 2021 10:51:15 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=D743ko1Q; spf=pass (domain: redhat.com, ip: 216.205.24.124, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1615575074; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=a07vXp6cCmuMuwkV76EfeIkuDcNJiH8lw7UFaCY28qs=; b=D743ko1QosEcT4rlIhWmU43A4ZR9kh74X/cgSC9pG/dAaAw4lK7PBRlK3SBs//XYXaXSUU HsXKT1Vi3HV+cDweLlF+L+wvdHz3OBviXADoEaIx8ULLJESkYZtQt4nUQxRcVdMvEWsz3o iRpc9sbQsO3is+tnO3Kr9Pnr6EXe4AU= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-173-26M_uoSsNBGADNuP2JmOtQ-1; Fri, 12 Mar 2021 13:51:12 -0500 X-MC-Unique: 26M_uoSsNBGADNuP2JmOtQ-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 20C5D8015BD; Fri, 12 Mar 2021 18:51:11 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-112-80.ams2.redhat.com [10.36.112.80]) by smtp.corp.redhat.com (Postfix) with ESMTP id 249215D9CC; Fri, 12 Mar 2021 18:51:09 +0000 (UTC) Subject: Re: [edk2-discuss] Google Summer of Code Interested Student To: "Desimone, Nathaniel L" , "cadenkline9@gmail.com" Cc: "discuss@edk2.groups.io" , "devel@edk2.groups.io" References: <848a0cdb-accf-5b7c-df59-65a806ea14a7@redhat.com> From: "Laszlo Ersek" Message-ID: Date: Fri, 12 Mar 2021 19:51:09 +0100 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=lersek@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 03/12/21 06:45, Desimone, Nathaniel L wrote: > Now, here is the second bug. That BIOS setup menu page that OVMF has > for configuring the serial port has a field for setting the terminal > type. But, changing the value in that field doesn't actually change > the configuration data that is sent to the terminal driver. So the > terminal driver always ends up using PC_ANSI mode even if the user > changes that setting. This isn’t a bug in the terminal driver really, > it’s a bug in OVMF's setup menu implementation. But it does create > the appearance of a problem in the terminal driver and should be > fixed as part of this GSoC project. This should be fixed in both he > OVMF implementation and the MinPlatform implementation. It's a shortcoming of OVMF's PlatformBootManagerLib. A solution would be nice where, if a (non-volatile) terminal type setting existed, that would take effect, but if no such setting existed, then we'd still automatically add the serial port(s) -- with some default terminal type -- to the console I/O variables. ArmVirtQemu's PlatformBootManagerLib works somewhat differently (see the build-time feature test macro TTY_TERMINAL). I'm not up-to-date on whether that PlatformBootManagerLib instance handles the Setup TUI-based terminal type setting correctly. As far as I can remember, the terminal type has always been hard-coded in OVMF like this -- I believe it's not a regression (old or recent). I guess I haven't seen a good PlatformBootManagerLib example on this topic. Thanks Laszlo