Re: [edk2-devel] libspdm Breaking Builds

["Michael Kubacki" <mikuback@linux.microsoft.com>]

Since we already reached agreement in libspdm to move its cmocka 
submodule to the gitlab mirror in 
https://github.com/DMTF/libspdm/issues/2707 and that was merged in 
https://github.com/tianocore/edk2/pull/5697.

I'd like to suggest we go with option 2 as well. This is impacting our 
ability to use the DeviceSecurity modules. We've currently disabled 
those modules entirely in our local copy of SecurityPkg and disabled the 
libspdm submodule until a more stable solution is in place.

Here's a PR for option 2.

https://github.com/tianocore/edk2/pull/5697

Thanks,
Michael

On 5/29/2024 3:40 PM, Kinney, Michael D wrote:
> Hi Pete,
> 
> I just tested this config command and it works when cryptomilk is down.
> 
>      git config --global url."https://github.com/tianocore/edk2-cmocka.git".insteadOf "https://git.cryptomilk.org/projects/cmocka.git"
> 
> I updated edk2-cmocka mirror last week.
> 
> I tested this with
> 
>      git clone https://github.com/tianocore/edk2 --recursive
> 
> Best regards,
> 
> Mike
> 
>> -----Original Message-----
>> From: Kinney, Michael D <michael.d.kinney@intel.com>
>> Sent: Wednesday, May 29, 2024 11:33 AM
>> To: Pete Batard <pete@akeo.ie>; devel@edk2.groups.io; Yao, Jiewen
>> <jiewen.yao@intel.com>; mikuback@linux.microsoft.com
>> Cc: Kinney, Michael D <michael.d.kinney@intel.com>
>> Subject: RE: [edk2-devel] libspdm Breaking Builds
>>
>> Hi Pete,
>>
>> There is another option for developers and CI agents.
>>
>> Git supports a URL insteadof option to redirect git requests.
>>
>>      https://git-scm.com/docs/git-config#Documentation/git-config.txt-
>> urlltbasegtinsteadOf
>>
>> We can use this to redirect a request from cryptomilk cmocka to the
>> TianoCore mirror of cryptomilk cmocka.
>>
>> For developers, this can be a global config setting so it works
>> for all edk2 trees on their system.
>>
>> For a CI agent, this could be ab early step in all CI jobs to perform
>> a git config action.  Perhaps a feature Stuart could adopt to support
>> URL redirects.
>>
>> Mike
>>
>>
>>> -----Original Message-----
>>> From: Pete Batard <pete@akeo.ie>
>>> Sent: Wednesday, May 29, 2024 11:18 AM
>>> To: devel@edk2.groups.io; Yao, Jiewen <jiewen.yao@intel.com>; Kinney,
>> Michael
>>> D <michael.d.kinney@intel.com>; mikuback@linux.microsoft.com
>>> Subject: Re: [edk2-devel] libspdm Breaking Builds
>>>
>>> Hello all,
>>>
>>> On 2024.05.24 03:13, Yao, Jiewen via groups.io wrote:
>>>> Please let us know if the preference for libspdm submodule. (Below
>> options)
>>>> 1) Keep current libspdm official 3.3.0 release, and update to next
>> release
>>> at the beginning of July.
>>>> 2) Update libspdm immediately with the new cmocka submodule, which is NOT
>>> an official release.
>>>
>>> Considering that I (and I expect anybody who tries to use EDK2 as a
>>> submodule in their UEFI build projects with GitHub Actions), I have to
>>> vote for option 2.
>>>
>>> An example of the current issue can be shown on a project that simply
>>> attempts to build the UEFI Shell from the latest stable EDK2 release,
>>> using EDK2 as a submodule, can be shown at
>>> https://github.com/pbatard/UEFI-
>> Shell/actions/runs/9290685065/job/25567879807
>>> or
>>> https://github.com/pbatard/UEFI-
>> Shell/actions/runs/9290988138/job/25568511355
>>> and as you can see, it makes building the project completely impossible
>>> unless you ditch using EDK2 as a submodule (which isn't a viable option
>>> IMO, because a build toolchain that cannot be used as a git submodule is
>>> a very limiting toolchain).
>>>
>>> For information, there's only so much fine grained tuning GitHub Actions
>>> offers on submodules, and no matter how you try to play with the fetch
>>> depth, the fact that one of the libspdm sub-dependency has essentially
>>> become M.I.A. is something that should be addressed as a matter of urgency.
>>>
>>> So I hope that a commit that updates libspdm to the new cmocka submodule
>>> can find its way into EDK2 fairly soon, as it is currently halting a
>>> projects that aims at producing trusted UEFI Shell releases.
>>>
>>> Regards,
>>>
>>> /Pete


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#119364): https://edk2.groups.io/g/devel/message/119364
Mute This Topic: https://groups.io/mt/106250971/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-