public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Michael Kubacki" <mikuback@linux.microsoft.com>
To: "Kinney, Michael D" <michael.d.kinney@intel.com>,
	Pete Batard <pete@akeo.ie>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>,
	"Yao, Jiewen" <jiewen.yao@intel.com>
Subject: Re: [edk2-devel] libspdm Breaking Builds
Date: Wed, 29 May 2024 15:57:26 -0400	[thread overview]
Message-ID: <b8955f68-b262-4447-83f9-fbd5c0e7f4b5@linux.microsoft.com> (raw)
In-Reply-To: <CO1PR11MB49298CED99DBE9E01637113FD2F22@CO1PR11MB4929.namprd11.prod.outlook.com>

Since we already reached agreement in libspdm to move its cmocka 
submodule to the gitlab mirror in 
https://github.com/DMTF/libspdm/issues/2707 and that was merged in 
https://github.com/tianocore/edk2/pull/5697.

I'd like to suggest we go with option 2 as well. This is impacting our 
ability to use the DeviceSecurity modules. We've currently disabled 
those modules entirely in our local copy of SecurityPkg and disabled the 
libspdm submodule until a more stable solution is in place.

Here's a PR for option 2.

https://github.com/tianocore/edk2/pull/5697

Thanks,
Michael

On 5/29/2024 3:40 PM, Kinney, Michael D wrote:
> Hi Pete,
> 
> I just tested this config command and it works when cryptomilk is down.
> 
>      git config --global url."https://github.com/tianocore/edk2-cmocka.git".insteadOf "https://git.cryptomilk.org/projects/cmocka.git"
> 
> I updated edk2-cmocka mirror last week.
> 
> I tested this with
> 
>      git clone https://github.com/tianocore/edk2 --recursive
> 
> Best regards,
> 
> Mike
> 
>> -----Original Message-----
>> From: Kinney, Michael D <michael.d.kinney@intel.com>
>> Sent: Wednesday, May 29, 2024 11:33 AM
>> To: Pete Batard <pete@akeo.ie>; devel@edk2.groups.io; Yao, Jiewen
>> <jiewen.yao@intel.com>; mikuback@linux.microsoft.com
>> Cc: Kinney, Michael D <michael.d.kinney@intel.com>
>> Subject: RE: [edk2-devel] libspdm Breaking Builds
>>
>> Hi Pete,
>>
>> There is another option for developers and CI agents.
>>
>> Git supports a URL insteadof option to redirect git requests.
>>
>>      https://git-scm.com/docs/git-config#Documentation/git-config.txt-
>> urlltbasegtinsteadOf
>>
>> We can use this to redirect a request from cryptomilk cmocka to the
>> TianoCore mirror of cryptomilk cmocka.
>>
>> For developers, this can be a global config setting so it works
>> for all edk2 trees on their system.
>>
>> For a CI agent, this could be ab early step in all CI jobs to perform
>> a git config action.  Perhaps a feature Stuart could adopt to support
>> URL redirects.
>>
>> Mike
>>
>>
>>> -----Original Message-----
>>> From: Pete Batard <pete@akeo.ie>
>>> Sent: Wednesday, May 29, 2024 11:18 AM
>>> To: devel@edk2.groups.io; Yao, Jiewen <jiewen.yao@intel.com>; Kinney,
>> Michael
>>> D <michael.d.kinney@intel.com>; mikuback@linux.microsoft.com
>>> Subject: Re: [edk2-devel] libspdm Breaking Builds
>>>
>>> Hello all,
>>>
>>> On 2024.05.24 03:13, Yao, Jiewen via groups.io wrote:
>>>> Please let us know if the preference for libspdm submodule. (Below
>> options)
>>>> 1) Keep current libspdm official 3.3.0 release, and update to next
>> release
>>> at the beginning of July.
>>>> 2) Update libspdm immediately with the new cmocka submodule, which is NOT
>>> an official release.
>>>
>>> Considering that I (and I expect anybody who tries to use EDK2 as a
>>> submodule in their UEFI build projects with GitHub Actions), I have to
>>> vote for option 2.
>>>
>>> An example of the current issue can be shown on a project that simply
>>> attempts to build the UEFI Shell from the latest stable EDK2 release,
>>> using EDK2 as a submodule, can be shown at
>>> https://github.com/pbatard/UEFI-
>> Shell/actions/runs/9290685065/job/25567879807
>>> or
>>> https://github.com/pbatard/UEFI-
>> Shell/actions/runs/9290988138/job/25568511355
>>> and as you can see, it makes building the project completely impossible
>>> unless you ditch using EDK2 as a submodule (which isn't a viable option
>>> IMO, because a build toolchain that cannot be used as a git submodule is
>>> a very limiting toolchain).
>>>
>>> For information, there's only so much fine grained tuning GitHub Actions
>>> offers on submodules, and no matter how you try to play with the fetch
>>> depth, the fact that one of the libspdm sub-dependency has essentially
>>> become M.I.A. is something that should be addressed as a matter of urgency.
>>>
>>> So I hope that a commit that updates libspdm to the new cmocka submodule
>>> can find its way into EDK2 fairly soon, as it is currently halting a
>>> projects that aims at producing trusted UEFI Shell releases.
>>>
>>> Regards,
>>>
>>> /Pete


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#119364): https://edk2.groups.io/g/devel/message/119364
Mute This Topic: https://groups.io/mt/106250971/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



  reply	other threads:[~2024-05-29 19:57 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-22 20:40 [edk2-devel] libspdm Breaking Builds Michael Kubacki
2024-05-22 21:57 ` Michael D Kinney
2024-05-22 22:16   ` Michael Kubacki
2024-05-22 22:24     ` Michael D Kinney
2024-05-23  1:04       ` Michael Kubacki
2024-05-23  1:51         ` Michael D Kinney
2024-05-23  2:16           ` Yao, Jiewen
     [not found]           ` <17D1FC93E885E03F.15878@groups.io>
2024-05-24  2:13             ` Yao, Jiewen
2024-05-29 18:17               ` Pete Batard via groups.io
2024-05-29 18:33                 ` Michael D Kinney
2024-05-29 19:40                   ` Michael D Kinney
2024-05-29 19:57                     ` Michael Kubacki [this message]
2024-05-30  0:31                       ` Yao, Jiewen
2024-05-29 22:00                     ` Pete Batard via groups.io
2024-05-30  0:32                       ` Michael D Kinney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b8955f68-b262-4447-83f9-fbd5c0e7f4b5@linux.microsoft.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox