From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) by mx.groups.io with SMTP id smtpd.web10.91752.1670023670990453555 for ; Fri, 02 Dec 2022 15:27:51 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="body hash did not verify" header.i=@quicinc.com header.s=qcppdkim1 header.b=Wl8zLGGv; spf=permerror, err=parse error for token &{10 18 %{ir}.%{v}.%{d}.spf.has.pphosted.com}: invalid domain name (domain: quicinc.com, ip: 205.220.168.131, mailfrom: quic_rcran@quicinc.com) Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 2B2LeCTD031251; Fri, 2 Dec 2022 23:27:39 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=qcppdkim1; bh=TeKxkf1MmCE9ZOMYFLwY2F2cqPZDBGa5wlJzEw8Bph8=; b=Wl8zLGGvcS2MWG3uXT+DcyV9i5bIqwDQgr/aVkFx5NV9Ruxz2N/iJTJSvr70enCtNBbz hxdvKH1EYEtEp/iTQOft3cXPoCkoD4lkc3iW5QpvZo5ICrbLlOt2QqU34Vy5m65/cVto 1i2t4qSpPr0v5FN7Z+qmvOwljKr9ySCBQNx4equJljEmkzI7UjxThM2h+pcmdXiglnL2 hPPRsnkPmtY3lot/mWmyZVyG25/hqjKMRAGpRbfFWRoxMZ5wOe6GHSgjZTFRL1MZBESA ETUkYAecjxq4Sn7fMuOnvm8k36a3nU9VPsZzHP6bbZZhMhbQWxOxrlNLm8UKlHsaUgW7 uw== Received: from nasanppmta02.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3m7gvxsrsg-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 02 Dec 2022 23:27:39 +0000 Received: from nasanex01b.na.qualcomm.com (corens_vlan604_snip.qualcomm.com [10.53.140.1]) by NASANPPMTA02.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 2B2NRcHj014394 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 2 Dec 2022 23:27:38 GMT Received: from [10.110.8.230] (10.80.80.8) by nasanex01b.na.qualcomm.com (10.46.141.250) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.36; Fri, 2 Dec 2022 15:27:38 -0800 Message-ID: Date: Fri, 2 Dec 2022 16:27:37 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: [edk2-devel] [PATCH 1/3] UsbNetworkPkg/UsbRndis: Add USB RNDIS devices support To: , CC: Andrew Fish , Leif Lindholm , Michael D Kinney , Michael Kubacki , Zhiguang Liu , Liming Gao , =?UTF-8?B?VG9ueUxvIFvnvoXph5Hmnb5d?= References: <20221003092643.4813-1-richardho@ami.com> From: "Rebecca Cran" In-Reply-To: <20221003092643.4813-1-richardho@ami.com> X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nasanex01b.na.qualcomm.com (10.46.141.250) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: oPsRH5IClvfYdvjuO0LqB2rKEyXnYRSf X-Proofpoint-ORIG-GUID: oPsRH5IClvfYdvjuO0LqB2rKEyXnYRSf X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.923,Hydra:6.0.545,FMLib:17.11.122.1 definitions=2022-12-02_12,2022-12-01_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 adultscore=0 clxscore=1015 priorityscore=1501 bulkscore=0 mlxlogscore=999 impostorscore=0 suspectscore=0 lowpriorityscore=0 mlxscore=0 phishscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2210170000 definitions=main-2212020189 X-MIME-Autoconverted: from 8bit to quoted-printable by mx0a-0031df01.pphosted.com id 2B2LeCTD031251 Content-Language: en-US Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: quoted-printable The SendRndisSetMsg function never appears to be called: never directly,=20 or as a callback. I noticed this because qemu's rndis receive function always fails=20 because the media status is 'uninitialized': it uses the RNDIS SET MSG=20 to change the status to initialized. --=20 Rebecca Cran On 10/3/22 03:26, RichardHo [=E4=BD=95=E6=98=8E=E5=BF=A0] via groups.io w= rote: > This driver provides UEFI driver for USB RNDIS device >=20 > Signed-off-by: Richard Ho > Cc: Andrew Fish > Cc: Leif Lindholm > Cc: Michael D Kinney > Cc: Michael Kubacki > Cc: Zhiguang Liu > Cc: Liming Gao > Reviewed-by: Tony Lo > --- > UsbNetworkPkg/Config/UsbNetworkPkg.inc.dsc | 9 + > .../Config/UsbNetworkPkgComponentsDxe.inc.dsc | 20 + > .../Config/UsbNetworkPkgComponentsDxe.inc.fdf | 20 + > .../Config/UsbNetworkPkgDefines.inc.dsc | 23 + > .../Protocol/EdkIIUsbEthernetProtocol.h | 874 +++++++++ > UsbNetworkPkg/NetworkCommon/ComponentName.c | 263 +++ > UsbNetworkPkg/NetworkCommon/DriverBinding.c | 581 ++++++ > UsbNetworkPkg/NetworkCommon/DriverBinding.h | 263 +++ > UsbNetworkPkg/NetworkCommon/NetworkCommon.inf | 44 + > UsbNetworkPkg/NetworkCommon/PxeFunction.c | 1734 ++++++++++++++++= + > UsbNetworkPkg/ReadMe.md | 65 + > UsbNetworkPkg/ReleaseNotes.md | 11 + > UsbNetworkPkg/UsbNetworkPkg.dec | 36 + > UsbNetworkPkg/UsbRndis/ComponentName.c | 172 ++ > UsbNetworkPkg/UsbRndis/UsbRndis.c | 845 ++++++++ > UsbNetworkPkg/UsbRndis/UsbRndis.h | 571 ++++++ > UsbNetworkPkg/UsbRndis/UsbRndis.inf | 42 + > UsbNetworkPkg/UsbRndis/UsbRndisFunction.c | 1591 +++++++++++++++ > 18 files changed, 7164 insertions(+) > create mode 100644 UsbNetworkPkg/Config/UsbNetworkPkg.inc.dsc > create mode 100644 UsbNetworkPkg/Config/UsbNetworkPkgComponentsDxe.in= c.dsc > create mode 100644 UsbNetworkPkg/Config/UsbNetworkPkgComponentsDxe.in= c.fdf > create mode 100644 UsbNetworkPkg/Config/UsbNetworkPkgDefines.inc.dsc > create mode 100644 UsbNetworkPkg/Include/Protocol/EdkIIUsbEthernetPro= tocol.h > create mode 100644 UsbNetworkPkg/NetworkCommon/ComponentName.c > create mode 100644 UsbNetworkPkg/NetworkCommon/DriverBinding.c > create mode 100644 UsbNetworkPkg/NetworkCommon/DriverBinding.h > create mode 100644 UsbNetworkPkg/NetworkCommon/NetworkCommon.inf > create mode 100644 UsbNetworkPkg/NetworkCommon/PxeFunction.c > create mode 100644 UsbNetworkPkg/ReadMe.md > create mode 100644 UsbNetworkPkg/ReleaseNotes.md > create mode 100644 UsbNetworkPkg/UsbNetworkPkg.dec > create mode 100644 UsbNetworkPkg/UsbRndis/ComponentName.c > create mode 100644 UsbNetworkPkg/UsbRndis/UsbRndis.c > create mode 100644 UsbNetworkPkg/UsbRndis/UsbRndis.h > create mode 100644 UsbNetworkPkg/UsbRndis/UsbRndis.inf > create mode 100644 UsbNetworkPkg/UsbRndis/UsbRndisFunction.c