From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id 7D120D80477 for ; Mon, 15 Jul 2024 03:25:02 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=q5UlOwfau6g4IopT1zHwEzFpW+JUnczyQkXdmek9NeE=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:User-Agent:Subject:To:Cc:References:From:In-Reply-To:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20240206; t=1721013902; v=1; b=LiVdQtG/1MgkzlDLj36hwkQP68eBmLlyaEi8Nktn28neS+SjXOHqHdI2lbXh+jwgP1eaxBZ7 9Z27TC+zWh78niKWBKHicmccG5qFrvnCOnJB0Ygq670gDpIt3oziZwHZymKv+6220SQ25LH6ah+ E0vWI3I2yk9DVah+7ZZHAJW3BwWtswFkyk5BtDpfBO49HatyUGEOvVsDll8etzum7B6flaFpeRs ucLuSfWD05liQqp+eRdI7bKiUa5sJOo0PoGQeOrajC7LB9TO5VuLHzOhjy+omDBVInd8jcSHL6D 6mssPEHfjlNyiQd0zLoN3qG+nNa1Fc2QoCUtHT8cSkOmg== X-Received: by 127.0.0.2 with SMTP id 69ZfYY7687511x5zypAUn3d7; Sun, 14 Jul 2024 20:25:00 -0700 X-Received: from DM1PR04CU001.outbound.protection.outlook.com (DM1PR04CU001.outbound.protection.outlook.com [52.101.61.128]) by mx.groups.io with SMTP id smtpd.web11.29976.1721013900050078899 for ; Sun, 14 Jul 2024 20:25:00 -0700 X-Received: from PH0PR01MB7287.prod.exchangelabs.com (2603:10b6:510:10a::21) by MN0PR01MB7804.prod.exchangelabs.com (2603:10b6:208:37f::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7762.28; Mon, 15 Jul 2024 03:24:57 +0000 X-Received: from PH0PR01MB7287.prod.exchangelabs.com ([fe80::fc79:e629:93aa:8b8f]) by PH0PR01MB7287.prod.exchangelabs.com ([fe80::fc79:e629:93aa:8b8f%3]) with mapi id 15.20.7762.027; Mon, 15 Jul 2024 03:24:57 +0000 Message-ID: Date: Mon, 15 Jul 2024 10:24:52 +0700 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] [PATCH edk2-platforms 2/2] SbsaQemu: set CPU model in SMBIOS To: devel@edk2.groups.io, ardb@kernel.org, Marcin Juszkiewicz Cc: Leif Lindholm , Ard Biesheuvel , Sami Mujawar References: <20240712092356.517074-1-marcin.juszkiewicz@linaro.org> <20240712092356.517074-3-marcin.juszkiewicz@linaro.org> From: "Nhi Pham via groups.io" In-Reply-To: X-ClientProxiedBy: SG3P274CA0005.SGPP274.PROD.OUTLOOK.COM (2603:1096:4:be::17) To PH0PR01MB7287.prod.exchangelabs.com (2603:10b6:510:10a::21) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH0PR01MB7287:EE_|MN0PR01MB7804:EE_ X-MS-Office365-Filtering-Correlation-Id: 2949468a-203c-424d-09d2-08dca47db3c9 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Message-Info: =?utf-8?B?T3RZZ1dlcVozRS95bG55VWlNU1lvY3BmdkgzUWJDRUNuL0h3aHlzbmlyOVZ0?= =?utf-8?B?UUdna0c0eHpaOVV4dFJ3eHVQSFpydjZhZTdPa1RrdmFwVCtrMnZGdmtHZzB4?= =?utf-8?B?c3hTTCtmbnRmV09yMzNrSS9OcWJsaUZzVFRGbWhsb3kvZzMwSWg5eHg3YVgr?= =?utf-8?B?dmZSMTFYWEQxOG4yUTNIQkZZSTJXU00wUk9yaE91YisxZU5aeG9iaCtOYWxK?= =?utf-8?B?aHkrSERic3J6WUw3QjlEVjBvWEFmcTFJeXN5N3l5VVJSRUZmQU5HdHNYdStV?= =?utf-8?B?RnRUYjh5T1J6ZHJSS2cxSlJuMDd6RlRtTlNQS3BXUkgxWU9XNlpQS2RCdjhW?= =?utf-8?B?VDJleDJEN08yM1FDSndRTnB2ZzV0cU92N2lMNWRYelJRTmNIR3JteEY1WkZF?= =?utf-8?B?b1BBUVNCMC9oZ3lLV3J5aWQ2VHpHZjFPUWpHQndBSnYvTjdDbXN2Tm50RCsy?= =?utf-8?B?d2JUS05TUVo2bHNFUklUTnVFOU9hc3dLYXRZZG1kdU1zdzZDcGlLMVdwUC9v?= =?utf-8?B?VnJTZGdyVDlSK0JPejZ2ZFFYL3NPV3VpQjhYUC9hZVZrdXdaWVRBRGlOU25R?= =?utf-8?B?TXJsUXppKzNKUTlzcnF5M1lBL291aE52UTJnT0NrUzBVaFhIbHpFV3BNUmxu?= =?utf-8?B?bTE1dkNIR1hZQXlqY0pwdzhZNnFPY212Lys2MGpvSXRDOXJwVGdIN1Z2eGJK?= =?utf-8?B?TTh5WXpYZnRMWi9SSWpPbHZ1Y3ZNMUlJbldjYWMvZWM4NjBTVGprT3EyMHJZ?= =?utf-8?B?eHlPN3JaZ3o5MmJyaVJhTWFZSkgrWjZYWWZSK0pkQ2Q5MC9PTWJWdEVEQ2Jx?= =?utf-8?B?am5kcURiUXNuV0NkUzdzb3Q1bmZyRzFMVm5wTUNUZldwUWtOK1V6SlYvUjM5?= =?utf-8?B?T3lzZ0pLQmdoMkVLSFVjOUJNdjc4TTJRdXkvWVN2UW5EYTRZTEptc2EybC9l?= =?utf-8?B?V1pPMVlqNHZXbU45c2owZmt2OTFpUjg0T3lXWWVIVjQybU55Tnd6MCtiVEpn?= =?utf-8?B?ZVBOdE1yQndlMVZFd3B0TU1jNjVpUDdqL2tZUmd3UnBwaEQrYTJFMm5DVnFF?= =?utf-8?B?Q2dQajEyc1NIendBMWxDcjRNY2N6WVJqNS8wQ2VuRTdhckFWeXNuZkdET1Q5?= =?utf-8?B?ei94QjFHNmY4U0ZEdnFSa1FmVkEzOGxrM0w1cFF0b0ZoT002UkNjSmdrQWI3?= =?utf-8?B?c2hNclFQOFQrcnRJR1hWaXZSTTYzNVZRWVNWNlcyRkdOcGIxS3Uwb3JQQ2kv?= =?utf-8?B?b2x0YUlMRU9OMEo5L09od296RW1oOWV1Z0pKK0JGbm1jbGtyeGVNbmV3dUdK?= =?utf-8?B?YUdFdDJoeTUrNzFxQ2VMQ3ozbDNWNWJXcjJiVTdRWThGVXlpcG1naDlIMk5L?= =?utf-8?B?QnhNL1M3MTAxeVNZNERldXpjY3UvYUwwYTJkbkFkWkdReG9MenNEcVRMWHJX?= =?utf-8?B?eU0rL0JLZ0RmVXk2dHJCU3lFM0JMTlo5b2lMZG54SDVEekd5L2J1cDk0Q1p3?= =?utf-8?B?b2srRVZYYmV5QlMvVm81QlNxMS9kNDdQNFpoVkF4U3Zoc1BXbFN0dWpIMXh5?= =?utf-8?B?Y1Y5SFNsN2Yyc3lJTk5EVkpzclIyOTRIU0UxQitCVGxhd0JiaVZyYmhtOGk1?= =?utf-8?B?QmxnNjc1c1hiSGVZOGwrRlhiK21od3Z2U3BqdVhNZjBVZndsUVptbm55U29l?= =?utf-8?B?R2RFdHJGOVV5QkV5ZU5EdCszcWgzV2V3U28ycG5EMm1RY3hnZnRUa093bW41?= =?utf-8?B?YU1TdHNJbVF3OUIwRXA2ODAwN3FtbVk5VGF4M2pxcXpibU5yV0NYQWx2V2hJ?= =?utf-8?B?REJwQjcvSkl3cnZteGFBdz09?= X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WGhTdllYdUdCUzRQS2VPS2tTUllkWE9yREdwTmNYS3Q2dzhtOXA3VHRhZnBO?= =?utf-8?B?OVFsalV1SjlEcTJCSjlNYzJRY2hzRVBLK2hXcnNsNEMwNkJ6VU1FSHArellz?= =?utf-8?B?OHNWbkx0Zmd5aXNTZnVLWW1OZk5uaTdEdFRqNWxQZlNPMXBHMkpaaHhZbFJ1?= =?utf-8?B?YXg4VGVacjFSVDZPK2tJcXdEQmZaWXA1TjlXQy9JanUreHZFYVNHeVRKVXMw?= =?utf-8?B?MEp5Sm11TWVxeENQWjVvVU9HeDlxYzVEaFRGYWZYRjNBTnpiaTlDTWxsWUFn?= =?utf-8?B?d3RXNUpncm1OUm52UVpZOURwSmgvdUY0MkJZbkVhbC9jRFBpeS83eENmdk1j?= =?utf-8?B?S1diZFhNT21MREp3VG5xSktoQkdDejRwaEVGbG0xV2tHZ01hY1BUWXBpYjNK?= =?utf-8?B?Tyt3NWhIaUorT1FVOFc1cVhUUlBoelhrSTEwQUJ1T2pxM2RBeWduRGQweWN4?= =?utf-8?B?SXJzY3JUYU9wOGt5QXluSFpnS0tqWllTZVBZNndialZtajNDNVZJUFVIaVBX?= =?utf-8?B?ZzZ6TXRFWkR0ZEJMTS96dW1hcEhwQmVJZkI2dG5mYll1ZGJUTEJvOGdPN0J5?= =?utf-8?B?Y3h0b2Uxb2xtU1NIWDFTOStlYlJabnJVeHdvUDdwQ0NaTkh6aDlkU05CRTNX?= =?utf-8?B?WUtlRzhVNEgrZGlSeHIrUUdSek1TV25zVk9kZk81UFVOSE4vS3p6RGN5ek9W?= =?utf-8?B?T0JBdVpuUlFWUFh2YWNwNWpHQWVVeE45V21rbUZYNTBCYkFpVGdNNTZCbDNs?= =?utf-8?B?OTkzRVVldEEwR2ZTNlFqUll4d3R3M09OMjVxT0FibDc5Z0NKS2MrQTk1MS9W?= =?utf-8?B?a0N4ZnhVb3ZIRk16ZDVFb0xnTm8wWmFpU2YxRmRLZ1pNSGdLbHhVWUdabkQw?= =?utf-8?B?Qk9VbnNuNGo2TTFud0ZNc1piK20zMXN6WXA1K1lwbHVXdWljZE5id1owN3F6?= =?utf-8?B?Tk1MdzQxU1hZUkd5amVuZ0NuR1h3N3N3aXNzYk05bzYvdURUTno2QzlRb2N0?= =?utf-8?B?SzBwaU5qd2kxYUpCbnkyOVVhMmNsYTc4dHk3Ykgya1ZYYVlFK0l3anFId09T?= =?utf-8?B?M3NXRW9zWmhqVUVQb25iaUZTVk9WQ1NiUXVzUG45YUlWVUY5WXY0UkJCVmhV?= =?utf-8?B?a0xzaHVJcXhUMWFnSGJ3S0xSVG13aDNJait0MzFTRkY3cTdWWEc5c0xWdGZJ?= =?utf-8?B?cVRLbC8rbkF1dnd4bmFUTmdNQ3piK0lNQlFxKzhSREcxWFFPNFhSVW15SHNi?= =?utf-8?B?clhwSnkyZ3I2dHc2S0pVVTFUNFFhbkduTmNEUWlseHlGcUdheVdVaXVWVGFS?= =?utf-8?B?bHhkdDZQV21oa0xvVmZWV1Q1bE1mTlloSTRVcnBkT0Z0bkdMQVY2cXBEeWdm?= =?utf-8?B?dG5OQVRLcmptUE9tUG9hOFpsbWdTdzdHWEkzbW5KaXNuelA0dFRYZDVkSFJV?= =?utf-8?B?cWtLK1RUclZGeTBpcjJubC8zc3ZacWF2a1hBVmlPT0JRWWd0cW5CcnNpV0RZ?= =?utf-8?B?Wjh4aE5FcEVuSFc5M3BEb25UZHdUVUpYenVHVzNwbFROZUY4cXQycTdFczN2?= =?utf-8?B?ZFlyNGdrTXQ2MnB1RC93T0FHVjh2aEdVU1hPUEN4eGYyQnQ3WUNDOXJTTGpi?= =?utf-8?B?QUQyUUtLUlZtcHVHcjlEYjZGSG5JS01OUGpyMEZWYjQxeVpabmx1a2NvTUEw?= =?utf-8?B?WjA1VGdYM0QrNkJmL2E3UUR2T3hyeFYwcEVhNjBsbytlakMrTjBUZXJuVGVi?= =?utf-8?B?M2ZLSkpTR042d0NBZFBnTVYzekprVTRPY2dzT2lIWGNWN1REckFtZThKY2xv?= =?utf-8?B?SDY2eTRPT04yaDBtSSt3THRHMlVOeTJBazVuZy82YStMcUpCSzBXamNNUVlH?= =?utf-8?B?ZmFCR0hRTXNRNDZwandZWDhkVVpLdUsvVFBSRGFoVVdKemdqOUNleEkwS2k2?= =?utf-8?B?RHhHNjZxcE9BR1R0dlN2eEZyeTZxaU5ZbU4xeGFsanVEd2dWRG1waHNrb0tL?= =?utf-8?B?QU1RakZzU1g3ZDg4YnNkcDF0T3crN21TTFRFVTM2RnQ2MWlLZ2FKOHE4d0ND?= =?utf-8?B?cU5kNDJaZm15dmlVTWwxWE1mL3gvNmwyaGdJcmRycGRjdGxjdTBYeTRTUHVk?= =?utf-8?B?VVJaSHNjTEthbXprdWkwc0svL2toUVJCMmdiemFaRU5MOXBjZDRJVEgrZlh3?= =?utf-8?B?ZGc9PQ==?= X-OriginatorOrg: os.amperecomputing.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2949468a-203c-424d-09d2-08dca47db3c9 X-MS-Exchange-CrossTenant-AuthSource: PH0PR01MB7287.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Jul 2024 03:24:57.6551 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: dQEv8zZ6rFSem1Hmm3bAiFnkjwucecvatXj3StbEC5IgvQ8ONLDDXYMV68atIEHb8MSAcEeW3xGHcur79eJy9STGgyAYBlB9W9bhB9PzMHE= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR01MB7804 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Sun, 14 Jul 2024 20:25:00 -0700 Resent-From: nhi@os.amperecomputing.com Reply-To: devel@edk2.groups.io,nhi@os.amperecomputing.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: hyIpFpVDSSySxaO728MKCvr8x7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b="LiVdQtG/"; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=pass (policy=none) header.from=groups.io On 7/12/2024 5:01 PM, Ard Biesheuvel via groups.io wrote: > On Fri, 12 Jul 2024 at 11:24, Marcin Juszkiewicz > wrote: >> >> SbsaQemu platform have several cpu models available. Since start it >> reported "arm-virt" one in SMBIOS instead of real one. >> >> This change replaces it with the real cpu model like Cortex-A57, >> Neoverse-N2 etc. >> >> Requires change in EDK2 to make PcdProcessorVersion dynamic. >> >> Signed-off-by: Marcin Juszkiewicz >=20 > I am going to make the same remark as I did before in a different > context: how is it guaranteed that the code that sets the PCD executes > before the code that consumes it? We could implement the setting in a 'PlatformInitDxe', which will be=20 added to the 'APPRIORI DXE' list to ensure it is scheduled to run in the=20 early DXE phase. This approach will help initialize the neccessary=20 compoenents early in the DXE phase, providing a stable foundation for=20 subsequent operations. >=20 > Making PCDs dynamic is usually not the solution here, unless they are > set in the PEI phase and consumed in the DXE phase or after. >=20 > The EFI SMBIOS protocol has an 'update string' method that you can > call from a platform driver. That might be a better fit here, and the > PCD can remain fixed, and carry a fallback default value. >=20 In fact that the 'update string' method could eat up the boot time.=20 Hence, the SMBIOS string patching is not prefered. Regards, Nhi -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#119931): https://edk2.groups.io/g/devel/message/119931 Mute This Topic: https://groups.io/mt/107179083/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-