From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.31; helo=mga06.intel.com; envelope-from=ruiyu.ni@intel.com; receiver=edk2-devel@lists.01.org Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 82B4221160A2E for ; Sun, 7 Oct 2018 23:44:06 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 07 Oct 2018 23:44:05 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,355,1534834800"; d="scan'208";a="79578867" Received: from ray-dev.ccr.corp.intel.com (HELO [10.239.9.11]) ([10.239.9.11]) by orsmga008.jf.intel.com with ESMTP; 07 Oct 2018 23:44:04 -0700 To: Dandan Bi , edk2-devel@lists.01.org Cc: Michael D Kinney , Liming Gao References: <20181008033158.10652-1-dandan.bi@intel.com> <20181008033158.10652-2-dandan.bi@intel.com> From: "Ni, Ruiyu" Message-ID: Date: Mon, 8 Oct 2018 14:45:12 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20181008033158.10652-2-dandan.bi@intel.com> Subject: Re: [patch 2/5] MdePkg: Correct the string order of ACPI Expanded Device Path X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 08 Oct 2018 06:44:06 -0000 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit On 10/8/2018 11:31 AM, Dandan Bi wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1227 > > According to UEFI Spec, ACPI Expanded Device Path can be display > AcpiEx(HID|HIDSTR,(CID|CIDSTR,UID|UIDSTR)), but current code display > UID|UIDSTR before CID|CIDSTR. > This patch is to fix this issue. > > Cc: Ruiyu Ni > Cc: Michael D Kinney > Cc: Liming Gao > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Dandan Bi > --- > MdePkg/Library/UefiDevicePathLib/DevicePathToText.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/MdePkg/Library/UefiDevicePathLib/DevicePathToText.c b/MdePkg/Library/UefiDevicePathLib/DevicePathToText.c > index 85f5e97131..1c08a3ec2f 100644 > --- a/MdePkg/Library/UefiDevicePathLib/DevicePathToText.c > +++ b/MdePkg/Library/UefiDevicePathLib/DevicePathToText.c > @@ -475,20 +475,20 @@ DevPathToTextAcpiEx ( > UefiDevicePathLibCatPrint (Str, L"AcpiEx(%a,", HIDStr); > } else { > UefiDevicePathLibCatPrint (Str, L"AcpiEx(%s,", HIDText); > } > > - if (AcpiEx->UID == 0) { > - UefiDevicePathLibCatPrint (Str, L"%a,", UIDStr); > + if (AcpiEx->CID == 0) { > + UefiDevicePathLibCatPrint (Str, L"%a,", CIDStr); > } else { > - UefiDevicePathLibCatPrint (Str, L"0x%x,", AcpiEx->UID); > + UefiDevicePathLibCatPrint (Str, L"%s,", CIDText); > } > > - if (AcpiEx->CID == 0) { > - UefiDevicePathLibCatPrint (Str, L"%a)", CIDStr); > + if (AcpiEx->UID == 0) { > + UefiDevicePathLibCatPrint (Str, L"%a)", UIDStr); > } else { > - UefiDevicePathLibCatPrint (Str, L"%s)", CIDText); > + UefiDevicePathLibCatPrint (Str, L"0x%x)", AcpiEx->UID); > } > } else { > UefiDevicePathLibCatPrint ( > Str, > L"AcpiEx(%s,%s,0x%x,%a,%a,%a)", > Reviewed-by: Ruiyu Ni -- Thanks, Ray