Re: [edk2-devel] AArch64 with HeapGuard: page allocations wrongly aligned

["Oliver Smith-Denny" <osde@linux.microsoft.com>]

On 1/18/2024 7:27 AM, Rebecca Cran via groups.io wrote:
> I've been debugging an assert failure when using HeapGuard on AArch64. A 
> call to FreePages in SmbiosDxe is failing because the memory is aligned 
> to 0x1000 instead of 0x10000 as defined by 
> RUNTIME_PAGE_ALLOCATION_GRANULARITY.
> 
> I'm enabling HeapGuard by setting the PCDs to the following values:
> 
> gEfiMdeModulePkgTokenSpaceGuid.PcdHeapGuardPropertyMask|0x0F
> gEfiMdeModulePkgTokenSpaceGuid.PcdHeapGuardPageType|0xC00000000000FFFF
> gEfiMdeModulePkgTokenSpaceGuid.PcdHeapGuardPoolType|0xC00000000000FFFF
> 

Hi Rebecca,

Are you including this commit: 
https://github.com/tianocore/edk2/commit/00b51e0d78a547dd78119ec44fcc74a01b6f79c8?

Can you share some more details on where this is failing? I.e. what
assert is getting tripped? Presumably without HeapGuard enabled, you
aren't seeing the failure?

Are you hitting this case:
https://github.com/tianocore/edk2/blob/59f024c76ee57c2bec84794536302fc770cd6ec2/MdeModulePkg/Core/Dxe/Mem/Page.c#L1570-L1573?

Does this repro on ArmVirtPkg?

Thanks,
Oliver


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#114001): https://edk2.groups.io/g/devel/message/114001
Mute This Topic: https://groups.io/mt/103810212/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-