From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id BCF52AC1605 for ; Thu, 18 Jan 2024 16:48:57 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=oM/JX2wjMIFKZTQhx+iidAoj9MleG+9fpBA+yuButdE=; c=relaxed/simple; d=groups.io; h=DKIM-Filter:Message-ID:Date:MIME-Version:User-Agent:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1705596536; v=1; b=TtTk0J38CNUJHMXWQl0OTVNc7KYPjw21/uTn4YWWL8m8WOQD2hk/2nlGzX2mZN5aM2liTaVZ 8VXF3BT0IgIe4ikSi1evMavUEpSg1YGDqGxeO+oCg3EK5Q9OAvGFLCj3E0NWOXX9c46xeLzauVc hk6TLm7/2AGW21UZNhJyYzxg= X-Received: by 127.0.0.2 with SMTP id KS3xYY7687511x4h1ja2dEgD; Thu, 18 Jan 2024 08:48:56 -0800 X-Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mx.groups.io with SMTP id smtpd.web10.17741.1705596535899132418 for ; Thu, 18 Jan 2024 08:48:55 -0800 X-Received: from [10.137.194.171] (unknown [131.107.160.171]) by linux.microsoft.com (Postfix) with ESMTPSA id 7E4FD20DFD43; Thu, 18 Jan 2024 08:48:55 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 7E4FD20DFD43 Message-ID: Date: Thu, 18 Jan 2024 08:48:55 -0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] AArch64 with HeapGuard: page allocations wrongly aligned To: devel@edk2.groups.io, rebecca@os.amperecomputing.com Cc: Leif Lindholm , Ard Biesheuvel , Jian J Wang , Liming Gao , Dandan Bi References: <05f6388b-155e-427d-8e34-0ac571e97fb8@os.amperecomputing.com> From: "Oliver Smith-Denny" In-Reply-To: <05f6388b-155e-427d-8e34-0ac571e97fb8@os.amperecomputing.com> Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,osde@linux.microsoft.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: YgD7ERNpcV4Qimv5aVMwLD8ex7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=TtTk0J38; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=linux.microsoft.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On 1/18/2024 7:27 AM, Rebecca Cran via groups.io wrote: > I've been debugging an assert failure when using HeapGuard on AArch64. A= =20 > call to FreePages in SmbiosDxe is failing because the memory is aligned= =20 > to 0x1000 instead of 0x10000 as defined by=20 > RUNTIME_PAGE_ALLOCATION_GRANULARITY. >=20 > I'm enabling HeapGuard by setting the PCDs to the following values: >=20 > gEfiMdeModulePkgTokenSpaceGuid.PcdHeapGuardPropertyMask|0x0F > gEfiMdeModulePkgTokenSpaceGuid.PcdHeapGuardPageType|0xC00000000000FFFF > gEfiMdeModulePkgTokenSpaceGuid.PcdHeapGuardPoolType|0xC00000000000FFFF >=20 Hi Rebecca, Are you including this commit:=20 https://github.com/tianocore/edk2/commit/00b51e0d78a547dd78119ec44fcc74a01b= 6f79c8? Can you share some more details on where this is failing? I.e. what assert is getting tripped? Presumably without HeapGuard enabled, you aren't seeing the failure? Are you hitting this case: https://github.com/tianocore/edk2/blob/59f024c76ee57c2bec84794536302fc770cd= 6ec2/MdeModulePkg/Core/Dxe/Mem/Page.c#L1570-L1573? Does this repro on ArmVirtPkg? Thanks, Oliver -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#114001): https://edk2.groups.io/g/devel/message/114001 Mute This Topic: https://groups.io/mt/103810212/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-