From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (NAM02-SN1-obe.outbound.protection.outlook.com [40.107.96.62]) by mx.groups.io with SMTP id smtpd.web09.6416.1654694570201154081 for ; Wed, 08 Jun 2022 06:22:50 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="body hash did not verify" header.i=@amd.com header.s=selector1 header.b=2C91QLVn; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: amd.com, ip: 40.107.96.62, mailfrom: nikunjamritlal.dadhania@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VQ8s1BvbABNcSH2GEcWibo5tyrF51KunUCk56Go0Cm2fDiY3G7UwiaRGP98iLCLKxbWEBJGF+z1IvctgST5sx1CfRi5wKh4kDOCJSUuFEMbIEuSCRHFnHsFaUAVID5gtvI4uSt0gK5FUvneNnyciVqHcv8By8tMsSQ5wZKtiF3ifPzXy2mNknqNzMJtYFi8La/BblSkAUFA1epJmF1gWuoW/jYVf6OZ1XiTK+/JcS7h8QoEnXGutUh3h+weLiCCl2zzBpfz58kq7UEfb//KVALZ368w3ZkTvj8yAZrzn8PW2rIyAqZAhSj99dl/CZOQANW5PoRYHiAwzCdhJf8nFXg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2WXoVW6Vntbd0VRQNeNY0XQ1lUb04wPQoyym0iUo2hY=; b=UKecCs+I+iFyMVRBf5e8gSc40z4x5jncN1MVaiomVjQZPC91zRUcGVQeLxjp9oGDHgXyTPESbR5r1YXzP2BEU5xxF86Ym1rJk0y88mWPt8z/y+MjXpqp4HqqN72sgLtlwmyN8JKxjnKxDVGHwvFWc1nBpGWl3EG7AuwIGQzh/ohjG305so0PzR05cC8d+9Q1Wr4Kx0urawPMYg7S37tDmMLUoF9OQqEeeDRBX4UHMHIUMt25Fl1wAbxfPgrtwtIkRY2i/keCrCYB8y0ZqyJ6SLWt1UoWp7PwGeoUN0LNgUIjpyRT53+SIk7NP4B0afnYrCx4yIt1EBaib4bW5NrMYA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2WXoVW6Vntbd0VRQNeNY0XQ1lUb04wPQoyym0iUo2hY=; b=2C91QLVnPHT5P2wru1ospgXuCDqQ5ND8RNJn0eN3sdQ7lgPDMZ53FsxQfibfbOQldjHRHIB3f+KikIHAYWBWSanZbN85bn5+sYpmMeuL6jsZgreo9RiqXWHq/GSy1MSeYtaXSucRfSNqYXjCbzTeCUjSIGCfSeAGpR1hOJugvHA= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from DS7PR12MB6309.namprd12.prod.outlook.com (2603:10b6:8:96::19) by BN9PR12MB5196.namprd12.prod.outlook.com (2603:10b6:408:11d::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5314.13; Wed, 8 Jun 2022 13:22:47 +0000 Received: from DS7PR12MB6309.namprd12.prod.outlook.com ([fe80::c874:85c6:2343:5b2f]) by DS7PR12MB6309.namprd12.prod.outlook.com ([fe80::c874:85c6:2343:5b2f%4]) with mapi id 15.20.5314.019; Wed, 8 Jun 2022 13:22:47 +0000 Message-ID: Date: Wed, 8 Jun 2022 18:52:37 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.3.2 Subject: Re: [edk2-devel] [PATCH v8 3/6] OvmfPkg/BaseMemEncryptLib: Invoke page encryption state change hypercall To: "Kalra, Ashish" , "devel@edk2.groups.io" References: <12370.1654591126491114870@groups.io> CC: nikunj@amd.com From: nikunj@amd.com In-Reply-To: X-ClientProxiedBy: PN3PR01CA0025.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c01:97::9) To DS7PR12MB6309.namprd12.prod.outlook.com (2603:10b6:8:96::19) Return-Path: NikunjAmritlal.Dadhania@amd.com MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 9a8ed042-81be-4f6f-4cdf-08da4951fa5c X-MS-TrafficTypeDiagnostic: BN9PR12MB5196:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: rhAW1rhOvTHRzh8x8Ia58TWAdGYVe14P92RrTSm+T9uz8Nyg4xpHv1MFJPhyeOO7mjuXpMTsXjBN5jRVm17J7g1HPbTagCK21eUKVkirQPAD8ht0hiwj5W8Qtqm6tc+zaitvfisvpnyugEELMUX5lR3pONPMpYdeIgYRBZ+JCSLcDb9ShHx5tQVkf9euHkNOf0RJ8KNdhyCi+JkvyardQlbGrJql4/3pqOCdxtYDTs5WJLhrSENVWUQjLqdgsikT1FxfectLzxGYimyFuXZVLrWyyg0dzT+fB8ONWNRL0EyO3O7raLSH6BgzRQj3xD9a0M0a2xxAbjQHkKOdPbHK2OyF1LYmUkJiUNh45Ga2LDXTpngXJRL8yGPWANJ8HYOYuwtOgscy6QDWy4wfzqow2dQCVazCyHuMGN4Uugvm36qaoFjW2NkdIR1l00SKHVXoPvF0b45EdlUA/WybwE7RqaKNWOQ3X0wzuc2tDDuuWZFdbCbN0aK2ejhsSoFA0xpeVH8R6K7RB3Fu1rRss1iFBUPNVpK7/Eg1ZtpWmpNRgFm3uYDIRSrQB/S36lx5qLEy3zqS1728FQNz3KNX7O/+RwNTZstVjjhE1wF2ztnotRC0h4ffi6rU5sajPoBs2zc7kikUBR9iG7y0JwsigT5l4za0BsT6+Z5acHlp+x9daZnzB2xqTVFq807zBduDxXUYK7KYTTz7g1IrKSW/pFuKsIQLCXdnwdkQ4j+HNHl7GbU= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR12MB6309.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(8676002)(6506007)(19627235002)(316002)(36756003)(4326008)(5660300002)(31696002)(66946007)(8936002)(66556008)(110136005)(66476007)(6512007)(26005)(6486002)(186003)(508600001)(38100700002)(2906002)(55236004)(6666004)(53546011)(2616005)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?WqXeypUXIS5dzdVwoXCecrAlNlMTaODEOyjFCPs4+QHd+Tm06lzmDtlE+/NV?= =?us-ascii?Q?j4PrejE8/StEQHH5s/uJq/wwnQmZ6hTlcQJ0UjXk5m/bbJohkQRNKzhh6o0H?= =?us-ascii?Q?BrN/aGOm1R+embHRyNATSOpS3Z8RHJyWw3M+Lf9Tr4Ftp/UdtdclO25M3Ewc?= =?us-ascii?Q?N8/DVrQgQnPRyGx/CL2p58w2NNqkj2I4XxpB0bvW4YijGWjD4/U9sxnLrfLT?= =?us-ascii?Q?VYiPHqkDb5Hp1ZmODZ6Jr6kpx6y2B/w4umaIj2nGMN6JdkOE1IUg6Oml16lr?= =?us-ascii?Q?YdZtVwSPhgKXxDl3stDeNtMc7BCjlfigGPOdQ0z1RzkZYJZ+LnoClwsNvYwu?= =?us-ascii?Q?XqcUPkiGudiMkUSwmiB92IyKW0UEWYd2qpirEHW3TjNtm2h2yj1s+FBFjuEE?= =?us-ascii?Q?mu2LMYrPCb+BxY5AbUhqPPr4v6fqG54Kq8qA1/hrQfC1WunwHzJKcZ66mGR1?= =?us-ascii?Q?83zBWb8C7NyElyctNKnuYpUBco9C711Lsn7kDHBJf5v7/4kUO4fGSU4eYZ1E?= =?us-ascii?Q?ql3h7Ms4DFAZPXJVQVOPqVOlgvYXCg5CuV0FEZCIRvVurwXgt+y3batE47rr?= =?us-ascii?Q?qft4kY0aWnqugYpwNb1MvsiJ/CPfyQgyBlUjelaDrHRi6nuO7jVZddgbVs2d?= =?us-ascii?Q?hztTeMVidWdvYGLcoqQTKbBKpvg+cSmKrsXI/IdScHBvmukVymIaMmY6tEZb?= =?us-ascii?Q?x/htuYoHp2A8a1qb9YLqqUBYKixxjLG3ZXuXqu1DKrmVmHr7MilI0lWM9pCw?= =?us-ascii?Q?TzP37X7LBMKy710FhmQZih8NKrtP/lE4Je/whOasDchQWVqBMomw3Dyanr0H?= =?us-ascii?Q?y8Q2mNmqQopXiYP07s692uqHxTqC9KX5XPebjlbEnZspVymtQ3TpI4bQv0GO?= =?us-ascii?Q?U99p2SXDmQdbHvcos6qzS8OzkoU3h678wIzTkfVN5zvKUIVOSLrlCc2EYc19?= =?us-ascii?Q?4vW3++CDrV3Yx6VVLOtOYZENu1fQ77/TDCpjCmrp/yIdaQ9Q1Gr5I+VV5bFy?= =?us-ascii?Q?IQwcmVaJ0zMHphbGQoB3jcxgg8gD+mNxZ/+c2KknHmggC9ws5exI8ItSCB+N?= =?us-ascii?Q?q0Fcx/h+USGBmEVpw8ML+VO1pzom/LihA2k5dvN7DG9Ka5ERwf0dNJMYjzJN?= =?us-ascii?Q?YlcAc6oU/BqqGcy/hhiOpkvHvoXzE8nZr0GxpBnGh2QL0XAvX2X08yrgNklF?= =?us-ascii?Q?K9JeFlofJ8iwDN5eX9jtetik2U0ArrBWaV+tHAsWtA5SxG4ozGXJ8q9B3DrD?= =?us-ascii?Q?gZbAXTmSKQxoyOOf8/GHkwM2U+hvgT0qjGSyiXOBF7blfdz2xi6fcKWQ/+V8?= =?us-ascii?Q?iSyctpN/7OwMorNnlDM8asFvPwArGyT7PpVWSd1L4h725cnaFHve6qfiWleZ?= =?us-ascii?Q?a4vnZZGpX8upXEOhWU+EgoD93zPLkMedLW/pzDRtM1HSVoiYuvcXMZqm8r2x?= =?us-ascii?Q?XknoB/DI4wZM2BMpKD8B3HhHE1Zka+eXozeZ/sDap6OPjjhHWxLQIb+WTI/V?= =?us-ascii?Q?6smLgunXWbLkkbLDPY17UcmJSDMqtpc2ABGPiTrIa4deyPT/yy6GZ+W+tg80?= =?us-ascii?Q?j7vdlmBR5bbNjgrGlGIKptFAQ8DIOZcF89ycEXv7Pj0uBk2MA8c97PUnJS5D?= =?us-ascii?Q?n7qX17P2QsBLNR9NMcIRbVba6Y8yg7ZxbprlQWtkD/OvUSOZMPRAyMxY9eSz?= =?us-ascii?Q?mZHMFy1JekQoOZE6Ku4OqNbTCch6YQntk9aDmn10w9WvSboVMznzKr1VjoMY?= =?us-ascii?Q?oJ211MnyAA=3D=3D?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9a8ed042-81be-4f6f-4cdf-08da4951fa5c X-MS-Exchange-CrossTenant-AuthSource: DS7PR12MB6309.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Jun 2022 13:22:47.1939 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: fR3DhsH18OBqi5VjPFWBdUuraP2ltHxDXRcXSVelOimi27oXb2JigRS2IK8CjVtoXDxJEEQNCkQXzEKeatATiQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR12MB5196 Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Hi Ashish, On 6/7/2022 10:58 PM, Kalra, Ashish wrote: >=20 > Hello Nikunj, >=20 > Yes we can move MemEncryptSevLiveMigrationIsEnabled() check here before c= alling SetMemoryEncDecHypercall3() >=20 > but then we also need to remove the same check from inside SetMemoryEncDe= cHypercall3() function. Sure, and we will have to check this at all places that are calling SetMemo= ryEncDecHypercall3() Regards Nikunj > =C2=A0 >=20 > Thanks, >=20 > Ashish >=20 > =C2=A0 >=20 > *From:* nikunj via groups.io > *Sent:* Tuesday, June 7, 2022 3:39 AM > *To:* Kalra, Ashish ; devel@edk2.groups.io > *Subject:* Re: [edk2-devel] [PATCH v8 3/6] OvmfPkg/BaseMemEncryptLib: Inv= oke page encryption state change hypercall >=20 > =C2=A0 >=20 > Hi Ashish, >=20 > For case with latest OVMF and older qemu that does not enable live migrat= ions, > SetMemoryEncDecHypercall3() returns RETURN_UNSUPPORTED, which is correct. > But then its actually treated as an error and OVMF sees an assert. This i= s a valid usecase > and OVMF should move ahead without live migration and HC_MAP_GPA_RANGE. > .... >=20 >> + // >> + // Notify Hypervisor on C-bit status >> + // >> + if (CBitChanged) { >=20 > Should we call the SetMemoryEncDecHypercall() only if migration is enable= d like below? >=20 > if (CBitChanged && MemEncryptSevLiveMigrationIsEnabled () { >=20 >> + Status =3D SetMemoryEncDecHypercall3 ( >> + OrigPhysicalAddress, >> + EFI_SIZE_TO_PAGES (OrigLength), >> + (Mode =3D=3D SetCBit) ? TRUE : FALSE >> + ); >> + } >> + >> ... >> >> return Status; >=20 > Regards > Nikunj >=20