From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.24; helo=mga09.intel.com; envelope-from=ruiyu.ni@intel.com; receiver=edk2-devel@lists.01.org Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 07ACF2116DF97 for ; Wed, 17 Oct 2018 18:59:15 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 Oct 2018 18:59:15 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,393,1534834800"; d="scan'208";a="98390132" Received: from ray-dev.ccr.corp.intel.com (HELO [10.239.9.11]) ([10.239.9.11]) by fmsmga004.fm.intel.com with ESMTP; 17 Oct 2018 18:59:14 -0700 To: Laszlo Ersek , edk2-devel-01 Cc: Michael D Kinney , Liming Gao References: <20180929222312.32150-1-lersek@redhat.com> <20180929222312.32150-2-lersek@redhat.com> From: "Ni, Ruiyu" Message-ID: Date: Thu, 18 Oct 2018 10:00:26 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <20180929222312.32150-2-lersek@redhat.com> Subject: Re: [PATCH 1/5] MdePkg/BaseSynchronizationLib GCC: fix whitespace and comments X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Oct 2018 01:59:16 -0000 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit On 9/30/2018 6:23 AM, Laszlo Ersek wrote: > The "GccInline.c" files have some inconsistent whitespace, and missing (or > incorrect) operand comments. Fix and unify them. > > This patch doesn't change behavior. > > Cc: Liming Gao > Cc: Michael D Kinney > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1208 > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Laszlo Ersek > --- > MdePkg/Library/BaseSynchronizationLib/Ia32/GccInline.c | 35 ++++++------- > MdePkg/Library/BaseSynchronizationLib/X64/GccInline.c | 53 +++++++++----------- > 2 files changed, 39 insertions(+), 49 deletions(-) > > diff --git a/MdePkg/Library/BaseSynchronizationLib/Ia32/GccInline.c b/MdePkg/Library/BaseSynchronizationLib/Ia32/GccInline.c > index fa2be7f4b35c..1976720ac636 100644 > --- a/MdePkg/Library/BaseSynchronizationLib/Ia32/GccInline.c > +++ b/MdePkg/Library/BaseSynchronizationLib/Ia32/GccInline.c > @@ -39,7 +39,7 @@ InternalSyncIncrement ( > "movl $1, %%eax \n\t" > "lock \n\t" > "xadd %%eax, %1 \n\t" > - "inc %%eax " > + "inc %%eax \n\t" > : "=a" (Result), // %0 > "+m" (*Value) // %1 > : // no inputs that aren't also outputs > @@ -48,7 +48,6 @@ InternalSyncIncrement ( > ); > > return Result; > - > } > > > @@ -76,10 +75,10 @@ InternalSyncDecrement ( > "movl $-1, %%eax \n\t" > "lock \n\t" > "xadd %%eax, %1 \n\t" > - "dec %%eax " > - : "=a" (Result), // %0 > - "+m" (*Value) // %1 > - : // no inputs that aren't also outputs > + "dec %%eax \n\t" > + : "=a" (Result), // %0 > + "+m" (*Value) // %1 > + : // no inputs that aren't also outputs > : "memory", > "cc" > ); > @@ -87,6 +86,7 @@ InternalSyncDecrement ( > return Result; > } > > + > /** > Performs an atomic compare exchange operation on a 16-bit unsigned integer. > > @@ -113,15 +113,13 @@ InternalSyncCompareExchange16 ( > IN UINT16 ExchangeValue > ) > { > - > __asm__ __volatile__ ( > - " \n\t" > "lock \n\t" > "cmpxchgw %1, %2 \n\t" > - : "=a" (CompareValue) > - : "q" (ExchangeValue), > - "m" (*Value), > - "0" (CompareValue) > + : "=a" (CompareValue) // %0 > + : "q" (ExchangeValue), // %1 > + "m" (*Value), // %2 > + "0" (CompareValue) // %3 > : "memory", > "cc" > ); > @@ -129,6 +127,7 @@ InternalSyncCompareExchange16 ( > return CompareValue; > } > > + > /** > Performs an atomic compare exchange operation on a 32-bit unsigned integer. > > @@ -155,15 +154,13 @@ InternalSyncCompareExchange32 ( > IN UINT32 ExchangeValue > ) > { > - > __asm__ __volatile__ ( > - " \n\t" > "lock \n\t" > "cmpxchgl %1, %2 \n\t" > - : "=a" (CompareValue) // %0 > - : "q" (ExchangeValue), // %1 > - "m" (*Value), // %2 > - "0" (CompareValue) // %4 > + : "=a" (CompareValue) // %0 > + : "q" (ExchangeValue), // %1 > + "m" (*Value), // %2 > + "0" (CompareValue) // %3 > : "memory", > "cc" > ); > @@ -171,6 +168,7 @@ InternalSyncCompareExchange32 ( > return CompareValue; > } > > + > /** > Performs an atomic compare exchange operation on a 64-bit unsigned integer. > > @@ -197,7 +195,6 @@ InternalSyncCompareExchange64 ( > ) > { > __asm__ __volatile__ ( > - " \n\t" > "push %%ebx \n\t" > "movl %2,%%ebx \n\t" > "lock \n\t" > diff --git a/MdePkg/Library/BaseSynchronizationLib/X64/GccInline.c b/MdePkg/Library/BaseSynchronizationLib/X64/GccInline.c > index ab7efe23c4db..0212798d7a27 100644 > --- a/MdePkg/Library/BaseSynchronizationLib/X64/GccInline.c > +++ b/MdePkg/Library/BaseSynchronizationLib/X64/GccInline.c > @@ -39,7 +39,7 @@ InternalSyncIncrement ( > "movl $1, %%eax \n\t" > "lock \n\t" > "xadd %%eax, %1 \n\t" > - "inc %%eax " > + "inc %%eax \n\t" > : "=a" (Result), // %0 > "+m" (*Value) // %1 > : // no inputs that aren't also outputs > @@ -75,10 +75,10 @@ InternalSyncDecrement ( > "movl $-1, %%eax \n\t" > "lock \n\t" > "xadd %%eax, %1 \n\t" > - "dec %%eax " > - : "=a" (Result), // %0 > - "+m" (*Value) // %1 > - : // no inputs that aren't also outputs > + "dec %%eax \n\t" > + : "=a" (Result), // %0 > + "+m" (*Value) // %1 > + : // no inputs that aren't also outputs > : "memory", > "cc" > ); > @@ -113,16 +113,14 @@ InternalSyncCompareExchange16 ( > IN UINT16 ExchangeValue > ) > { > - > - > __asm__ __volatile__ ( > "lock \n\t" > - "cmpxchgw %3, %1 " > - : "=a" (CompareValue), > - "=m" (*Value) > - : "a" (CompareValue), > - "r" (ExchangeValue), > - "m" (*Value) > + "cmpxchgw %3, %1 \n\t" > + : "=a" (CompareValue), // %0 > + "=m" (*Value) // %1 > + : "a" (CompareValue), // %2 > + "r" (ExchangeValue), // %3 > + "m" (*Value) // %4 > : "memory", > "cc" > ); > @@ -157,16 +155,14 @@ InternalSyncCompareExchange32 ( > IN UINT32 ExchangeValue > ) > { > - > - > __asm__ __volatile__ ( > "lock \n\t" > - "cmpxchgl %3, %1 " > - : "=a" (CompareValue), // %0 > - "=m" (*Value) // %1 > - : "a" (CompareValue), // %2 > - "r" (ExchangeValue), // %3 > - "m" (*Value) > + "cmpxchgl %3, %1 \n\t" > + : "=a" (CompareValue), // %0 > + "=m" (*Value) // %1 > + : "a" (CompareValue), // %2 > + "r" (ExchangeValue), // %3 > + "m" (*Value) // %4 > : "memory", > "cc" > ); > @@ -200,20 +196,17 @@ InternalSyncCompareExchange64 ( > IN UINT64 ExchangeValue > ) > { > - > __asm__ __volatile__ ( > "lock \n\t" > - "cmpxchgq %3, %1 " > - : "=a" (CompareValue), // %0 > - "=m" (*Value) // %1 > - : "a" (CompareValue), // %2 > - "r" (ExchangeValue), // %3 > - "m" (*Value) > + "cmpxchgq %3, %1 \n\t" > + : "=a" (CompareValue), // %0 > + "=m" (*Value) // %1 > + : "a" (CompareValue), // %2 > + "r" (ExchangeValue), // %3 > + "m" (*Value) // %4 > : "memory", > "cc" > ); > > return CompareValue; > } > - > - > Thanks! Reviewed-by: Ruiyu Ni -- Thanks, Ray